From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH v3.6 16/22] drm/i915: Implement intel_crtc_control using atomic state, v4. Date: Thu, 28 May 2015 17:57:51 -0700 Message-ID: <20150529005751.GE15716@intel.com> References: <1432129094-11765-1-git-send-email-maarten.lankhorst@linux.intel.com> <1432137874-20543-1-git-send-email-maarten.lankhorst@linux.intel.com> <1432137874-20543-7-git-send-email-maarten.lankhorst@linux.intel.com> <5564304A.8090808@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id 5BC1F6EC9E for ; Thu, 28 May 2015 17:57:53 -0700 (PDT) Content-Disposition: inline In-Reply-To: <5564304A.8090808@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: Intel Graphics Development List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBNYXkgMjYsIDIwMTUgYXQgMTA6MzU6MjJBTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gQXNzdW1lIHRoZSBjYWxsZXJzIGxvY2sgZXZlcnl0aGluZyB3aXRoIGRybV9t b2Rlc2V0X2xvY2tfYWxsLgo+IAo+IFRoaXMgY2hhbmdlIGhhZCB0byBiZSBkb25lIGFmdGVyIGNv bnZlcnRpbmcgc3VzcGVuZC9yZXN1bWUgdG8KPiB1c2UgYXRvbWljX3N0YXRlIHNvIHRoZSBhdG9t aWMgc3RhdGUgaXMgcHJlc2VydmVkLCBvdGhlcndpc2UKPiBhbGwgdHJhbnNpdGlvbmFsIHN0YXRl IGlzIGVyYXNlZC4KPiAKPiBOb3cgYWxsIGNhbGxlcnMgb2YgLmNydGNfZW5hYmxlIGFuZCAuY3J0 Y19kaXNhYmxlIGdvIHRocm91Z2gKPiBhdG9taWMgbW9kZXNldCEgOi1ECj4gCj4gQ2hhbmdlcyBz aW5jZSB2MToKPiAtIE9ubHkgY2hlY2sgZm9yIGNydGNfc3RhdGUtPmFjdGl2ZSBpbiB2YWxsZXl2 aWV3X21vZGVzZXRfZ2xvYmFsX3BpcGVzLgo+IC0gT25seSBjaGVjayBmb3IgY3J0Y19zdGF0ZS0+ YWN0aXZlIGluIG1vZGVzZXRfdXBkYXRlX2NydGNfcG93ZXJfZG9tYWlucy4KPiBDaGFuZ2VzIHNp bmNlIHYyOgo+IC0gUmV3b3JrIG9uIHRvcCBvZiB0aGUgY2hhbmdlZCBwYXRjaCBvcmRlci4KPiBD aGFuZ2VzIHNpbmNlIHYzOgo+IC0gUmVuYW1lIGludGVsX2NydGNfdG9nZ2xlIGluIGRlc2NyaXB0 aW9uIHRvICpfY29udHJvbAo+IC0gQ2hhbmdlIHJldHVybiB2YWx1ZSB0byBpbnQuCj4gLSBEbyBu b3QgYWRkIHBsYW5lIHN0YXRlLCBzaG91bGQgYmUgZG9uZSBpbXBsaWNpdGx5IGFscmVhZHkuCj4g Cj4gU2lnbmVkLW9mZi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxp bnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxh eS5jIHwgNTMgKysrKysrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rydi5oICAgICB8ICAyICstCj4gIDIgZmlsZXMgY2hhbmdlZCwg MzMgaW5zZXJ0aW9ucygrKSwgMjIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rpc3BsYXkuYwo+IGluZGV4IGU5NjgwZWI4NWJkMC4uMzJiYWIyODQzMmY3IDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC01OTczLDM4ICs1OTczLDQ5IEBA IHZvaWQgaW50ZWxfZGlzcGxheV9zdXNwZW5kKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gIH0K PiAgCj4gIC8qIE1hc3RlciBmdW5jdGlvbiB0byBlbmFibGUvZGlzYWJsZSBDUlRDIGFuZCBjb3Jy ZXNwb25kaW5nIHBvd2VyIHdlbGxzICovCj4gLXZvaWQgaW50ZWxfY3J0Y19jb250cm9sKHN0cnVj dCBkcm1fY3J0YyAqY3J0YywgYm9vbCBlbmFibGUpCj4gK2ludCBpbnRlbF9jcnRjX2NvbnRyb2wo c3RydWN0IGRybV9jcnRjICpjcnRjLCBib29sIGVuYWJsZSkKCldlIGNoYW5nZSB0aGUgcmV0dXJu IHZhbHVlIHRvICdpbnQnIGhlcmUsIGJ1dCB3ZSBuZXZlciBjaGVjayB0aGUgZXJyb3IKY29kZSBh bnl3aGVyZS4gIE1heWJlIHdlIHNob3VsZCBob2xkIHRoaXMgb2ZmIGZvciBhbm90aGVyIHBhdGNo IGFuZCB0aGVuCmFsc28gcHJvcGFnYXRlIHRoZSByZXR1cm4gdmFsdWUgYmFjayB1cCB0aGUgY2Fs bCBjaGFpbj8gIEl0IHNlZW1zIGxpa2UKYXQgbGVhc3Qgc29tZSBvZiB0aGUgY29ubmVjdG9yLXNw ZWNpZmljIERQTVMgZnVuY3Rpb25zIHNob3VsZCByZWNvZ25pemUKdGhlIGZhaWx1cmUgb2YgaW50 ZWxfY3J0Y191cGRhdGVfZHBtcygpIGJlZm9yZSB0cnlpbmcgdG8gY29udGludWUgd2l0aApvdGhl ciBvcGVyYXRpb25zLgoKCj4gIHsKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5k ZXY7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9wcml2 YXRlOwo+ICsJc3RydWN0IGRybV9tb2RlX2NvbmZpZyAqY29uZmlnID0gJmRldi0+bW9kZV9jb25m aWc7Cj4gKwlzdHJ1Y3QgZHJtX21vZGVzZXRfYWNxdWlyZV9jdHggKmN0eCA9IGNvbmZpZy0+YWNx dWlyZV9jdHg7Cj4gIAlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YyA9IHRvX2ludGVsX2Ny dGMoY3J0Yyk7Cj4gLQllbnVtIGludGVsX2Rpc3BsYXlfcG93ZXJfZG9tYWluIGRvbWFpbjsKPiAt CXVuc2lnbmVkIGxvbmcgZG9tYWluczsKPiArCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpwaXBl X2NvbmZpZzsKPiArCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZTsKPiArCWludCByZXQ7 Cj4gIAo+ICAJaWYgKGVuYWJsZSA9PSBpbnRlbF9jcnRjLT5hY3RpdmUpCj4gLQkJcmV0dXJuOwo+ ICsJCXJldHVybiAwOwo+ICAKPiAgCWlmIChlbmFibGUgJiYgIWNydGMtPnN0YXRlLT5lbmFibGUp Cj4gLQkJcmV0dXJuOwo+ICsJCXJldHVybiAwOwo+ICAKPiAtCWNydGMtPnN0YXRlLT5hY3RpdmUg PSBlbmFibGU7Cj4gLQlpZiAoZW5hYmxlKSB7Cj4gLQkJZG9tYWlucyA9IGdldF9jcnRjX3Bvd2Vy X2RvbWFpbnMoY3J0Yyk7Cj4gLQkJZm9yX2VhY2hfcG93ZXJfZG9tYWluKGRvbWFpbiwgZG9tYWlu cykKPiAtCQkJaW50ZWxfZGlzcGxheV9wb3dlcl9nZXQoZGV2X3ByaXYsIGRvbWFpbik7Cj4gLQkJ aW50ZWxfY3J0Yy0+ZW5hYmxlZF9wb3dlcl9kb21haW5zID0gZG9tYWluczsKPiArCS8qIHRoaXMg ZnVuY3Rpb24gc2hvdWxkIGJlIGNhbGxlZCB3aXRoIGRybV9tb2Rlc2V0X2xvY2tfYWxsIGZvciBu b3cgKi8KPiArCWlmIChXQVJOX09OKCFjdHgpKQo+ICsJCXJldHVybiAtRUlPOwoKRUlPIHNlZW1z IGxpa2UgYW4gdW51c3VhbCBjaG9pY2UgaGVyZSAoYnV0IEknbSBub3QgcmVhbGx5IHN1cmUgd2hh dCB0aGUKYmVzdCBvcHRpb24gd291bGQgYmUpLgoKCk1hdHQKCj4gKwlsb2NrZGVwX2Fzc2VydF9o ZWxkKCZjdHgtPnd3X2N0eCk7Cj4gIAo+IC0JCWRldl9wcml2LT5kaXNwbGF5LmNydGNfZW5hYmxl KGNydGMpOwo+IC0JCWludGVsX2NydGNfZW5hYmxlX3BsYW5lcyhjcnRjKTsKPiAtCX0gZWxzZSB7 Cj4gLQkJaW50ZWxfY3J0Y19kaXNhYmxlX3BsYW5lcyhjcnRjKTsKPiAtCQlkZXZfcHJpdi0+ZGlz cGxheS5jcnRjX2Rpc2FibGUoY3J0Yyk7Cj4gKwlzdGF0ZSA9IGRybV9hdG9taWNfc3RhdGVfYWxs b2MoZGV2KTsKPiArCWlmIChXQVJOX09OKCFzdGF0ZSkpCj4gKwkJcmV0dXJuIC1FTk9NRU07Cj4g IAo+IC0JCWRvbWFpbnMgPSBpbnRlbF9jcnRjLT5lbmFibGVkX3Bvd2VyX2RvbWFpbnM7Cj4gLQkJ Zm9yX2VhY2hfcG93ZXJfZG9tYWluKGRvbWFpbiwgZG9tYWlucykKPiAtCQkJaW50ZWxfZGlzcGxh eV9wb3dlcl9wdXQoZGV2X3ByaXYsIGRvbWFpbik7Cj4gLQkJaW50ZWxfY3J0Yy0+ZW5hYmxlZF9w b3dlcl9kb21haW5zID0gMDsKPiArCXN0YXRlLT5hY3F1aXJlX2N0eCA9IGN0eDsKPiArCXN0YXRl LT5hbGxvd19tb2Rlc2V0ID0gdHJ1ZTsKPiArCj4gKwlwaXBlX2NvbmZpZyA9IGludGVsX2F0b21p Y19nZXRfY3J0Y19zdGF0ZShzdGF0ZSwgaW50ZWxfY3J0Yyk7Cj4gKwlpZiAoSVNfRVJSKHBpcGVf Y29uZmlnKSkgewo+ICsJCXJldCA9IFBUUl9FUlIocGlwZV9jb25maWcpOwo+ICsJCWdvdG8gZXJy Owo+ICAJfQo+ICsJcGlwZV9jb25maWctPmJhc2UuYWN0aXZlID0gZW5hYmxlOwo+ICsKPiArCXJl dCA9IGludGVsX3NldF9tb2RlKHN0YXRlKTsKPiArCWlmICghcmV0KQo+ICsJCXJldHVybiByZXQ7 Cj4gKwo+ICtlcnI6Cj4gKwlEUk1fRVJST1IoIlVwZGF0aW5nIGNydGMgYWN0aXZlIGZhaWxlZCB3 aXRoICVpXG4iLCByZXQpOwo+ICsJZHJtX2F0b21pY19zdGF0ZV9mcmVlKHN0YXRlKTsKPiArCXJl dHVybiByZXQ7Cj4gIH0KPiAgCj4gIC8qKgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcnYuaCBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gaW5k ZXggNjBhMjlmZjY1ZjFmLi5jMTEzZjE4NzA5MGYgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9k cnYuaAo+IEBAIC05ODksNyArOTg5LDcgQEAgdm9pZCBpbnRlbF9tYXJrX2J1c3koc3RydWN0IGRy bV9kZXZpY2UgKmRldik7Cj4gIHZvaWQgaW50ZWxfbWFya19pZGxlKHN0cnVjdCBkcm1fZGV2aWNl ICpkZXYpOwo+ICB2b2lkIGludGVsX2NydGNfcmVzdG9yZV9tb2RlKHN0cnVjdCBkcm1fY3J0YyAq Y3J0Yyk7Cj4gIHZvaWQgaW50ZWxfZGlzcGxheV9zdXNwZW5kKHN0cnVjdCBkcm1fZGV2aWNlICpk ZXYpOwo+IC12b2lkIGludGVsX2NydGNfY29udHJvbChzdHJ1Y3QgZHJtX2NydGMgKmNydGMsIGJv b2wgZW5hYmxlKTsKPiAraW50IGludGVsX2NydGNfY29udHJvbChzdHJ1Y3QgZHJtX2NydGMgKmNy dGMsIGJvb2wgZW5hYmxlKTsKPiAgdm9pZCBpbnRlbF9jcnRjX3VwZGF0ZV9kcG1zKHN0cnVjdCBk cm1fY3J0YyAqY3J0Yyk7Cj4gIHZvaWQgaW50ZWxfZW5jb2Rlcl9kZXN0cm95KHN0cnVjdCBkcm1f ZW5jb2RlciAqZW5jb2Rlcik7Cj4gIGludCBpbnRlbF9jb25uZWN0b3JfaW5pdChzdHJ1Y3QgaW50 ZWxfY29ubmVjdG9yICopOwo+IC0tIAo+IDIuMS4wCj4gCj4gCj4gX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJbnRlbC1nZnggbWFpbGluZyBsaXN0Cj4g SW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHA6Ly9saXN0cy5mcmVlZGVza3Rv cC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngKCi0tIApNYXR0IFJvcGVyCkdyYXBoaWNz IFNvZnR3YXJlIEVuZ2luZWVyCklvVEcgUGxhdGZvcm0gRW5hYmxpbmcgJiBEZXZlbG9wbWVudApJ bnRlbCBDb3Jwb3JhdGlvbgooOTE2KSAzNTYtMjc5NQpfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=