Re: [PATCH v4 19/27] drm/i915: Read hw state into an atomic state struct, v2.

Tvrtko Ursulin
2015-06-09T11:48:42Z

On 06/01/2015 11:50 AM, Maarten Lankhorst wrote:
> From: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
>
> To make this work we load the new hardware state into the
> atomic_state, then swap it with the sw state.
>
> This lets us change the force restore path in setup_hw_state()
> to use a single call to intel_mode_set() to restore all the
> previous state.
>
> As a nice bonus this kills off encoder->new_encoder,
> connector->new_enabled and crtc->new_enabled. They were used only
> to restore the state after a modeset.
>
> Changes since v1:
> - Make sure all possible planes are added with their crtc set,
> so they will be turned off on first modeset.
>
> Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

This breaks display for me, which is eDP on SKL. At least bisect points
to it. A lot of these in the logs:

*ERROR* mismatch in dp_m_n.link_m (expected 701594 or 0, found 350797)

And the display does not light up.

Regards,

Tvrtko