From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH v6 3/8] drm/i915: Unify ilk and hsw .get_aux_clock_divider Date: Thu, 4 Jun 2015 18:17:48 +0300 Message-ID: <20150604151748.GO5176@intel.com> References: <1433335514-4156-1-git-send-email-mika.kahola@intel.com> <1433335514-4156-4-git-send-email-mika.kahola@intel.com> <877frjbo84.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTP id 34F2B6E1F7 for ; Thu, 4 Jun 2015 08:18:00 -0700 (PDT) Content-Disposition: inline In-Reply-To: <877frjbo84.fsf@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jani Nikula Cc: intel-gfx@lists.freedesktop.org, "Syrjala, Ville" List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdW4gMDQsIDIwMTUgYXQgMDQ6MjQ6NDNQTSArMDMwMCwgSmFuaSBOaWt1bGEgd3Jv dGU6Cj4gT24gV2VkLCAwMyBKdW4gMjAxNSwgTWlrYSBLYWhvbGEgPG1pa2Eua2Fob2xhQGludGVs LmNvbT4gd3JvdGU6Cj4gPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGlu dXguaW50ZWwuY29tPgo+ID4KPiA+IGlsa19nZXRfYXV4X2Nsb2NrX2RpdmlkZXIoKSBpcyBub3cg YSBzdWJzZXQgb2YKPiA+IGhzd19nZXRfYXV4X2Nsb2NrX2RpdmlkZXIoKSBzbyB1bmlmeSB0aGVt Lgo+IAo+IEkgZG8gbGlrZSB0aGUgY2xhcml0eSBvZiBoYXZpbmcgdGhlc2UgdHdvIHNlcGFyYXRl LAoKSSBzZWUgbm8gY2xhcml0eS4gSnVzdCBwb2ludGxlc3MgZHVwbGljYXRpb24gd2hpY2ggcmlz a3MgZGlmZmVyZW50CmJ1Z3MgaW4gZGlmZmVyZW50IHN1YnNldHMgb2YgdGhlIHBsYXRmb3Jtcy4K Cj4gZXNwZWNpYWxseSB3aXRoIHRoZQo+IGVhcmx5IHJldHVybiBpbiB0aGUgaWxrIHZlcnNpb24g YW5kIHRoZSB3L2EgaW4gdGhlIGhzdy9iZHcgdmVyc2lvbgo+IE1vcmVvdmVyIHRoZXJlJ3MgdGhl IHN1YnRsZSByb3VuZCB1cCB2cy4gY2xvc2VzdCBkaWZmZXJlbmNlLCBhbmQgYQo+IGhpc3Rvcnkg b2YgYXV4IGJ1Z3MuLi4KClRoZSB1cCB2cy4gY2xvc2VzdCBtYWtlcyBubyBkaWZmZXJlbmNlIGZv ciBJTEstSVZCIHNpbmNlIHRoZSBjZGNsayBpcwplaXRoZXIgNDUwIG9yIDQwMCBNSHouIEFueXdh eSBJIHN1cHBvc2Ugd2Ugc2hvdWxkIGp1c3QgY2hhbmdlIHRoZW0gYWxsCnRvIHVzZSBESVZfUk9V TkRfQ0xPU0VTVCgpLgoKPiAKPiBJJ20gZHJvcHBpbmcgdGhpcyBvbmUsIGRvZXNuJ3Qgc2VlbSB0 byBhZmZlY3QgbGF0ZXIgcGF0Y2hlcy4KCk5vIGJpZ2dpZS4gQnV0IEknbSBmYWlybHkgc3VyZSBJ J2xsIGV2ZW50dWFsbHkgc2VuZCBwYXRjaGVzIHRvIHN0b3JlCnRoZSByYXdjbGsgaW4gZGV2X3By aXYsIGF0IHdoaWNoIHBvaW50IEknbGwgcHJvcG9zZSBraWxsaW5nIGFsbCBvZgp0aGVzZSAod2Vs bCwgbWF5YmUgc2V0dGxpbmcgZm9yIHNrbCsgdnMuIHRoZSByZXN0KS4KCj4gCj4gQlIsCj4gSmFu aS4KPiAKPiAKPiA+Cj4gPiB2MjogUmViYXNlZCB0byB0aGUgbGF0ZXN0Cj4gPiB2MzogUmViYXNl ZCB0byB0aGUgbGF0ZXN0Cj4gPiB2NDogRml4IGZvciBwYXRjaCBzdHlsZSBwcm9ibGVtcwo+ID4K PiA+IFNpZ25lZC1vZmYtYnk6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5p bnRlbC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBNaWthIEthaG9sYSA8bWlrYS5rYWhvbGFAaW50 ZWwuY29tPgo+ID4KPiA+IEF1dGhvcjogICAgVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxh QGxpbnV4LmludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2RwLmMgfCAyMyArKystLS0tLS0tLS0tLS0tLS0tLS0tLQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAz IGluc2VydGlvbnMoKyksIDIwIGRlbGV0aW9ucygtKQo+ID4KPiA+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHAuYwo+ID4gaW5kZXggOWE2NTE3ZC4uOTU5ZjExNSAxMDA2NDQKPiA+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2RwLmMKPiA+IEBAIC03MDQsMjMgKzcwNCw2IEBAIHN0YXRpYyB1aW50MzJfdCBpbGtfZ2V0 X2F1eF9jbG9ja19kaXZpZGVyKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHAsIGludCBpbmRleCkK PiA+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGludGVsX2RpZ19wb3J0LT5iYXNlLmJhc2Uu ZGV2Owo+ID4gIAlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSBkZXYtPmRldl9w cml2YXRlOwo+ID4gIAo+ID4gLQlpZiAoaW5kZXgpCj4gPiAtCQlyZXR1cm4gMDsKPiA+IC0KPiA+ IC0JaWYgKGludGVsX2RpZ19wb3J0LT5wb3J0ID09IFBPUlRfQSkgewo+ID4gLQkJcmV0dXJuIERJ Vl9ST1VORF9VUChkZXZfcHJpdi0+Y2RjbGtfZnJlcSwgMjAwMCk7Cj4gPiAtCj4gPiAtCX0gZWxz ZSB7Cj4gPiAtCQlyZXR1cm4gRElWX1JPVU5EX1VQKGludGVsX3BjaF9yYXdjbGsoZGV2KSwgMik7 Cj4gPiAtCX0KPiA+IC19Cj4gPiAtCj4gPiAtc3RhdGljIHVpbnQzMl90IGhzd19nZXRfYXV4X2Ns b2NrX2RpdmlkZXIoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwgaW50IGluZGV4KQo+ID4gLXsK PiA+IC0Jc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQgPSBkcF90b19k aWdfcG9ydChpbnRlbF9kcCk7Cj4gPiAtCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBpbnRlbF9k aWdfcG9ydC0+YmFzZS5iYXNlLmRldjsKPiA+IC0Jc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl dl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiA+IC0KPiA+ICAJaWYgKGludGVsX2RpZ19wb3J0 LT5wb3J0ID09IFBPUlRfQSkgewo+ID4gIAkJaWYgKGluZGV4KQo+ID4gIAkJCXJldHVybiAwOwo+ ID4gQEAgLTczMyw3ICs3MTYsOSBAQCBzdGF0aWMgdWludDMyX3QgaHN3X2dldF9hdXhfY2xvY2tf ZGl2aWRlcihzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLCBpbnQgaW5kZXgpCj4gPiAgCQlkZWZh dWx0OiByZXR1cm4gMDsKPiA+ICAJCX0KPiA+ICAJfSBlbHNlICB7Cj4gPiAtCQlyZXR1cm4gaW5k ZXggPyAwIDogRElWX1JPVU5EX1VQKGludGVsX3BjaF9yYXdjbGsoZGV2KSwgMik7Cj4gPiArCQlp ZiAoaW5kZXgpCj4gPiArCQkJcmV0dXJuIDA7Cj4gPiArCQlyZXR1cm4gRElWX1JPVU5EX1VQKGlu dGVsX3BjaF9yYXdjbGsoZGV2KSwgMik7Cj4gPiAgCX0KPiA+ICB9Cj4gPiAgCj4gPiBAQCAtNTc0 Niw4ICs1NzMxLDYgQEAgaW50ZWxfZHBfaW5pdF9jb25uZWN0b3Ioc3RydWN0IGludGVsX2RpZ2l0 YWxfcG9ydCAqaW50ZWxfZGlnX3BvcnQsCj4gPiAgCQlpbnRlbF9kcC0+Z2V0X2F1eF9jbG9ja19k aXZpZGVyID0gc2tsX2dldF9hdXhfY2xvY2tfZGl2aWRlcjsKPiA+ICAJZWxzZSBpZiAoSVNfVkFM TEVZVklFVyhkZXYpKQo+ID4gIAkJaW50ZWxfZHAtPmdldF9hdXhfY2xvY2tfZGl2aWRlciA9IHZs dl9nZXRfYXV4X2Nsb2NrX2RpdmlkZXI7Cj4gPiAtCWVsc2UgaWYgKElTX0hBU1dFTEwoZGV2KSB8 fCBJU19CUk9BRFdFTEwoZGV2KSkKPiA+IC0JCWludGVsX2RwLT5nZXRfYXV4X2Nsb2NrX2Rpdmlk ZXIgPSBoc3dfZ2V0X2F1eF9jbG9ja19kaXZpZGVyOwo+ID4gIAllbHNlIGlmIChIQVNfUENIX1NQ TElUKGRldikpCj4gPiAgCQlpbnRlbF9kcC0+Z2V0X2F1eF9jbG9ja19kaXZpZGVyID0gaWxrX2dl dF9hdXhfY2xvY2tfZGl2aWRlcjsKPiA+ICAJZWxzZQo+ID4gLS0gCj4gPiAxLjkuMQo+ID4KPiA+ IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBJbnRl bC1nZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4g PiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 Cj4gCj4gLS0gCj4gSmFuaSBOaWt1bGEsIEludGVsIE9wZW4gU291cmNlIFRlY2hub2xvZ3kgQ2Vu dGVyCj4gX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBJ bnRlbC1nZnggbWFpbGluZyBsaXN0Cj4gSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+ IGh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK Ci0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg==