From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Minu Mathai <minu.mathai@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Correcting the reg definitions for PORT_DFT
Date: Fri, 5 Jun 2015 16:08:17 +0300 [thread overview]
Message-ID: <20150605130817.GX5176@intel.com> (raw)
In-Reply-To: <1433509224-9502-1-git-send-email-minu.mathai@intel.com>
On Fri, Jun 05, 2015 at 02:00:24PM +0100, Minu Mathai wrote:
> From: Minu <minu.mathai@intel.com>
>
> Display CRCs were not readable because the register defintions
> for PORT_DFT_I9XX and PORT_DFT2_G4X were wrong.
> MMIO offset needs to be added to these register offsets to fix them.
>
> Issue: GMINL-6869
> Signed-off-by: Minu Mathai <minu.mathai@intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 7213224..c327c7c 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -3193,7 +3193,7 @@ enum skl_disp_power_wells {
> #define PCH_HDMIC 0xe1150
> #define PCH_HDMID 0xe1160
>
> -#define PORT_DFT_I9XX 0x61150
> +#define PORT_DFT_I9XX (dev_priv->info.display_mmio_offset + 0x61150)
PORT_DFT_I9XX isn't used on VLV/CHV, so this doesn't change anything.
> #define DC_BALANCE_RESET (1 << 25)
> #define PORT_DFT2_G4X (dev_priv->info.display_mmio_offset + 0x61154)
> #define DC_BALANCE_RESET_VLV (1 << 31)
> --
> 1.9.1
>
> ---------------------------------------------------------------------
> Intel Corporation (UK) Limited
> Registered No. 1134945 (England)
> Registered Office: Pipers Way, Swindon SN3 1RJ
> VAT No: 860 2173 47
>
> This e-mail and any attachments may contain confidential material for
> the sole use of the intended recipient(s). Any review or distribution
> by others is strictly prohibited. If you are not the intended
> recipient, please contact the sender and delete all copies.
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-05 13:08 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 13:00 [PATCH] drm/i915: Correcting the reg definitions for PORT_DFT Minu Mathai
2015-06-05 13:08 ` Ville Syrjälä [this message]
2015-06-08 13:23 ` Mathai, Minu
2015-06-08 13:48 ` Jani Nikula
2015-06-09 12:06 ` Mathai, Minu
2015-06-09 12:16 ` Ville Syrjälä
2015-06-09 13:32 ` Mathai, Minu
2015-06-09 15:01 ` Dave Gordon
2015-06-09 15:24 ` Ville Syrjälä
2015-06-10 8:09 ` Jani Nikula
2015-06-10 12:27 ` Dave Gordon
2015-06-10 12:50 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150605130817.GX5176@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=minu.mathai@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox