From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matt Roper Subject: Re: [PATCH v2 06/10] drm: Avoid atomic commit path for CRTC property (Gamma) Date: Fri, 5 Jun 2015 18:01:02 -0700 Message-ID: <20150606010102.GI1099@intel.com> References: <1433425361-17864-1-git-send-email-Kausal.Malladi@intel.com> <1433425361-17864-7-git-send-email-Kausal.Malladi@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1433425361-17864-7-git-send-email-Kausal.Malladi@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Kausal Malladi Cc: annie.j.matheson@intel.com, dhanya.p.r@intel.com, dri-devel@lists.freedesktop.org, vijay.a.purushothaman@intel.com, jesse.barnes@intel.com, daniel.vetter@intel.com, intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVGh1LCBKdW4gMDQsIDIwMTUgYXQgMDc6MTI6MzdQTSArMDUzMCwgS2F1c2FsIE1hbGxhZGkg d3JvdGU6Cj4gRnJvbTogS2F1c2FsIE1hbGxhZGkgPEthdXNhbC5NYWxsYWRpQGludGVsLmNvbT4K PiAKPiBUaGUgYXRvbWljIENSVEMgc2V0IGluZnJhc3RydWN0dXJlIGlzIG5vdCBhdmFpbGFibGUg eWV0LiBTbywgdGhlIGF0b21pYwo+IGNoZWNrIHBhdGggdGhyb3dzIGVycm9yIGZvciBhbnkgbm9u LXBsYW5lIHByb3BlcnR5Lgo+IAo+IFRoaXMgcGF0Y2ggYWRkcyBhIGRpdmVyc2lvbiB0byBhdm9p ZCBjb21taXQgcGF0aCBmb3IgRFJNIGF0b21pYyBzZXQgR2FtbWEKPiBwcm9wZXJ0eSwgdW50aWwg YXRvbWljIENSVEMgaW5mcmFzdHJ1Y3R1cmUgaXMgcmVhZHkuCgpUaGlzIGRvZXNuJ3QgbG9vayBy aWdodCwgYnV0IEkgZG9uJ3QgcXVpdGUgdW5kZXJzdGFuZCB3aGF0IHlvdSdyZSB0cnlpbmcKdG8g ZG8gZnJvbSB0aGUgY29tbWl0IG1lc3NhZ2UuCgpUaGlzIGZ1bmN0aW9uIGlzIHdoYXQgd2lsbCBp bXBsZW1lbnQgbGVnYWN5IHNldF9wcm9wZXJ0eSBpb2N0bCdzIG9mIGEKQ1JUQyBvbiBhbiBhdG9t aWMtYmFzZWQgZHJpdmVyLiAgVGhlIGlkZWEgaXMgdGhhdCB3aGVuIHRoZSBpb2N0bCBpcwppc3N1 ZWQsIHdlIHNob3VsZCBnZXQgKGkuZS4sIG1ha2UgYSBkdXBsaWNhdGUgb2YpIHRoZSBjdXJyZW50 IENSVEMKc3RhdGUsIGNoYW5nZSBzb21lIG9mIHRoZSB2YWx1ZXMgaW4gdGhhdCBzdGF0ZSAod2hp Y2ggaXMgd2hhdCB0aGUKLmF0b21pY19zZXRfcHJvcGVydHkgZnVuY3Rpb24gdGFrZXMgY2FyZSBv ZiksIGFuZCB0aGVuIHN1Ym1pdCB0aGF0Cm1vZGlmaWVkIHN0YXRlIHRvIHRoZSBkcml2ZXIgZm9y IGNoZWNraW5nIGFuZCBody1wcm9ncmFtbWluZy4KCk9rYXksIEkganVzdCB0b29rIGEgcXVpY2sg cGVlayBhaGVhZCBpbiB5b3VyIHBhdGNoIHNldCBhbmQgSSB0aGluayBJCnVuZGVyc3RhbmQgdGhl IGNvbmZ1c2lvbiBub3cuLi5pdCBsb29rcyBsaWtlIHlvdSdyZSB0cnlpbmcgdG8gYWN0dWFsbHkK cGVyZm9ybSB0aGUgZnVsbCBoYXJkd2FyZSB1cGRhdGUgaW4gdGhlIC5hdG9taWNfc2V0X3Byb3Bl cnR5IGNhbGwgY2hhaW4sCndoaWNoIGlzbid0IHdoYXQgd2Ugd2FudCB0byBiZSBkb2luZyBpbiBh biBhdG9taWMgZHJpdmVyLgouYXRvbWljX3NldF9wcm9wZXJ0eSgpIGlzIGp1c3QgYSBtYXR0ZXIg b2YgdXBkYXRpbmcgdGhlIHN0YXRlIHN0cnVjdHVyZXMKdG8gcmVmbGVjdCB0aGUgY2hhbmdlcyB5 b3UgKndhbnQqIHRvIG1ha2UgKGJ1dCBub3QgYWN0dWFsbHkgcGVyZm9ybWluZwp0aG9zZSBjaGFu Z2VzIHJpZ2h0IGF3YXkpLiAgSXQgaXNuJ3QgdW50aWwgZHJtX2F0b21pY19jb21taXQoKSBnZXRz CmNhbGxlZCB0aGF0IHdlIHZhbGlkYXRlIHRoZSBuZXcgc3RhdGUgc3RydWN0dXJlIGFuZCB0aGVu IHdyaXRlIGl0IHRvIHRoZQpoYXJkd2FyZSBpZiBpdCBsb29rcyBva2F5LgoKS2VlcCBpbiBtaW5k IHRoYXQgdGhlIG92ZXJhbGwgZ29hbCBiZWhpbmQgYXRvbWljIGlzIHRoYXQgd2Ugd2FudCB0byBi ZQphYmxlIHRvIHN1cHBseSBzZXZlcmFsIGl0ZW1zIHRvIGJlIHVwZGF0ZWQgKGUuZy4sIG1vZGUs IENTQywgZ2FtbWEsCmV0Yy4pIHZpYSB0aGUgYXRvbWljIGlvY3RsIGFuZCB0aGVuIGhhdmUgdGhl bSBhbGwgYWNjZXB0ZWQgKGFuZApwcm9ncmFtbWVkKSBieSB0aGUgZHJpdmVyLCBvciBhbGwgcmVq ZWN0ZWQgKHNvIG5vbmUgZ2V0IHByb2dyYW1tZWQpIGlmCmFueSBvZiB0aGVtIGFyZSBpbnZhbGlk LiAgQWxzbywgaWYgdGhlIGNvbGxlY3Rpb24gb2YgcHJvcGVydGllcyB0aGF0CnlvdSdyZSB1cGRh dGluZyBmYWxsIHdpdGhpbiB0aGUgIm51Y2xlYXIgcGFnZWZsaXAiIHN1YnNldCBvZgpmdW5jdGlv bmFsaXR5LCB5b3UnbGwgYWxzbyBnZXQgYSBndWFyYW50ZWUgdGhhdCB0aG9zZSBpdGVtcyBhbGwg Z2V0CnVwZGF0ZWQgd2l0aGluIHRoZSBzYW1lIHZibGFuazsgdXBkYXRlcyB0aGF0IHN0cmFkZGxl IGEgdmJsYW5rIGNvdWxkCmNhdXNlIHVud2FudGVkIGZsaWNrZXJpbmcgb3Igb3RoZXIgYXJ0aWZh Y3RzLiAgVGhlIGhlbHBlciBmdW5jdGlvbgp5b3UncmUgdXBkYXRpbmcgaGVyZSBvbmx5IGhhcHBl bnMgdG8gdXBkYXRlIGEgc2luZ2xlIHN0YXRlIHZhbHVlIGF0IGEKdGltZSwgYnV0IHRoZSBzYW1l IC5hdG9taWNfc2V0X3Byb3BlcnR5KCkgaXMgYWxzbyB1c2VkIGJ5IHRoZSBhdG9taWMKaW9jdGws IHNvIHdlIG5lZWQgdG8gbWFrZSBzdXJlIGl0J3MgZm9sbG93aW5nIHRoZSBleHBlY3RlZCBkZXNp Z24uCgpGaW5hbGx5LCBrZWVwIGluIG1pbmQgdGhhdCB0aGUgZnVuY3Rpb24geW91J3JlIHVwZGF0 aW5nIGhlcmUgaXMgYSBEUk0KY29yZSBmdW5jdGlvbi4gIEV2ZW4gdGhvdWdoIGk5MTUgaXNuJ3Qg cXVpdGUgcmVhZHkgZm9yIGZ1bGwgYXRvbWljIHlldAphbmQgbWlnaHQgaGF2ZSBhIGJpdCBvZiBi cmFpbiBkYW1hZ2UgaW4gYXJlYXMsIG90aGVyIHZlbmRvcnMnIGRyaXZlcnMgZG8KaGF2ZSBjb21w bGV0ZSBhdG9taWMgbW9kZXNldHRpbmcgc3VwcG9ydCAoSSB0aGluaz8pLCBzbyBhZGRpbmcKaTkx NS1zcGVjaWZpYyB3b3JrYXJvdW5kcyBsaWtlIHRoaXMgdG8gdGhlIGNvcmUgZnVuY3Rpb24gY291 bGQgYWN0dWFsbHkKaGFtcGVyIHRoZW0uCgoKTWF0dAoKPiAKPiBTaWduZWQtb2ZmLWJ5OiBTaGFz aGFuayBTaGFybWEgPHNoYXNoYW5rLnNoYXJtYUBpbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTog S2F1c2FsIE1hbGxhZGkgPEthdXNhbC5NYWxsYWRpQGludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVy cy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgfCAxNyArKysrKysrKysrKysrKy0tLQo+ICAx IGZpbGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKPiAKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgYi9kcml2ZXJzL2dw dS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IGluZGV4IGE5MDA4NTguLjM3ZGJhNTUgMTAwNjQ0 Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IEBAIC0xNjk2LDYgKzE2OTYsOCBAQCBk cm1fYXRvbWljX2hlbHBlcl9jcnRjX3NldF9wcm9wZXJ0eShzdHJ1Y3QgZHJtX2NydGMgKmNydGMs Cj4gIHsKPiAgCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZTsKPiAgCXN0cnVjdCBkcm1f Y3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZTsKPiArCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjcnRj LT5kZXY7Cj4gKwlzdHJ1Y3QgZHJtX21vZGVfY29uZmlnICpjb25maWcgPSAmZGV2LT5tb2RlX2Nv bmZpZzsKPiAgCWludCByZXQgPSAwOwo+ICAKPiAgCXN0YXRlID0gZHJtX2F0b21pY19zdGF0ZV9h bGxvYyhjcnRjLT5kZXYpOwo+IEBAIC0xNzE2LDkgKzE3MTgsMTggQEAgcmV0cnk6Cj4gIAlpZiAo cmV0KQo+ICAJCWdvdG8gZmFpbDsKPiAgCj4gLQlyZXQgPSBkcm1fYXRvbWljX2NvbW1pdChzdGF0 ZSk7Cj4gLQlpZiAocmV0ICE9IDApCj4gLQkJZ290byBmYWlsOwo+ICsJLyoqCj4gKwkgKiBGSVhN RSA6IFRoaXMgaXMgYSBoYWNrLCB0byBhdm9pZCBhdG9taWMgY29tbWl0Cj4gKwkgKiBmb3IgQ1JU QywgYmVjYXVzZSBpOTE1IHN1cHBvcnRzIG9ubHkKPiArCSAqIGF0b21pYyBwbGFuZSBvcGVyYXRp b25zIGF0IHRoZSBtb21lbnQKPiArCSAqLwo+ICsJaWYgKHByb3BlcnR5ID09IGNvbmZpZy0+Z2Ft bWFfcHJvcGVydHkpCj4gKwkJcmV0ID0gMDsKPiArCWVsc2Ugewo+ICsJCXJldCA9IGRybV9hdG9t aWNfY29tbWl0KHN0YXRlKTsKPiArCQlpZiAocmV0ICE9IDApCj4gKwkJCWdvdG8gZmFpbDsKPiAr CX0KPiAgCj4gIAkvKiBEcml2ZXIgdGFrZXMgb3duZXJzaGlwIG9mIHN0YXRlIG9uIHN1Y2Nlc3Nm dWwgY29tbWl0LiAqLwo+ICAJcmV0dXJuIDA7Cj4gLS0gCj4gMi40LjIKPiAKCi0tIApNYXR0IFJv cGVyCkdyYXBoaWNzIFNvZnR3YXJlIEVuZ2luZWVyCklvVEcgUGxhdGZvcm0gRW5hYmxpbmcgJiBE ZXZlbG9wbWVudApJbnRlbCBDb3Jwb3JhdGlvbgooOTE2KSAzNTYtMjc5NQpfX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0 CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9w Lm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=