From: "O'Rourke, Tom" <Tom.O'Rourke@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@gmail.com>
Cc: "Goel, Akash" <akash.goel@intel.com>,
intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 1/5] drm/i915/skl: Retrieve the Rpe value from Pcode
Date: Wed, 10 Jun 2015 11:50:02 -0700 [thread overview]
Message-ID: <20150610185002.GA11348@torourke-desk1> (raw)
In-Reply-To: <CABVU7+uydu6Neka80tT20tuRw5K9e1ODLY9nG+KLGw6ULtsyqw@mail.gmail.com>
> > +
> > + dev_priv->rps.efficient_freq *=
> > + (IS_SKYLAKE(dev) ? GEN9_FREQ_SCALER : 1);
This line seems awkward. I suppose a good compiler could
optimize out the multiply by one.
I would prefer something like:
if(IS_SKYLAKE(dev))
dev_priv->rps.efficient_freq *= GEN9_FREQ_SCALER;
-- Tom O'Rourke
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-10 18:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-07 13:02 [PATCH 0/5] Ring frequency & Rpe changes for SKL akash.goel
2015-06-07 13:02 ` [PATCH 1/5] drm/i915/skl: Retrieve the Rpe value from Pcode akash.goel
2015-06-09 23:24 ` Rodrigo Vivi
2015-06-10 18:50 ` O'Rourke, Tom [this message]
2015-06-12 7:41 ` Jani Nikula
2015-06-12 9:31 ` [PATCH v2] " akash.goel
2015-06-12 10:32 ` Ville Syrjälä
2015-06-12 11:48 ` Akash Goel
2015-06-12 17:58 ` [PATCH v3] " akash.goel
2015-06-28 10:09 ` shuang.he
2015-06-28 13:25 ` [PATCH v2] " shuang.he
2015-06-07 13:02 ` [PATCH 2/5] drm/i915/skl: Ring frequency table programming changes akash.goel
2015-06-09 23:28 ` Rodrigo Vivi
2015-06-07 13:02 ` [PATCH 3/5] drm/i915/skl: Restrict the ring frequency table programming to SKL akash.goel
2015-06-09 23:30 ` Rodrigo Vivi
2015-06-07 13:02 ` [PATCH 4/5] drm/i915: Corrected the platform checks in i915_ring_freq_table function akash.goel
2015-06-09 23:32 ` Rodrigo Vivi
2015-06-15 13:15 ` Daniel Vetter
2015-06-15 13:53 ` Akash Goel
2015-06-07 13:02 ` [PATCH 5/5] drm/i915/skl: Updated the i915_ring_freq_table debugfs function akash.goel
2015-06-09 23:32 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150610185002.GA11348@torourke-desk1 \
--to=tom.o'rourke@intel.com \
--cc=akash.goel@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=rodrigo.vivi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox