Re: [PATCH 3/4] drm: Add decoding of i915 ioctls

From: "Dmitry V. Levin" <ldv@altlinux.org>
To: strace-devel@lists.sourceforge.net
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 3/4] drm: Add decoding of i915 ioctls
Date: Thu, 11 Jun 2015 02:27:12 +0300	[thread overview]
Message-ID: <20150610232711.GB19231@altlinux.org> (raw)
In-Reply-To: <20150610124524.GB18221@rpjakobs-ThinkCentre-E73>

[-- Attachment #1.1: Type: text/plain, Size: 886 bytes --]

On Wed, Jun 10, 2015 at 02:45:24PM +0200, Patrik Jakobsson wrote:
> On Wed, Jun 10, 2015 at 01:35:35AM +0300, Dmitry V. Levin wrote:
> > On Tue, Jun 09, 2015 at 01:26:43PM +0200, Patrik Jakobsson wrote:
[...]
> > > +static int i915_setparam(struct tcb *tcp, const unsigned int code, long arg)
> > > +{
> > > +	struct drm_i915_setparam param;
> > > +
> > > +	if (exiting(tcp) || umove(tcp, arg, &param))
> > > +		return 0;
> > 
> > In this and other ioctl printers that unconditionally return 0 on exit,
> > wouldn't the caller treat it as an ioctl that hasn't been printed?
> 
> Yes, seems like the exiting phase should return 1 if already handled in the
> entering phase. But changing it produces the same output for some reason. Not
> sure what's going on here.

Isn't tcp->u_arg[2] printed twice, the first time decoded,
and the second time in hex?

-- 
ldv

[-- Attachment #1.2: Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx