From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Dmitry V. Levin" <ldv@altlinux.org>
Subject: Re: [PATCH 3/4] drm: Add decoding of i915 ioctls
Date: Thu, 11 Jun 2015 02:27:12 +0300
Message-ID: <20150610232711.GB19231@altlinux.org>
References: <1433849204-4125-1-git-send-email-patrik.jakobsson@linux.intel.com>
 <1433849204-4125-4-git-send-email-patrik.jakobsson@linux.intel.com>
 <20150609223535.GB3210@altlinux.org>
 <20150610124524.GB18221@rpjakobs-ThinkCentre-E73>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0389861949=="
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from pegasus3.altlinux.org (pegasus3.altlinux.org [194.107.17.103])
 by gabe.freedesktop.org (Postfix) with ESMTP id CEA066E984
 for <intel-gfx@lists.freedesktop.org>; Wed, 10 Jun 2015 16:27:12 -0700 (PDT)
In-Reply-To: <20150610124524.GB18221@rpjakobs-ThinkCentre-E73>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: strace-devel@lists.sourceforge.net
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org


--===============0389861949==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="E39vaYmALEf/7YXx"
Content-Disposition: inline


--E39vaYmALEf/7YXx
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 10, 2015 at 02:45:24PM +0200, Patrik Jakobsson wrote:
> On Wed, Jun 10, 2015 at 01:35:35AM +0300, Dmitry V. Levin wrote:
> > On Tue, Jun 09, 2015 at 01:26:43PM +0200, Patrik Jakobsson wrote:
[...]
> > > +static int i915_setparam(struct tcb *tcp, const unsigned int code, l=
ong arg)
> > > +{
> > > +	struct drm_i915_setparam param;
> > > +
> > > +	if (exiting(tcp) || umove(tcp, arg, &param))
> > > +		return 0;
> >=20
> > In this and other ioctl printers that unconditionally return 0 on exit,
> > wouldn't the caller treat it as an ioctl that hasn't been printed?
>=20
> Yes, seems like the exiting phase should return 1 if already handled in t=
he
> entering phase. But changing it produces the same output for some reason.=
 Not
> sure what's going on here.

Isn't tcp->u_arg[2] printed twice, the first time decoded,
and the second time in hex?


--=20
ldv

--E39vaYmALEf/7YXx
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlV4x88ACgkQfKvmrJ41Nh5xhwCgoPgc3G/KgOy1BME4zia/AMNA
hEgAnjf3+nW1X4dMA80b47AOveXYfxAS
=I6EL
-----END PGP SIGNATURE-----

--E39vaYmALEf/7YXx--

--===============0389861949==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4
IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK

--===============0389861949==--