From mboxrd@z Thu Jan  1 00:00:00 1970
From: Matt Roper <matthew.d.roper@intel.com>
Subject: Re: [PATCH v2 12/27] drm/i915: Split plane updates of
 crtc->atomic into a helper, v2.
Date: Wed, 10 Jun 2015 18:35:05 -0700
Message-ID: <20150611013505.GF15024@intel.com>
References: <1433422077-14907-1-git-send-email-maarten.lankhorst@linux.intel.com>
 <1433422077-14907-13-git-send-email-maarten.lankhorst@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTP id 4FBA26E16A
 for <intel-gfx@lists.freedesktop.org>; Wed, 10 Jun 2015 18:35:06 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1433422077-14907-13-git-send-email-maarten.lankhorst@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gVGh1LCBKdW4gMDQsIDIwMTUgYXQgMDI6NDc6NDJQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y
c3Qgd3JvdGU6Cj4gVGhpcyBtYWtlcyBpdCBlYXNpZXIgdG8gdmVyaWZ5IHRoYXQgbm8gY2hhbmdl
cyBhcmUgZG9uZSB3aGVuCj4gY2FsbGluZyB0aGlzIGZyb20gY3J0YyBpbnN0ZWFkLgo+IAo+IENo
YW5nZXMgc2luY2UgdjE6Cj4gIC0gTWFrZSBpbnRlbF93bV9uZWVkX3VwZGF0ZSBzdGF0aWMgYW5k
IGFsd2F5cyBjaGVjayBpdC4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8
bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgoKRG8gd2UgZXZlbiBuZWVkIGNydGMt
PmF0b21pYyBhbnltb3JlPyAgV2hlbiBJIGZpcnN0IGFkZGVkIHRoYXQsIEkKZXhwZWN0ZWQgaXQg
dG8ganVzdCBiZSBhIHRlbXBvcmFyeSBkdW1waW5nIGdyb3VuZCB1bnRpbCB3ZSBoYWQKY3J0Y19z
dGF0ZSdzIHRyYWNrZWQgYW5kIHN3YXBwZWQgcHJvcGVybHkgKHdoaWNoIHdlIGRvIG5vdykuICBD
YW4gd2UKanVzdCBtaWdyYXRlIHRoZXNlIGZpZWxkcyBpbnRvIHRoZSBzdGF0ZSBzdHJ1Y3R1cmUg
aW5zdGVhZD8KCgo8c25pcD4KPiAraW50IGludGVsX3BsYW5lX2F0b21pY19jYWxjX2NoYW5nZXMo
c3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLAo+ICsJCQkJICAgIHN0cnVjdCBkcm1f
cGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlKQo+ICt7Cj4gKwlzdHJ1Y3QgZHJtX2NydGMgKmNydGMg
PSBjcnRjX3N0YXRlLT5jcnRjOwo+ICsJc3RydWN0IGludGVsX2NydGMgKmludGVsX2NydGMgPSB0
b19pbnRlbF9jcnRjKGNydGMpOwo+ICsJc3RydWN0IGRybV9wbGFuZSAqcGxhbmUgPSBwbGFuZV9z
dGF0ZS0+cGxhbmU7Cj4gKwlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gY3J0Yy0+ZGV2Owo+ICsJ
c3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2ID0gZGV2LT5kZXZfcHJpdmF0ZTsKPiAr
CXN0cnVjdCBpbnRlbF9wbGFuZV9zdGF0ZSAqb2xkX3BsYW5lX3N0YXRlID0KPiArCQl0b19pbnRl
bF9wbGFuZV9zdGF0ZShwbGFuZS0+c3RhdGUpOwo+ICsJaW50IGlkeCA9IGludGVsX2NydGMtPmJh
c2UuYmFzZS5pZCwgcmV0Owo+ICsJaW50IGkgPSBkcm1fcGxhbmVfaW5kZXgocGxhbmUpOwo+ICsJ
Ym9vbCBtb2RlX2NoYW5nZWQgPSBuZWVkc19tb2Rlc2V0KGNydGNfc3RhdGUpOwo+ICsJYm9vbCB3
YXNfY3J0Y19lbmFibGVkID0gY3J0Yy0+c3RhdGUtPmFjdGl2ZTsKPiArCWJvb2wgaXNfY3J0Y19l
bmFibGVkID0gY3J0Y19zdGF0ZS0+YWN0aXZlOwo+ICsKPiArCWJvb2wgdHVybl9vZmYsIHR1cm5f
b24sIHZpc2libGUsIHdhc192aXNpYmxlOwo+ICsJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIg
PSBwbGFuZV9zdGF0ZS0+ZmI7Cj4gKwo+ICsJaWYgKGNydGNfc3RhdGUgJiYgSU5URUxfSU5GTyhk
ZXYpLT5nZW4gPj0gOSAmJgo+ICsJICAgIHBsYW5lLT50eXBlICE9IERSTV9QTEFORV9UWVBFX0NV
UlNPUikgewo+ICsJCXJldCA9IHNrbF91cGRhdGVfc2NhbGVyX3BsYW5lKAo+ICsJCQl0b19pbnRl
bF9jcnRjX3N0YXRlKGNydGNfc3RhdGUpLAo+ICsJCQl0b19pbnRlbF9wbGFuZV9zdGF0ZShwbGFu
ZV9zdGF0ZSkpOwo+ICsJCWlmIChyZXQpCj4gKwkJCXJldHVybiByZXQ7Cj4gKwl9Cj4gKwo+ICsJ
LyoKPiArCSAqIERpc2FibGluZyBhIHBsYW5lIGlzIGFsd2F5cyBva2F5OyB3ZSBqdXN0IG5lZWQg
dG8gdXBkYXRlCj4gKwkgKiBmYiB0cmFja2luZyBpbiBhIHNwZWNpYWwgd2F5IHNpbmNlIGNsZWFu
dXBfZmIoKSB3b24ndAo+ICsJICogZ2V0IGNhbGxlZCBieSB0aGUgcGxhbmUgaGVscGVycy4KPiAr
CSAqLwo+ICsJaWYgKG9sZF9wbGFuZV9zdGF0ZS0+YmFzZS5mYiAmJiAhZmIpCj4gKwkJaW50ZWxf
Y3J0Yy0+YXRvbWljLmRpc2FibGVkX3BsYW5lcyB8PSAxIDw8IGk7Cj4gKwo+ICsJLyogZG9uJ3Qg
cnVuIHJlc3QgZHVyaW5nIG1vZGVzZXQgeWV0ICovCj4gKwlpZiAoIWludGVsX2NydGMtPmFjdGl2
ZSB8fCBtb2RlX2NoYW5nZWQpCj4gKwkJcmV0dXJuIDA7Cj4gKwo+ICsJd2FzX3Zpc2libGUgPSBv
bGRfcGxhbmVfc3RhdGUtPnZpc2libGU7Cj4gKwl2aXNpYmxlID0gdG9faW50ZWxfcGxhbmVfc3Rh
dGUocGxhbmVfc3RhdGUpLT52aXNpYmxlOwo+ICsKPiArCWlmICghd2FzX2NydGNfZW5hYmxlZCAm
JiBXQVJOX09OKHdhc192aXNpYmxlKSkKPiArCQl3YXNfdmlzaWJsZSA9IGZhbHNlOwo+ICsKPiAr
CWlmICghaXNfY3J0Y19lbmFibGVkICYmIFdBUk5fT04odmlzaWJsZSkpCj4gKwkJdmlzaWJsZSA9
IGZhbHNlOwo+ICsKPiArCWlmICghd2FzX3Zpc2libGUgJiYgIXZpc2libGUpCj4gKwkJcmV0dXJu
IDA7Cj4gKwo+ICsJdHVybl9vZmYgPSB3YXNfdmlzaWJsZSAmJiAoIXZpc2libGUgfHwgbW9kZV9j
aGFuZ2VkKTsKPiArCXR1cm5fb24gPSB2aXNpYmxlICYmICghd2FzX3Zpc2libGUgfHwgbW9kZV9j
aGFuZ2VkKTsKPiArCj4gKwlEUk1fREVCVUdfQVRPTUlDKCJbQ1JUQzolaV0gaGFzIFtQTEFORTol
aV0gd2l0aCBmYiAlaVxuIiwgaWR4LAo+ICsJCQkgcGxhbmUtPmJhc2UuaWQsIGZiID8gZmItPmJh
c2UuaWQgOiAtMSk7Cj4gKwo+ICsJRFJNX0RFQlVHX0FUT01JQygiW1BMQU5FOiVpXSB2aXNpYmxl
ICVpIC0+ICVpLCBvZmYgJWksIG9uICVpLCBtcyAlaVxuIiwKPiArCQkJIHBsYW5lLT5iYXNlLmlk
LCB3YXNfdmlzaWJsZSwgdmlzaWJsZSwKPiArCQkJIHR1cm5fb2ZmLCB0dXJuX29uLCBtb2RlX2No
YW5nZWQpOwo+ICsKPiArCWlmIChpbnRlbF93bV9uZWVkX3VwZGF0ZShwbGFuZSwgcGxhbmVfc3Rh
dGUpKQo+ICsJCWludGVsX2NydGMtPmF0b21pYy51cGRhdGVfd20gPSB0cnVlOwoKSG1tLCBJIHJl
YWxpemUgdGhpcyBpcyB0aGUgd2F5IHRoZSBjb2RlIGFscmVhZHkgd29ya2VkLCBidXQgdGhpcyBp
cyBvbmx5CmdvaW5nIHRvIHRyaWdnZXIgdXBkYXRlX3dhdGVybWFya3MgcmF0aGVyIHRoYW4gdXBk
YXRlX3Nwcml0ZV93YXRlcm1hcmtzLAp3aGljaCBvbiBzb21lIHBsYXRmb3JtcyBjb3VsZCBtYWtl
IHVzIHVwZGF0ZSB3YXRlcm1hcmtzIHdpdGggc3RhbGUKc3ByaXRlIHZhbHVlcy4gIEkgdGhpbmsg
dGhlIG9ubHkgcmVhc29uIHdlIGdldCBhd2F5IHdpdGggdGhpcyB0b2RheSBpcwpiZWNhdXNlIHdl
IGFjdHVhbGx5IHBlcmZvcm0gc3ByaXRlIHdhdGVybWFyayB1cGRhdGVzIGluIHRoZSBsb3ctbGV2
ZWwKcGxhbmUgdXBkYXRlIGZ1bmN0aW9ucyAod2hpY2ggaXMgYmFkIHNpbmNlIHdlJ3JlIHVuZGVy
IHZibGFuawpldmFzaW9uLi4uKS4gIEkgaGFkIHNvbWUgcGF0Y2hlcyB0aGF0IGZpeGVkIHRoYXQg
b3ZlcnNpZ2h0IGFzIHBhcnQgb2YgbXkKd2F0ZXJtYXJrIFJGQyBzZXJpZXMsIGJ1dCB0aGV5IGhh
dmVuJ3QgZ29uZSBpbjsgSSBwcm9iYWJseSBuZWVkIHRvCmV4dHJhY3QgdGhlIGZpeCBmcm9tIHRo
ZSByZXN0IG9mIHRoZSBSRkMuCgpOb3Qgc3VyZSBpZiB5b3Ugd2FudCB0byB3b3JyeSBhYm91dCBp
dCBhcyBwYXJ0IG9mIHlvdXIgd29yayBoZXJlIG9yIG5vdApzaW5jZSB0aGlzIGRvZXNuJ3QgbGVh
dmUgdXMgYW55IHdvcnNlIG9mZiB0aGFuIHdlIGFscmVhZHkgYXJlIHRvZGF5OwpqdXN0IGZpZ3Vy
ZWQgSSdkIG1lbnRpb24gaXQgc28gd2UgZG9uJ3QgZm9yZ2V0IGFib3V0IGl0LgoKCk1hdHQKCi0t
IApNYXR0IFJvcGVyCkdyYXBoaWNzIFNvZnR3YXJlIEVuZ2luZWVyCklvVEcgUGxhdGZvcm0gRW5h
YmxpbmcgJiBEZXZlbG9wbWVudApJbnRlbCBDb3Jwb3JhdGlvbgooOTE2KSAzNTYtMjc5NQpfX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFp
bGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZy
ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=