From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 1/4] drm/i915: Do not use atomic modesets in hw readout. Date: Fri, 12 Jun 2015 15:07:49 +0300 Message-ID: <20150612120749.GC5176@intel.com> References: <1434100542-15301-1-git-send-email-maarten.lankhorst@linux.intel.com> <1434100542-15301-2-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id E17EC6EA9C for ; Fri, 12 Jun 2015 05:08:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1434100542-15301-2-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKdW4gMTIsIDIwMTUgYXQgMTE6MTU6MzlBTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gVGhpcyBzaG91bGQgZml4IGZhbGxvdXQgY2F1c2VkIGJ5IG1ha2luZyBpbnRl bF9jcnRjX2NvbnRyb2wKPiBhbmQgdXBkYXRlX2RwbXMgYXRvbWljLCB3aGljaCBiZWNhbWUgYSBw cm9ibGVtIGFmdGVyIHJldmVydGluZyB0aGUKPiBhdG9taWMgaHcgcmVhZG91dCBwYXRjaC4KPiAK PiBCdWd6aWxsYTogaHR0cHM6Ly9idWdzLmZyZWVkZXNrdG9wLm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 OTA5MjkKPiBSZXBvcnRlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4 LmludGVsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBNYWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5s YW5raG9yc3RAbGludXguaW50ZWwuY29tPgoKU28gZmFyIG15IDgzMCBhbmQgZ2VuNCBzZWVtIGhh cHB5IHdpdGggdGhpcy4KClRlc3RlZC1ieTogVmlsbGUgU3lyasOkbMOkIDx2aWxsZS5zeXJqYWxh QGxpbnV4LmludGVsLmNvbT4KCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp c3BsYXkuYyB8IDc1ICsrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICAxIGZp bGUgY2hhbmdlZCwgMzIgaW5zZXJ0aW9ucygrKSwgNDMgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDVjYzIyNjNkYjE5OS4uN2FiYWZmZWRh N2NlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC02MTg3LDMx ICs2MTg3LDM1IEBAIHN0YXRpYyB2b2lkIGk5eHhfY3J0Y19kaXNhYmxlKHN0cnVjdCBkcm1fY3J0 YyAqY3J0YykKPiAgCW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICB9Cj4gIAo+ ICtzdGF0aWMgdm9pZCBpbnRlbF9jcnRjX2Rpc2FibGVfbm9hdG9taWMoc3RydWN0IGRybV9jcnRj ICpjcnRjKQo+ICt7Cj4gKwlzdHJ1Y3QgaW50ZWxfY3J0YyAqaW50ZWxfY3J0YyA9IHRvX2ludGVs X2NydGMoY3J0Yyk7Cj4gKwlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19p OTE1KGNydGMtPmRldik7Cj4gKwllbnVtIGludGVsX2Rpc3BsYXlfcG93ZXJfZG9tYWluIGRvbWFp bjsKPiArCXVuc2lnbmVkIGxvbmcgZG9tYWluczsKPiArCj4gKwlpZiAoIWludGVsX2NydGMtPmFj dGl2ZSkKPiArCQlyZXR1cm47Cj4gKwo+ICsJaW50ZWxfY3J0Y19kaXNhYmxlX3BsYW5lcyhjcnRj KTsKPiArCWRldl9wcml2LT5kaXNwbGF5LmNydGNfZGlzYWJsZShjcnRjKTsKPiArCj4gKwlkb21h aW5zID0gaW50ZWxfY3J0Yy0+ZW5hYmxlZF9wb3dlcl9kb21haW5zOwo+ICsJZm9yX2VhY2hfcG93 ZXJfZG9tYWluKGRvbWFpbiwgZG9tYWlucykKPiArCQlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChk ZXZfcHJpdiwgZG9tYWluKTsKPiArCWludGVsX2NydGMtPmVuYWJsZWRfcG93ZXJfZG9tYWlucyA9 IDA7Cj4gK30KPiArCj4gIC8qCj4gICAqIHR1cm4gYWxsIGNydGMncyBvZmYsIGJ1dCBkbyBub3Qg YWRqdXN0IHN0YXRlCj4gICAqIFRoaXMgaGFzIHRvIGJlIHBhaXJlZCB3aXRoIGEgY2FsbCB0byBp bnRlbF9tb2Rlc2V0X3NldHVwX2h3X3N0YXRlLgo+ICAgKi8KPiAgdm9pZCBpbnRlbF9kaXNwbGF5 X3N1c3BlbmQoc3RydWN0IGRybV9kZXZpY2UgKmRldikKPiAgewo+IC0Jc3RydWN0IGRybV9pOTE1 X3ByaXZhdGUgKmRldl9wcml2ID0gdG9faTkxNShkZXYpOwo+ICAJc3RydWN0IGRybV9jcnRjICpj cnRjOwo+ICAKPiAtCWZvcl9lYWNoX2NydGMoZGV2LCBjcnRjKSB7Cj4gLQkJc3RydWN0IGludGVs X2NydGMgKmludGVsX2NydGMgPSB0b19pbnRlbF9jcnRjKGNydGMpOwo+IC0JCWVudW0gaW50ZWxf ZGlzcGxheV9wb3dlcl9kb21haW4gZG9tYWluOwo+IC0JCXVuc2lnbmVkIGxvbmcgZG9tYWluczsK PiAtCj4gLQkJaWYgKCFpbnRlbF9jcnRjLT5hY3RpdmUpCj4gLQkJCWNvbnRpbnVlOwo+IC0KPiAt CQlpbnRlbF9jcnRjX2Rpc2FibGVfcGxhbmVzKGNydGMpOwo+IC0JCWRldl9wcml2LT5kaXNwbGF5 LmNydGNfZGlzYWJsZShjcnRjKTsKPiAtCj4gLQkJZG9tYWlucyA9IGludGVsX2NydGMtPmVuYWJs ZWRfcG93ZXJfZG9tYWluczsKPiAtCQlmb3JfZWFjaF9wb3dlcl9kb21haW4oZG9tYWluLCBkb21h aW5zKQo+IC0JCQlpbnRlbF9kaXNwbGF5X3Bvd2VyX3B1dChkZXZfcHJpdiwgZG9tYWluKTsKPiAt CQlpbnRlbF9jcnRjLT5lbmFibGVkX3Bvd2VyX2RvbWFpbnMgPSAwOwo+IC0JfQo+ICsJZm9yX2Vh Y2hfY3J0YyhkZXYsIGNydGMpCj4gKwkJaW50ZWxfY3J0Y19kaXNhYmxlX25vYXRvbWljKGNydGMp Owo+ICB9Cj4gIAo+ICAvKiBNYXN0ZXIgZnVuY3Rpb24gdG8gZW5hYmxlL2Rpc2FibGUgQ1JUQyBh bmQgY29ycmVzcG9uZGluZyBwb3dlciB3ZWxscyAqLwo+IEBAIC0xNTEyMCw3ICsxNTEyNCw5IEBA IHN0YXRpYyB2b2lkIGludGVsX3Nhbml0aXplX2NydGMoc3RydWN0IGludGVsX2NydGMgKmNydGMp Cj4gIHsKPiAgCXN0cnVjdCBkcm1fZGV2aWNlICpkZXYgPSBjcnRjLT5iYXNlLmRldjsKPiAgCXN0 cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gKwlz dHJ1Y3QgaW50ZWxfZW5jb2RlciAqZW5jb2RlcjsKPiAgCXUzMiByZWc7Cj4gKwlib29sIGVuYWJs ZTsKPiAgCj4gIAkvKiBDbGVhciBhbnkgZnJhbWUgc3RhcnQgZGVsYXlzIHVzZWQgZm9yIGRlYnVn Z2luZyBsZWZ0IGJ5IHRoZSBCSU9TICovCj4gIAlyZWcgPSBQSVBFQ09ORihjcnRjLT5jb25maWct PmNwdV90cmFuc2NvZGVyKTsKPiBAQCAtMTUxMzcsNyArMTUxNDMsNiBAQCBzdGF0aWMgdm9pZCBp bnRlbF9zYW5pdGl6ZV9jcnRjKHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ICAJICogZGlzYWJs ZSB0aGUgY3J0YyAoYW5kIGhlbmNlIGNoYW5nZSB0aGUgc3RhdGUpIGlmIGl0IGlzIHdyb25nLiBO b3RlCj4gIAkgKiB0aGF0IGdlbjQrIGhhcyBhIGZpeGVkIHBsYW5lIC0+IHBpcGUgbWFwcGluZy4g ICovCj4gIAlpZiAoSU5URUxfSU5GTyhkZXYpLT5nZW4gPCA0ICYmICFpbnRlbF9jaGVja19wbGFu ZV9tYXBwaW5nKGNydGMpKSB7Cj4gLQkJc3RydWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9y Owo+ICAJCWJvb2wgcGxhbmU7Cj4gIAo+ICAJCURSTV9ERUJVR19LTVMoIltDUlRDOiVkXSB3cm9u ZyBwbGFuZSBjb25uZWN0aW9uIGRldGVjdGVkIVxuIiwKPiBAQCAtMTUxNDksMjkgKzE1MTU0LDgg QEAgc3RhdGljIHZvaWQgaW50ZWxfc2FuaXRpemVfY3J0YyhzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0 YykKPiAgCQlwbGFuZSA9IGNydGMtPnBsYW5lOwo+ICAJCXRvX2ludGVsX3BsYW5lX3N0YXRlKGNy dGMtPmJhc2UucHJpbWFyeS0+c3RhdGUpLT52aXNpYmxlID0gdHJ1ZTsKPiAgCQljcnRjLT5wbGFu ZSA9ICFwbGFuZTsKPiAtCQlpbnRlbF9jcnRjX2NvbnRyb2woJmNydGMtPmJhc2UsIGZhbHNlKTsK PiArCQlpbnRlbF9jcnRjX2Rpc2FibGVfbm9hdG9taWMoJmNydGMtPmJhc2UpOwo+ICAJCWNydGMt PnBsYW5lID0gcGxhbmU7Cj4gLQo+IC0JCS8qIC4uLiBhbmQgYnJlYWsgYWxsIGxpbmtzLiAqLwo+ IC0JCWZvcl9lYWNoX2ludGVsX2Nvbm5lY3RvcihkZXYsIGNvbm5lY3Rvcikgewo+IC0JCQlpZiAo Y29ubmVjdG9yLT5lbmNvZGVyLT5iYXNlLmNydGMgIT0gJmNydGMtPmJhc2UpCj4gLQkJCQljb250 aW51ZTsKPiAtCj4gLQkJCWNvbm5lY3Rvci0+YmFzZS5kcG1zID0gRFJNX01PREVfRFBNU19PRkY7 Cj4gLQkJCWNvbm5lY3Rvci0+YmFzZS5lbmNvZGVyID0gTlVMTDsKPiAtCQl9Cj4gLQkJLyogbXVs dGlwbGUgY29ubmVjdG9ycyBtYXkgaGF2ZSB0aGUgc2FtZSBlbmNvZGVyOgo+IC0JCSAqICBoYW5k bGUgdGhlbSBhbmQgYnJlYWsgY3J0YyBsaW5rIHNlcGFyYXRlbHkgKi8KPiAtCQlmb3JfZWFjaF9p bnRlbF9jb25uZWN0b3IoZGV2LCBjb25uZWN0b3IpCj4gLQkJCWlmIChjb25uZWN0b3ItPmVuY29k ZXItPmJhc2UuY3J0YyA9PSAmY3J0Yy0+YmFzZSkgewo+IC0JCQkJY29ubmVjdG9yLT5lbmNvZGVy LT5iYXNlLmNydGMgPSBOVUxMOwo+IC0JCQkJY29ubmVjdG9yLT5lbmNvZGVyLT5jb25uZWN0b3Jz X2FjdGl2ZSA9IGZhbHNlOwo+IC0JCQl9Cj4gLQo+IC0JCVdBUk5fT04oY3J0Yy0+YWN0aXZlKTsK PiAtCQljcnRjLT5iYXNlLnN0YXRlLT5lbmFibGUgPSBmYWxzZTsKPiAtCQljcnRjLT5iYXNlLnN0 YXRlLT5hY3RpdmUgPSBmYWxzZTsKPiAtCQljcnRjLT5iYXNlLmVuYWJsZWQgPSBmYWxzZTsKPiAg CX0KPiAgCj4gIAlpZiAoZGV2X3ByaXYtPnF1aXJrcyAmIFFVSVJLX1BJUEVBX0ZPUkNFICYmCj4g QEAgLTE1MTg1LDEzICsxNTE2OSwxOCBAQCBzdGF0aWMgdm9pZCBpbnRlbF9zYW5pdGl6ZV9jcnRj KHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjKQo+ICAKPiAgCS8qIEFkanVzdCB0aGUgc3RhdGUgb2Yg dGhlIG91dHB1dCBwaXBlIGFjY29yZGluZyB0byB3aGV0aGVyIHdlCj4gIAkgKiBoYXZlIGFjdGl2 ZSBjb25uZWN0b3JzL2VuY29kZXJzLiAqLwo+IC0JaW50ZWxfY3J0Y191cGRhdGVfZHBtcygmY3J0 Yy0+YmFzZSk7Cj4gKwllbmFibGUgPSBmYWxzZTsKPiArCWZvcl9lYWNoX2VuY29kZXJfb25fY3J0 YyhkZXYsICZjcnRjLT5iYXNlLCBlbmNvZGVyKQo+ICsJCWVuYWJsZSB8PSBlbmNvZGVyLT5jb25u ZWN0b3JzX2FjdGl2ZTsKPiArCj4gKwlpZiAoIWVuYWJsZSkKPiArCQlpbnRlbF9jcnRjX2Rpc2Fi bGVfbm9hdG9taWMoJmNydGMtPmJhc2UpOwo+ICAKPiAgCWlmIChjcnRjLT5hY3RpdmUgIT0gY3J0 Yy0+YmFzZS5zdGF0ZS0+YWN0aXZlKSB7Cj4gLQkJc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29k ZXI7Cj4gIAo+ICAJCS8qIFRoaXMgY2FuIGhhcHBlbiBlaXRoZXIgZHVlIHRvIGJ1Z3MgaW4gdGhl IGdldF9od19zdGF0ZQo+IC0JCSAqIGZ1bmN0aW9ucyBvciBiZWNhdXNlIHRoZSBwaXBlIGlzIGZv cmNlLWVuYWJsZWQgZHVlIHRvIHRoZQo+ICsJCSAqIGZ1bmN0aW9ucyBvciBiZWNhdXNlIG9mIGNh bGxzIHRvIGludGVsX2NydGNfZGlzYWJsZV9ub2F0b21pYywKPiArCQkgKiBvciBiZWNhdXNlIHRo ZSBwaXBlIGlzIGZvcmNlLWVuYWJsZWQgZHVlIHRvIHRoZQo+ICAJCSAqIHBpcGUgQSBxdWlyay4g Ki8KPiAgCQlEUk1fREVCVUdfS01TKCJbQ1JUQzolZF0gaHcgc3RhdGUgYWRqdXN0ZWQsIHdhcyAl cywgbm93ICVzXG4iLAo+ICAJCQkgICAgICBjcnRjLT5iYXNlLmJhc2UuaWQsCj4gLS0gCj4gMi4x LjAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwo+ IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm eAoKLS0gClZpbGxlIFN5cmrDpGzDpApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhA bGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1h bi9saXN0aW5mby9pbnRlbC1nZngK