From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2] drm/atomic: Handle vblank events in atomic ioctl correctly. Date: Mon, 15 Jun 2015 08:22:46 +0200 Message-ID: <20150615062246.GA8341@phenom.ffwll.local> References: <1433182358-15463-1-git-send-email-maarten.lankhorst@linux.intel.com> <556D549E.1010109@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f174.google.com (mail-wi0-f174.google.com [209.85.212.174]) by gabe.freedesktop.org (Postfix) with ESMTP id A09FD6E1A7 for ; Sun, 14 Jun 2015 23:20:02 -0700 (PDT) Received: by wibdq8 with SMTP id dq8so66471506wib.1 for ; Sun, 14 Jun 2015 23:20:01 -0700 (PDT) Content-Disposition: inline In-Reply-To: <556D549E.1010109@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx , dri-devel List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKdW4gMDIsIDIwMTUgYXQgMDk6MDA6NDZBTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gQWxsIHVzZXJzIG9mIGFzeW5jIHVwZGF0ZXMgc2VlbSB0byBjbGVhciBjbGVh ciBjcnRjX3N0YXRlLT5ldmVudAo+IGNvcnJlY3RseSwgc28gbW92ZSBkZXN0cm95aW5nIHZibGFu ayBldmVudCB0byBjcnRjX2Rlc3Ryb3lfc3RhdGUuCj4gCj4gVGhpcyBpcyBiZXR0ZXIgdGhhbiBt YW51YWxseSBmcmVlJ2luZyBpdCBpbiB0aGUgYXRvbWljIGlvY3RsLCBzaW5jZQo+IHRoaXMgY29k ZSBzZWVtcyB0byBkbyBpdCB3cm9uZy4KPiAKPiBXaGlsZSB3ZSdyZSBhdCBpdCBoYW5kbGUgLUVE RUFETEsgZnJvbSBhdG9taWNfY29tbWl0IGNvcnJlY3RseSwKPiBiZWNhdXNlIHRoZSBjaGVjayBt aWdodCBmYWlsIG90aGVyd2lzZSBpZiBpdCB0YWtlcyBhZGRpdGlvbmFsIHN0YXRlLgoKUGxlYXNl IGRvbid0IHNtYXNoIHVucmVsYXRlZCBmaXhlcyB0b2dldGhlciBpbnRvIHRoZSBzYW1lIHBhdGNo LgoKPiBDaGFuZ2VzIHNpbmNlIHYxOgo+IC0gRml4IGZyZWVpbmcgYSBOVUxMIGZyYW1lYnVmZmVy LCB0aGFua3MgZm9yIGNhdGNoaW5nIERhbmllbCBTdG9uZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBN YWFydGVuIExhbmtob3JzdCA8bWFhcnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IFJl dmlld2VkLWJ5OiBEYW5pZWwgU3RvbmUgPGRhbmllbHNAY29sbGFib3JhLmNvbT4KPiAtLS0KPiAg ZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYyAgICAgICAgfCA0NSArKysrKysrKystLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBl ci5jIHwgMTUgKysrKysrKysrKysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDI2IGluc2VydGlvbnMo KyksIDM0IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJt X2F0b21pYy5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWMuYwo+IGluZGV4IGM3ZTU5YjA3 NGU2Mi4uOGFkZDBkZDhkYzVkIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRv bWljLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pYy5jCj4gQEAgLTEzMjgsMTcg KzEzMjgsNiBAQCBvdXQ6Cj4gIAlyZXR1cm4gZTsKPiAgfQo+ICAKPiAtc3RhdGljIHZvaWQgZGVz dHJveV92YmxhbmtfZXZlbnQoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAtCQlzdHJ1Y3QgZHJt X2ZpbGUgKmZpbGVfcHJpdiwgc3RydWN0IGRybV9wZW5kaW5nX3ZibGFua19ldmVudCAqZSkKPiAt ewo+IC0JdW5zaWduZWQgbG9uZyBmbGFnczsKPiAtCj4gLQlzcGluX2xvY2tfaXJxc2F2ZSgmZGV2 LT5ldmVudF9sb2NrLCBmbGFncyk7Cj4gLQlmaWxlX3ByaXYtPmV2ZW50X3NwYWNlICs9IHNpemVv ZiBlLT5ldmVudDsKPiAtCXNwaW5fdW5sb2NrX2lycXJlc3RvcmUoJmRldi0+ZXZlbnRfbG9jaywg ZmxhZ3MpOwo+IC0Ja2ZyZWUoZSk7Cj4gLX0KPiAtCj4gIHN0YXRpYyBpbnQgYXRvbWljX3NldF9w cm9wKHN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZSwKPiAgCQlzdHJ1Y3QgZHJtX21vZGVf b2JqZWN0ICpvYmosIHN0cnVjdCBkcm1fcHJvcGVydHkgKnByb3AsCj4gIAkJdWludDY0X3QgcHJv cF92YWx1ZSkKPiBAQCAtMTUzNCwxMyArMTUyMywxOCBAQCByZXRyeToKPiAgCWlmIChhcmctPmZs YWdzICYgRFJNX01PREVfQVRPTUlDX1RFU1RfT05MWSkgewo+ICAJCXJldCA9IGRybV9hdG9taWNf Y2hlY2tfb25seShzdGF0ZSk7Cj4gIAkJLyogX2NoZWNrX29ubHkoKSBkb2VzIG5vdCBmcmVlIHN0 YXRlLCB1bmxpa2UgX2NvbW1pdCgpICovCj4gLQkJZHJtX2F0b21pY19zdGF0ZV9mcmVlKHN0YXRl KTsKPiArCQlpZiAoIXJldCkKPiArCQkJZHJtX2F0b21pY19zdGF0ZV9mcmVlKHN0YXRlKTsKPiAg CX0gZWxzZSBpZiAoYXJnLT5mbGFncyAmIERSTV9NT0RFX0FUT01JQ19OT05CTE9DSykgewo+ICAJ CXJldCA9IGRybV9hdG9taWNfYXN5bmNfY29tbWl0KHN0YXRlKTsKPiAgCX0gZWxzZSB7Cj4gIAkJ cmV0ID0gZHJtX2F0b21pY19jb21taXQoc3RhdGUpOwo+ICAJfQo+ICAKPiArZmFpbDoKPiArCWlm IChyZXQgPT0gLUVERUFETEspCj4gKwkJZ290byBiYWNrb2ZmOwo+ICsKPiAgCS8qIGlmIHN1Y2Nl ZWRlZCwgZml4dXAgbGVnYWN5IHBsYW5lIGNydGMvZmIgcHRycyBiZWZvcmUgZHJvcHBpbmcKPiAg CSAqIGxvY2tzIChpZS4gd2hpbGUgaXQgaXMgc3RpbGwgc2FmZSB0byBkZXJlZiBwbGFuZS0+c3Rh dGUpLiAgV2UKPiAgCSAqIG5lZWQgdG8gZG8gdGhpcyBoZXJlIGJlY2F1c2UgdGhlIGRyaXZlciBl bnRyeSBwb2ludHMgY2Fubm90Cj4gQEAgLTE1NTMsMzIgKzE1NDcsMTUgQEAgcmV0cnk6Cj4gIAkJ CQlkcm1fZnJhbWVidWZmZXJfcmVmZXJlbmNlKG5ld19mYik7Cj4gIAkJCXBsYW5lLT5mYiA9IG5l d19mYjsKPiAgCQkJcGxhbmUtPmNydGMgPSBwbGFuZS0+c3RhdGUtPmNydGM7Cj4gLQkJfSBlbHNl IHsKPiAtCQkJcGxhbmUtPm9sZF9mYiA9IE5VTEw7Cj4gLQkJfQo+IC0JCWlmIChwbGFuZS0+b2xk X2ZiKSB7Cj4gLQkJCWRybV9mcmFtZWJ1ZmZlcl91bnJlZmVyZW5jZShwbGFuZS0+b2xkX2ZiKTsK PiAtCQkJcGxhbmUtPm9sZF9mYiA9IE5VTEw7Cj4gLQkJfQo+IC0JfQo+IC0KPiAtCWRybV9tb2Rl c2V0X2Ryb3BfbG9ja3MoJmN0eCk7Cj4gLQlkcm1fbW9kZXNldF9hY3F1aXJlX2ZpbmkoJmN0eCk7 Cj4gLQo+IC0JcmV0dXJuIHJldDsKPiAtCj4gLWZhaWw6Cj4gLQlpZiAocmV0ID09IC1FREVBRExL KQo+IC0JCWdvdG8gYmFja29mZjsKCldlIGhhdmUgYSBwcmUtZXhpc3RpbmcgYnVnIGhlcmUgYWxy ZWFkeSBvZiBsZWFraW5nIHBsYW5lLT5vbGRfZmIgYmVmb3JlCmRyb3BwaW5nIGxvY2tzLiBJIHRo aW5rIHRoZSBFREVBRExLIGNhc2UgbmVlZHMgdG8gYmUgYWZ0ZXIgdGhlIGNsZWFudXAKbG9vcCB0 byBjbGVhciBvbGRfZmIuCi1EYW5pZWwKCj4gIAo+IC0JaWYgKGFyZy0+ZmxhZ3MgJiBEUk1fTU9E RV9QQUdFX0ZMSVBfRVZFTlQpIHsKPiAtCQlmb3JfZWFjaF9jcnRjX2luX3N0YXRlKHN0YXRlLCBj cnRjLCBjcnRjX3N0YXRlLCBpKSB7Cj4gLQkJCWRlc3Ryb3lfdmJsYW5rX2V2ZW50KGRldiwgZmls ZV9wcml2LCBjcnRjX3N0YXRlLT5ldmVudCk7Cj4gLQkJCWNydGNfc3RhdGUtPmV2ZW50ID0gTlVM TDsKPiArCQkJaWYgKHBsYW5lLT5vbGRfZmIpCj4gKwkJCQlkcm1fZnJhbWVidWZmZXJfdW5yZWZl cmVuY2UocGxhbmUtPm9sZF9mYik7Cj4gIAkJfQo+ICsJCXBsYW5lLT5vbGRfZmIgPSBOVUxMOwo+ ICAJfQo+ICAKPiAtCWRybV9hdG9taWNfc3RhdGVfZnJlZShzdGF0ZSk7Cj4gKwlpZiAocmV0KQo+ ICsJCWRybV9hdG9taWNfc3RhdGVfZnJlZShzdGF0ZSk7Cj4gIAo+ICAJZHJtX21vZGVzZXRfZHJv cF9sb2NrcygmY3R4KTsKPiAgCWRybV9tb2Rlc2V0X2FjcXVpcmVfZmluaSgmY3R4KTsKPiBkaWZm IC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgYi9kcml2ZXJzL2dw dS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+IGluZGV4IDUzNmFlNGRhNDY2NS4uMGJiNzBjNGRh NzdhIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4g KysrIGIvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiBAQCAtMjEwMSw2ICsy MTAxLDE4IEBAIGRybV9hdG9taWNfaGVscGVyX2NydGNfZHVwbGljYXRlX3N0YXRlKHN0cnVjdCBk cm1fY3J0YyAqY3J0YykKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKGRybV9hdG9taWNfaGVscGVyX2Ny dGNfZHVwbGljYXRlX3N0YXRlKTsKPiAgCj4gK3N0YXRpYyB2b2lkIGRlc3Ryb3lfdmJsYW5rX2V2 ZW50KHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gKwkJc3RydWN0IGRybV9wZW5kaW5nX3ZibGFu a19ldmVudCAqZSkKPiArewo+ICsJc3RydWN0IGRybV9maWxlICpmaWxlX3ByaXYgPSBlLT5iYXNl LmZpbGVfcHJpdjsKPiArCXVuc2lnbmVkIGxvbmcgZmxhZ3M7Cj4gKwo+ICsJc3Bpbl9sb2NrX2ly cXNhdmUoJmRldi0+ZXZlbnRfbG9jaywgZmxhZ3MpOwo+ICsJZmlsZV9wcml2LT5ldmVudF9zcGFj ZSArPSBzaXplb2YgZS0+ZXZlbnQ7Cj4gKwlzcGluX3VubG9ja19pcnFyZXN0b3JlKCZkZXYtPmV2 ZW50X2xvY2ssIGZsYWdzKTsKPiArCWtmcmVlKGUpOwo+ICt9Cj4gKwo+ICAvKioKPiAgICogX19k cm1fYXRvbWljX2hlbHBlcl9jcnRjX2Rlc3Ryb3lfc3RhdGUgLSByZWxlYXNlIENSVEMgc3RhdGUK PiAgICogQGNydGM6IENSVEMgb2JqZWN0Cj4gQEAgLTIxMTUsNiArMjEyNyw5IEBAIHZvaWQgX19k cm1fYXRvbWljX2hlbHBlcl9jcnRjX2Rlc3Ryb3lfc3RhdGUoc3RydWN0IGRybV9jcnRjICpjcnRj LAo+ICB7Cj4gIAlpZiAoc3RhdGUtPm1vZGVfYmxvYikKPiAgCQlkcm1fcHJvcGVydHlfdW5yZWZl cmVuY2VfYmxvYihzdGF0ZS0+bW9kZV9ibG9iKTsKPiArCj4gKwlpZiAoc3RhdGUtPmV2ZW50KQo+ ICsJCWRlc3Ryb3lfdmJsYW5rX2V2ZW50KGNydGMtPmRldiwgc3RhdGUtPmV2ZW50KTsKPiAgfQo+ ICBFWFBPUlRfU1lNQk9MKF9fZHJtX2F0b21pY19oZWxwZXJfY3J0Y19kZXN0cm95X3N0YXRlKTsK PiAgCj4gLS0gCj4gMi4xLjAKPiAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fXwo+IEludGVsLWdmeCBtYWlsaW5nIGxpc3QKPiBJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCj4gaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIs IEludGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3Jn L21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==