From: Daniel Vetter <daniel@ffwll.ch>
To: Damien Lespiau <damien.lespiau@intel.com>
Cc: "Shah, Suketu J" <suketu.j.shah@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: Re: DC6 already programmed to be disabled
Date: Mon, 15 Jun 2015 11:55:12 +0200 [thread overview]
Message-ID: <20150615095512.GL8341@phenom.ffwll.local> (raw)
In-Reply-To: <20150604094142.GA19161@strange.ger.corp.intel.com>
On Thu, Jun 04, 2015 at 10:41:42AM +0100, Damien Lespiau wrote:
> On Thu, Jun 04, 2015 at 01:39:50PM +0530, Sagar Arun Kamble wrote:
> > The warning faced by Chandra has to corrected. This warning is not
> > related to firmware load.
> >
> > Issue is -> During boot DC5/6 will be already disabled and hence While
> > enabling PW2 for the first time the check to see if DC5/6 is already
> > disabled does not make sense.
> >
> > So condition should be
> >
> > WARN(!(I915_READ(DC_STATE_EN) & DC_STATE_EN_UPTO_DC6) && pg2_enabled),
> > "DC6 already programmed to be disabled.\n");
>
> Hi,
>
> we may talk about different problems here. The warn in question here is
> when the DMC firmware isn't loaded (because, for instance, it's not on
> the filesystem)
Also the initial power domains tricks should result in us not trying to
double-disable stuff on driver load. It works under the assumption that
the bios hasn't enabled any power conservation tricks. If that assumption
ever proves wrong then we need to replace the hard-coded list of initial
power domains with a dynamically generated one. Unfortuantely that also
means fixing up our init code to properly take power domain references, so
quite a bit of work.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-06-15 9:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 23:22 DC6 already programmed to be disabled Konduru, Chandra
2015-05-18 8:38 ` Daniel Vetter
2015-05-18 10:44 ` Damien Lespiau
2015-05-19 4:53 ` Kamath, Sunil
2015-05-19 8:18 ` Daniel Vetter
2015-06-04 8:09 ` Sagar Arun Kamble
2015-06-04 9:41 ` Damien Lespiau
2015-06-15 9:55 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615095512.GL8341@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=suketu.j.shah@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox