From: Daniel Vetter <daniel@ffwll.ch>
To: Thomas Richter <thor@math.tu-berlin.de>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] Fix resume from suspend to RAM on IBM X30 (take two)
Date: Mon, 15 Jun 2015 12:21:49 +0200 [thread overview]
Message-ID: <20150615102149.GS8341@phenom.ffwll.local> (raw)
In-Reply-To: <556C16E6.2040309@math.tu-berlin.de>
On Mon, Jun 01, 2015 at 10:25:10AM +0200, Thomas Richter wrote:
> Hi Daniel, hi Ville,
>
> as suggested, I again checked against the latest drm-intel-nightly
> branch and indeed, the patch as originally submitted does not apply
> there. So I recompiled the patch again (see attachment) which works now
> correctly with the latest branch.
>
> As suggested, I made a couple of additional changes:
>
> * No longer forces bit-banging on. As Daniel observed, this is not
> really required, and I checked that, indeed, it is not.
>
> * Ville made a comment a while ago that we should not enable the
> extended panel-scaling of the IVCH, so I removed it. In fact, as the X30
> bios does not restore registers during resume, it also fails to restore
> the (undocumented) values of the advanced interpolation polynomials and
> as such degrades the image quality when resuming from suspend.
>
> Other than that, this patch has been successfully tested both on an IBM
> X30 and on an IBM R31 ThinkPad, both making use of the IVCH DVO chip.
Yup this one applies cleanly now. Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-15 10:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 19:04 [PATCH] Fix resume from suspend to RAM on IBM X30 Thomas Richter
2015-05-26 7:27 ` Daniel Vetter
[not found] ` <12029_1432625085_55641FBD_12029_12802_1_20150526072710.GE12971@phenom.ffwll.local>
2015-06-01 8:25 ` [PATCH] Fix resume from suspend to RAM on IBM X30 (take two) Thomas Richter
2015-06-15 10:21 ` Daniel Vetter [this message]
2015-06-15 13:46 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615102149.GS8341@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=thor@math.tu-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox