From: Daniel Vetter <daniel@ffwll.ch>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/skl: Assume no scaling is available when things are not as expected
Date: Mon, 15 Jun 2015 12:46:17 +0200 [thread overview]
Message-ID: <20150615104617.GA8341@phenom.ffwll.local> (raw)
In-Reply-To: <1433160277-28337-1-git-send-email-tvrtko.ursulin@linux.intel.com>
On Mon, Jun 01, 2015 at 01:04:37PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Cdclk < crtc_clock is not allowed and suggests a different problem elsewhere.
>
> It is more robust and safe to assume no scaling is possible in this case.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> ---
> drivers/gpu/drm/i915/intel_display.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c
> index 93a5e51..4c99373 100644
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -13234,7 +13234,7 @@ skl_max_scale(struct intel_crtc *intel_crtc, struct intel_crtc_state *crtc_state
> crtc_clock = crtc_state->base.adjusted_mode.crtc_clock;
> cdclk = dev_priv->display.get_display_clock_speed(dev);
Probably fallout from the in-flight dynamic cdclk stuff - this code checks
the wrong bits I guess. Chandra?
Thanks, Daniel
>
> - if (!crtc_clock || !cdclk)
> + if (!crtc_clock || !cdclk || (cdclk < crtc_clock))
> return DRM_PLANE_HELPER_NO_SCALING;
>
> /*
> --
> 2.4.0
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-15 10:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-01 12:04 [PATCH] drm/i915/skl: Assume no scaling is available when things are not as expected Tvrtko Ursulin
2015-06-01 21:45 ` shuang.he
2015-06-15 10:46 ` Daniel Vetter [this message]
2015-06-15 21:03 ` Konduru, Chandra
2015-06-16 13:40 ` Daniel Vetter
2015-06-16 13:46 ` Ville Syrjälä
2015-06-17 11:41 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615104617.GA8341@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox