From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH] drm/i915: Fix failure paths around initial
 fbdev allocation
Date: Mon, 15 Jun 2015 14:22:54 +0300
Message-ID: <20150615112254.GI5176@intel.com>
References: <1434365392-19808-1-git-send-email-tvrtko.ursulin@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by gabe.freedesktop.org (Postfix) with ESMTP id 397E66E752
 for <Intel-gfx@lists.freedesktop.org>; Mon, 15 Jun 2015 04:23:06 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1434365392-19808-1-git-send-email-tvrtko.ursulin@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCBKdW4gMTUsIDIwMTUgYXQgMTE6NDk6NTJBTSArMDEwMCwgVHZydGtvIFVyc3VsaW4g
d3JvdGU6Cj4gRnJvbTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4K
PiAKPiBXZSBoYWQgdHdvIGZhaWx1cmUgbW9kZXMgaGVyZToKPiAKPiAxLgo+IERlYWRsb2NrIGlu
IGludGVsZmJfYWxsb2MgZmFpbHVyZSBwYXRoIHdoZXJlIGl0IGNhbGxzIGRybV9mcmFtZWJ1ZmZl
cl9yZW1vdmUsCj4gd2hpY2ggZ3JhYnMgdGhlIHN0cnVjdCBtdXRleCBhbmQgaW50ZWxmYl9jcmVh
dGUgKGNhbGxlciBvZiBpbnRlbGZiX2FsbG9jKSB3YXMKPiBhbHJlYWR5IGhvbGRpbmcgaXQuCj4g
Cj4gMi4KPiBEb3VibGUgdW5yZWZlcmVuY2Ugb24gdGhlIG9iamVjdCBpZiBfX2ludGVsX2ZyYW1l
YnVmZmVyX2NyZWF0ZSBmYWlscyBzaW5jZQo+IGJvdGggaXQgYW5kIHRoZSBjYWxsZXIgKGludGVs
ZmJfYWxsb2MpIGRvIHRoZSB1bnJlZmVyZW5jZS4KCkkgd291bGQgc3VnZ2VzdCByZW1vdmluZyB0
aGUgdW5yZWYgZnJvbSBfX2ludGVsX2ZyYW1lYnVmZmVyX2NyZWF0ZSgpLgoKPiAKPiBTaWduZWQt
b2ZmLWJ5OiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IENjOiBD
aHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51az4KPiBDYzogVmlsbGUgU3lyasOk
bMOkIDx2aWxsZS5zeXJqYWxhQGxpbnV4LmludGVsLmNvbT4KPiAtLS0KPiAgZHJpdmVycy9ncHUv
ZHJtL2k5MTUvaW50ZWxfZmJkZXYuYyB8IDIxICsrKysrKysrKysrKystLS0tLS0tLQo+ICAxIGZp
bGUgY2hhbmdlZCwgMTMgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0t
Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJkZXYuYyBiL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX2ZiZGV2LmMKPiBpbmRleCA2MzcyY2ZjLi5iOTk4ZjY5IDEwMDY0NAo+IC0t
LSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMKPiArKysgYi9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jCj4gQEAgLTE0MSw3ICsxNDEsNyBAQCBzdGF0aWMgaW50
IGludGVsZmJfYWxsb2Moc3RydWN0IGRybV9mYl9oZWxwZXIgKmhlbHBlciwKPiAgewo+ICAJc3Ry
dWN0IGludGVsX2ZiZGV2ICppZmJkZXYgPQo+ICAJCWNvbnRhaW5lcl9vZihoZWxwZXIsIHN0cnVj
dCBpbnRlbF9mYmRldiwgaGVscGVyKTsKPiAtCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiOwo+
ICsJc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmIgPSBOVUxMOwo+ICAJc3RydWN0IGRybV9kZXZp
Y2UgKmRldiA9IGhlbHBlci0+ZGV2Owo+ICAJc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgbW9kZV9j
bWQgPSB7fTsKPiAgCXN0cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmo7Cj4gQEAgLTE1OSw2
ICsxNTksOCBAQCBzdGF0aWMgaW50IGludGVsZmJfYWxsb2Moc3RydWN0IGRybV9mYl9oZWxwZXIg
KmhlbHBlciwKPiAgCW1vZGVfY21kLnBpeGVsX2Zvcm1hdCA9IGRybV9tb2RlX2xlZ2FjeV9mYl9m
b3JtYXQoc2l6ZXMtPnN1cmZhY2VfYnBwLAo+ICAJCQkJCQkJICBzaXplcy0+c3VyZmFjZV9kZXB0
aCk7Cj4gIAo+ICsJbXV0ZXhfbG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICsKPiAgCXNpemUg
PSBtb2RlX2NtZC5waXRjaGVzWzBdICogbW9kZV9jbWQuaGVpZ2h0Owo+ICAJc2l6ZSA9IFBBR0Vf
QUxJR04oc2l6ZSk7Cj4gIAlvYmogPSBpOTE1X2dlbV9vYmplY3RfY3JlYXRlX3N0b2xlbihkZXYs
IHNpemUpOwo+IEBAIC0xNzIsOCArMTc0LDkgQEAgc3RhdGljIGludCBpbnRlbGZiX2FsbG9jKHN0
cnVjdCBkcm1fZmJfaGVscGVyICpoZWxwZXIsCj4gIAo+ICAJZmIgPSBfX2ludGVsX2ZyYW1lYnVm
ZmVyX2NyZWF0ZShkZXYsICZtb2RlX2NtZCwgb2JqKTsKPiAgCWlmIChJU19FUlIoZmIpKSB7Cj4g
KwkJLyogRHJvcHMgb2JqZWN0IHJlZmVyZW5jZSBvbiBmYWlsdXJlLiAqLwo+ICAJCXJldCA9IFBU
Ul9FUlIoZmIpOwo+IC0JCWdvdG8gb3V0X3VucmVmOwo+ICsJCWdvdG8gb3V0Owo+ICAJfQo+ICAK
PiAgCS8qIEZsdXNoIGV2ZXJ5dGhpbmcgb3V0LCB3ZSdsbCBiZSBkb2luZyBHVFQgb25seSBmcm9t
IG5vdyBvbiAqLwo+IEBAIC0xODMsMTUgKzE4NiwxOCBAQCBzdGF0aWMgaW50IGludGVsZmJfYWxs
b2Moc3RydWN0IGRybV9mYl9oZWxwZXIgKmhlbHBlciwKPiAgCQlnb3RvIG91dF9mYjsKPiAgCX0K
PiAgCj4gKwltdXRleF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiArCj4gIAlpZmJkZXYt
PmZiID0gdG9faW50ZWxfZnJhbWVidWZmZXIoZmIpOwo+ICAKPiAgCXJldHVybiAwOwo+ICAKPiAg
b3V0X2ZiOgo+IC0JZHJtX2ZyYW1lYnVmZmVyX3JlbW92ZShmYik7Cj4gLW91dF91bnJlZjoKPiAg
CWRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNlKCZvYmotPmJhc2UpOwo+ICBvdXQ6Cj4gKwltdXRl
eF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiArCWlmIChmYikKPiArCQlkcm1fZnJhbWVi
dWZmZXJfcmVtb3ZlKGZiKTsKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiAgCj4gQEAgLTIwOSw4ICsy
MTUsNiBAQCBzdGF0aWMgaW50IGludGVsZmJfY3JlYXRlKHN0cnVjdCBkcm1fZmJfaGVscGVyICpo
ZWxwZXIsCj4gIAlpbnQgc2l6ZSwgcmV0Owo+ICAJYm9vbCBwcmVhbGxvYyA9IGZhbHNlOwo+ICAK
PiAtCW11dGV4X2xvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiAtCj4gIAlpZiAoaW50ZWxfZmIg
JiYKPiAgCSAgICAoc2l6ZXMtPmZiX3dpZHRoID4gaW50ZWxfZmItPmJhc2Uud2lkdGggfHwKPiAg
CSAgICAgc2l6ZXMtPmZiX2hlaWdodCA+IGludGVsX2ZiLT5iYXNlLmhlaWdodCkpIHsKPiBAQCAt
MjI1LDcgKzIyOSw3IEBAIHN0YXRpYyBpbnQgaW50ZWxmYl9jcmVhdGUoc3RydWN0IGRybV9mYl9o
ZWxwZXIgKmhlbHBlciwKPiAgCQlEUk1fREVCVUdfS01TKCJubyBCSU9TIGZiLCBhbGxvY2F0aW5n
IGEgbmV3IG9uZVxuIik7Cj4gIAkJcmV0ID0gaW50ZWxmYl9hbGxvYyhoZWxwZXIsIHNpemVzKTsK
PiAgCQlpZiAocmV0KQo+IC0JCQlnb3RvIG91dF91bmxvY2s7Cj4gKwkJCXJldHVybiByZXQ7Cj4g
IAkJaW50ZWxfZmIgPSBpZmJkZXYtPmZiOwo+ICAJfSBlbHNlIHsKPiAgCQlEUk1fREVCVUdfS01T
KCJyZS11c2luZyBCSU9TIGZiXG4iKTsKPiBAQCAtMjM3LDYgKzI0MSw4IEBAIHN0YXRpYyBpbnQg
aW50ZWxmYl9jcmVhdGUoc3RydWN0IGRybV9mYl9oZWxwZXIgKmhlbHBlciwKPiAgCW9iaiA9IGlu
dGVsX2ZiLT5vYmo7Cj4gIAlzaXplID0gb2JqLT5iYXNlLnNpemU7Cj4gIAo+ICsJbXV0ZXhfbG9j
aygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICsKPiAgCWluZm8gPSBmcmFtZWJ1ZmZlcl9hbGxvYygw
LCAmZGV2LT5wZGV2LT5kZXYpOwo+ICAJaWYgKCFpbmZvKSB7Cj4gIAkJcmV0ID0gLUVOT01FTTsK
PiBAQCAtMzA3LDcgKzMxMyw2IEBAIHN0YXRpYyBpbnQgaW50ZWxmYl9jcmVhdGUoc3RydWN0IGRy
bV9mYl9oZWxwZXIgKmhlbHBlciwKPiAgb3V0X3VucGluOgo+ICAJaTkxNV9nZW1fb2JqZWN0X2dn
dHRfdW5waW4ob2JqKTsKPiAgCWRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNlKCZvYmotPmJhc2Up
Owo+IC1vdXRfdW5sb2NrOgo+ICAJbXV0ZXhfdW5sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4g
IAlyZXR1cm4gcmV0Owo+ICB9Cj4gLS0gCj4gMi40LjIKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50
ZWwgT1RDCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCklu
dGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw
Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==