From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH igt 1/4] tests/template: add IGT_TEST_DESCRIPTION
Date: Mon, 15 Jun 2015 14:11:58 +0200 [thread overview]
Message-ID: <20150615121158.GL8341@phenom.ffwll.local> (raw)
In-Reply-To: <1433428266-1867-1-git-send-email-przanoni@gmail.com>
On Thu, Jun 04, 2015 at 11:31:03AM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> So people that write tests based on the template don't forget to use
> the macro.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
With the nit to not try to enable fbc on pre-gen6 address the series is
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
> ---
> tests/template.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tests/template.c b/tests/template.c
> index 24fd850..4b5794b 100644
> --- a/tests/template.c
> +++ b/tests/template.c
> @@ -26,6 +26,8 @@
>
> #include "drmtest.h"
>
> +IGT_TEST_DESCRIPTION("Template test.");
> +
> /*
> * Note that test function (and code called by them) should generally not return
> * a variable indicating success/failure. Instead use the igt_require/igt_assert
> --
> 2.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-06-15 12:09 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-04 14:31 [PATCH igt 1/4] tests/template: add IGT_TEST_DESCRIPTION Paulo Zanoni
2015-06-04 14:31 ` [PATCH igt 2/4] lib/igt_aux: add functions to manipulate i915.ko parameters Paulo Zanoni
2015-06-04 14:31 ` [PATCH igt 3/4] tests/kms_fbc_crc: run even if FBC is disabled by default Paulo Zanoni
2015-06-15 12:11 ` Daniel Vetter
2015-06-15 14:08 ` Paulo Zanoni
2015-06-15 15:07 ` Daniel Vetter
2015-06-04 14:31 ` [PATCH igt 4/4] tests/kms_psr_sink_crc: test even if PSR " Paulo Zanoni
2015-06-04 16:01 ` Rodrigo Vivi
2015-06-15 12:11 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150615121158.GL8341@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox