From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH 2/4] drm/i915: get rid of intel_plane_restore in intel_crtc_page_flip Date: Mon, 15 Jun 2015 18:44:01 +0200 Message-ID: <20150615164401.GJ23637@phenom.ffwll.local> References: <1434100542-15301-1-git-send-email-maarten.lankhorst@linux.intel.com> <1434100542-15301-3-git-send-email-maarten.lankhorst@linux.intel.com> <20150612101600.GT5176@intel.com> <557AB509.9080202@linux.intel.com> <20150612112754.GY5176@intel.com> <20150612114314.GZ5176@intel.com> <557ADBD0.7060605@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f45.google.com (mail-wg0-f45.google.com [74.125.82.45]) by gabe.freedesktop.org (Postfix) with ESMTP id 664BD6E85E for ; Mon, 15 Jun 2015 09:41:16 -0700 (PDT) Received: by wgzl5 with SMTP id l5so48627247wgz.3 for ; Mon, 15 Jun 2015 09:41:15 -0700 (PDT) Content-Disposition: inline In-Reply-To: <557ADBD0.7060605@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKdW4gMTIsIDIwMTUgYXQgMDM6MTc6MDRQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMTItMDYtMTUgb20gMTM6NDMgc2NocmVlZiBWaWxsZSBTeXJqw6Rsw6Q6 Cj4gPiBPbiBGcmksIEp1biAxMiwgMjAxNSBhdCAwMjoyNzo1NFBNICswMzAwLCBWaWxsZSBTeXJq w6Rsw6Qgd3JvdGU6Cj4gPj4gT24gRnJpLCBKdW4gMTIsIDIwMTUgYXQgMTI6MzE6MzdQTSArMDIw MCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4gPj4+IE9wIDEyLTA2LTE1IG9tIDEyOjE2IHNj aHJlZWYgVmlsbGUgU3lyasOkbMOkOgo+ID4+Pj4gT24gRnJpLCBKdW4gMTIsIDIwMTUgYXQgMTE6 MTU6NDBBTSArMDIwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4gPj4+Pj4gVXNlIGEgZnVs bCBhdG9taWMgY2FsbCBpbnN0ZWFkLiBpbnRlbF9jcnRjX3BhZ2VfZmxpcCB3aWxsIHN0aWxsCj4g Pj4+Pj4gaGF2ZSB0byBsaXZlIHVudGlsIGFzeW5jIHVwZGF0ZXMgYXJlIGFsbG93ZWQuCj4gPj4+ Pj4KPiA+Pj4+PiBUaGlzIGRvZXNuJ3Qgc2VlbSB0byBiZSBhIHJlZ3Jlc3Npb24gZnJvbSB0aGUg Y29udmVydCB0byBhdG9taWMsCj4gPj4+Pj4gcGFydCAzIHBhdGNoLiBEdXJpbmcgR1BVIHJlc2V0 IGl0IGZpeGVzIHRoZSBmb2xsb3dpbmcgd2FybmluZzoKPiA+Pj4+Pgo+ID4+Pj4+ICAtLS0tLS0t LS0tLS1bIGN1dCBoZXJlIF0tLS0tLS0tLS0tLS0KPiA+Pj4+PiBXQVJOSU5HOiBDUFU6IDAgUElE OiA3NTIgYXQgZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmM6NTMzNyBkcm1fbW9kZV9wYWdlX2Zs aXBfaW9jdGwrMHgyN2IvMHgzNjAoKQo+ID4+Pj4+IE1vZHVsZXMgbGlua2VkIGluOiBpOTE1Cj4g Pj4+Pj4gQ1BVOiAwIFBJRDogNzUyIENvbW06IFhvcmcgTm90IHRhaW50ZWQgNC4xLjAtcmM3LXBh dHNlcisgIzQwOTAKPiA+Pj4+PiBIYXJkd2FyZSBuYW1lOiBOVUM1aTdSWUIsIEJJT1MgUllCRFdp MzUuODZBLjAyNDYuMjAxNS4wMzA5LjEzNTUgMDMvMDkvMjAxNQo+ID4+Pj4+ICBmZmZmZmZmZjgx YzkwODY2IGZmZmY4ODAwZDg3YzNjYTggZmZmZmZmZmY4MTdmN2Q4NyAwMDAwMDAwMDgwMDAwMDAx Cj4gPj4+Pj4gIDAwMDAwMDAwMDAwMDAwMDAgZmZmZjg4MDBkODdjM2NlOCBmZmZmZmZmZjgxMDg0 OTU1IGZmZmY4ODAwMDAwMDAwMDAKPiA+Pj4+PiAgZmZmZjg4MDBkODdjM2RjMCBmZmZmODgwMGQ5 M2QxMjA4IDAwMDAwMDAwMDAwMDAwMDAgZmZmZjg4MDBiN2QxZjNlMAo+ID4+Pj4+IENhbGwgVHJh Y2U6Cj4gPj4+Pj4gIFs8ZmZmZmZmZmY4MTdmN2Q4Nz5dIGR1bXBfc3RhY2srMHg0Zi8weDdiCj4g Pj4+Pj4gIFs8ZmZmZmZmZmY4MTA4NDk1NT5dIHdhcm5fc2xvd3BhdGhfY29tbW9uKzB4ODUvMHhj MAo+ID4+Pj4+ICBbPGZmZmZmZmZmODEwODRhMzU+XSB3YXJuX3Nsb3dwYXRoX251bGwrMHgxNS8w eDIwCj4gPj4+Pj4gIFs8ZmZmZmZmZmY4MTQ2ZGZmYj5dIGRybV9tb2RlX3BhZ2VfZmxpcF9pb2N0 bCsweDI3Yi8weDM2MAo+ID4+Pj4+ICBbPGZmZmZmZmZmODE0NWNjYjA+XSBkcm1faW9jdGwrMHgx YTAvMHg2YTAKPiA+Pj4+PiAgWzxmZmZmZmZmZjgxMGIzYjQxPl0gPyBnZXRfcGFyZW50X2lwKzB4 MTEvMHg1MAo+ID4+Pj4+ICBbPGZmZmZmZmZmODEyZTU1NDA+XSA/IGF2Y19oYXNfcGVybSsweDIw LzB4MjgwCj4gPj4+Pj4gIFs8ZmZmZmZmZmY4MTBiM2I0MT5dID8gZ2V0X3BhcmVudF9pcCsweDEx LzB4NTAKPiA+Pj4+PiAgWzxmZmZmZmZmZjgxMWVhMGY4Pl0gZG9fdmZzX2lvY3RsKzB4MmY4LzB4 NTMwCj4gPj4+Pj4gIFs8ZmZmZmZmZmY4MTFmNjAwMT5dID8gZXhwYW5kX2ZpbGVzKzB4MjYxLzB4 MjcwCj4gPj4+Pj4gIFs8ZmZmZmZmZmY4MTJlN2MxNj5dID8gc2VsaW51eF9maWxlX2lvY3RsKzB4 NTYvMHgxMDAKPiA+Pj4+PiAgWzxmZmZmZmZmZjgxMWVhM2IxPl0gU3lTX2lvY3RsKzB4ODEvMHhh MAo+ID4+Pj4+ICBbPGZmZmZmZmZmODE4MDFiOTc+XSBzeXN0ZW1fY2FsbF9mYXN0cGF0aCsweDEy LzB4NmYKPiA+Pj4+PiAtLS1bIGVuZCB0cmFjZSA5Y2U4MzQ1NjAwODViZDY0IF0tLS0KPiA+Pj4+ Pgo+ID4+Pj4+IFNpZ25lZC1vZmYtYnk6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFydGVuLmxhbmto b3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gPj4+Pj4gLS0tCj4gPj4+Pj4gIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDI5ICsrKysrKysrKysrKysrKysrKysrKysrKysrKyst Cj4gPj4+Pj4gIDEgZmlsZSBjaGFuZ2VkLCAyOCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0p Cj4gPj4+Pj4KPiA+Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPj4+Pj4g aW5kZXggN2FiYWZmZWRhN2NlLi5jZGY2NTQ5YzhlNzQgMTAwNjQ0Cj4gPj4+Pj4gLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPj4+Pj4gKysrIGIvZHJpdmVycy9n cHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPj4+Pj4gQEAgLTExNjE4LDggKzExNjE4LDM1 IEBAIGZyZWVfd29yazoKPiA+Pj4+PiAgCWtmcmVlKHdvcmspOwo+ID4+Pj4+ICAKPiA+Pj4+PiAg CWlmIChyZXQgPT0gLUVJTykgewo+ID4+Pj4+ICsJCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpz dGF0ZTsKPiA+Pj4+PiArCQlzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZTsKPiA+ Pj4+PiArCj4gPj4+Pj4gIG91dF9oYW5nOgo+ID4+Pj4+IC0JCXJldCA9IGludGVsX3BsYW5lX3Jl c3RvcmUocHJpbWFyeSk7Cj4gPj4+PiBTbyB3aGF0IGV4YWN0bHkgaXMgd3Jvbmcgd2l0aCBpbnRl bF9wbGFuZV9yZXN0b3JlKCkgKGllLgo+ID4+Pj4gZHJtX3BsYW5lX2hlbHBlcl91cGRhdGUoKSk/ IFNob3VsZG4ndCB5b3UgZml4IHRoYXQgaW5zdGVhZCBvZiBzcHJlYWRpbmcKPiA+Pj4+IHRoZSB1 Z2x5bmVzcyBoZXJlPwo+ID4+Pj4KPiA+Pj4gaW50ZWxfcGxhbmVfcmVzdG9yZSB1c2VzIHRoZSB0 cmFuc2l0aW9uYWwgaGVscGVycy4gVGhpcyBpcyBjdXJyZW50bHkgdXNlZCBmb3IKPiA+Pj4gc2V0 dGluZyBjb2xvciBrZXksIGVuYWJsaW5nIHNwcml0ZSBwbGFuZXMgYWZ0ZXIgYSBtb2Rlc2V0IGFu ZCB0aGlzIGZ1bmN0aW9uLgo+ID4+PiAtIENvbG9yIGtleSB3aWxsIGJlIG1hZGUgYXRvbWljIGJ5 IG1ha2luZyBja2V5IHBhcnQgb2YgdGhlIHBsYW5lIHN0YXRlLgo+ID4+IFdlbGwgd2hhdCBmdW5j dGlvbiBkbyB5b3UgcGxhbiB0byBjYWxsIHRoZXJlPyBUaGUgc2FtZSBzaG91bGQgd29yayBoZXJl Cj4gPj4gbm8/Cj4gPiBUbyBlbGFib3JhdGUgYSBiaXQgbW9yZS4gTXkgbWFpbiBncmlwZSBoZXJl IGlzIGFsbCB0aGlzIGJvaWxlcnBsYXRlIHdlCj4gPiBuZWVkLiBJIGhvcGUgd2UncmUgcGxhbm5p bmcgdG8gYWJzdHJhY3QgdGhhdCBhd2F5IGEgYml0IHNvIHdlIGRvbid0IGhhdmUKPiA+IHRvIGtl ZXAgcmVwZWF0aW5nIGl0IGV2ZXJ5d2hlcmUuCj4gCj4gRXZlbnR1YWxseSBjb2xvciBrZXkgc2hv dWxkIHByb2JhYmx5IGJlY29tZSBhIHByb3BlcnR5LCBidXQgaG93IGRvZXMgdGhpcyBsb29rPwo+ IAo+IEFkZGluZyBjb2xvciBrZXkgd2l0aCB0aGlzIGZ1bmN0aW9uIHNob3VsZCBiZSBlYXN5LgoK WWVhaCBvbmNlIGV2ZXJ5dGhpbmcgZ29lcyBwcm9wZXJseSB0aHJvdWdoIGF0b21pYyBwcm9wcyBh bmQgaGVscGVycyB0aGlzCmJvaWxlcnBsYXRlIHN0YXRlIGZyb2JiaW5nIHNob3VsZCBnbyBhd2F5 LiBVbnRpbCB0aGVuIHdlIGp1c3QgaGF2ZSB0byBiZWFyCnRoZSBjb3N0IG9mIGhhdmluZyB0b25z IG9mIGRyaXZlci1zcGVjaWZpYyBsb2dpYyBhbGwgb3ZlciB0aGUgcGxhY2UgaW4KaTkxNS4gTm90 ZSBhIHdob2xlIGxvdCB3ZSBjYW4gZG8gYWJvdXQgdGhhdC4KCkluIHRoZSBlbmQgSSBob3BlIHRo ZSBvbmx5IHRoaW5nIHdlIHJlYWxseSBuZWVkIHRvIGtlZXAgYXJvdW5kIGlzIHN0YXRlCmZyb2Ji ZXJyeSBmb3IgdGhlIGh3IHN0YXRlIHJlYWRvdXQgKHRoZSBmb3JjZS1yZXN0b3JlIHNob3VsZCBi ZSBkb2FibGUKd2l0aCBkcm0gYXRvbWljIGhlbHBlcnMgdG8gc2F2ZS9yZXN0b3JlIGFsbCBhdG9t aWMgc3RhdGUpIGFuZCBpbiB0aGUgbG9hZApkZXRlY3QgY29kZSAodGhhdCdzIHRydWx5IGRyaXZl ciBwcml2YXRlKS4KLURhbmllbAoKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5j Cj4gaW5kZXggN2FiYWZmZWRhN2NlLi5jZGE4NWVjYTcxNzQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZGlzcGxheS5jCj4gQEAgLTExNDMxLDYgKzExNDMxLDUzIEBAIHZvaWQgaW50ZWxf Y2hlY2tfcGFnZV9mbGlwKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIGludCBwaXBlKQo+ICAJc3Bp bl91bmxvY2soJmRldi0+ZXZlbnRfbG9jayk7Cj4gIH0KPiAgCj4gK3N0YXRpYyBpbnQgaW50ZWxf dXBkYXRlX3BsYW5lX3N0YXRlKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lLAo+ICsJCQkJICAgIHN0 cnVjdCBkcm1fbW9kZXNldF9hY3F1aXJlX2N0eCAqYWNxdWlyZV9jdHgsCj4gKwkJCQkgICAgaW50 ICgqdXBkYXRlX2ZuKShzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICosIHZvaWQgKmRhdGEpLAo+ICsJ CQkJICAgIHZvaWQgKmRhdGEpCj4gK3sKPiArCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0 ZTsKPiArCXN0cnVjdCBkcm1fcGxhbmVfc3RhdGUgKnBsYW5lX3N0YXRlOwo+ICsJaW50IHJldDsK PiArCj4gKwlzdGF0ZSA9IGRybV9hdG9taWNfc3RhdGVfYWxsb2MocGxhbmUtPmRldik7Cj4gKwlp ZiAoIXN0YXRlKQo+ICsJCXJldHVybiAtRU5PTUVNOwo+ICsKPiArCXN0YXRlLT5hY3F1aXJlX2N0 eCA9IGFjcXVpcmVfY3R4Owo+ICsKPiArcmV0cnk6Cj4gKwlwbGFuZV9zdGF0ZSA9IGRybV9hdG9t aWNfZ2V0X3BsYW5lX3N0YXRlKHN0YXRlLCBwbGFuZSk7Cj4gKwlyZXQgPSBQVFJfRVJSX09SX1pF Uk8ocGxhbmVfc3RhdGUpOwo+ICsJaWYgKCFyZXQpCj4gKwkJcmV0ID0gdXBkYXRlX2ZuKHBsYW5l X3N0YXRlLCBkYXRhKTsKPiArCj4gKwlpZiAoIXJldCkKPiArCQlyZXQgPSBkcm1fYXRvbWljX2Nv bW1pdChzdGF0ZSk7Cj4gKwo+ICsJaWYgKHJldCA9PSAtRURFQURMSykgewo+ICsJCWRybV9tb2Rl c2V0X2JhY2tvZmYoc3RhdGUtPmFjcXVpcmVfY3R4KTsKPiArCQlkcm1fYXRvbWljX3N0YXRlX2Ns ZWFyKHN0YXRlKTsKPiArCQlnb3RvIHJldHJ5Owo+ICsJfQo+ICsKPiArCWlmIChyZXQpCj4gKwkJ ZHJtX2F0b21pY19zdGF0ZV9mcmVlKHN0YXRlKTsKPiArCj4gKwlyZXR1cm4gcmV0Owo+ICt9Cj4g Kwo+ICtzdGF0aWMgaW50Cj4gK2ludGVsX2NydGNfcGFnZV9mbGlwX3VwZGF0ZV9mYihzdHJ1Y3Qg ZHJtX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZSwgdm9pZCAqZGF0YSkKPiArewo+ICsJZHJtX2F0 b21pY19zZXRfZmJfZm9yX3BsYW5lKHBsYW5lX3N0YXRlLCBkYXRhKTsKPiArCj4gKwlpZiAoV0FS Tl9PTighcGxhbmVfc3RhdGUtPmNydGMpKQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsKPiArCXJl dHVybiAwOwo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IGludGVsX2NydGNfcGFnZV9mbGlwKHN0cnVj dCBkcm1fY3J0YyAqY3J0YywKPiAgCQkJCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiLAo+ICAJ CQkJc3RydWN0IGRybV9wZW5kaW5nX3ZibGFua19ldmVudCAqZXZlbnQsCj4gQEAgLTExNjE5LDcg KzExNjY2LDggQEAgZnJlZV93b3JrOgo+ICAKPiAgCWlmIChyZXQgPT0gLUVJTykgewo+ICBvdXRf aGFuZzoKPiAtCQlyZXQgPSBpbnRlbF9wbGFuZV9yZXN0b3JlKHByaW1hcnkpOwo+ICsJCXJldCA9 IGludGVsX3VwZGF0ZV9wbGFuZV9zdGF0ZShwcmltYXJ5LCBkcm1fbW9kZXNldF9sZWdhY3lfYWNx dWlyZV9jdHgoY3J0YyksIGludGVsX2NydGNfcGFnZV9mbGlwX3VwZGF0ZV9mYiwgZmIpOwo+ICsK PiAgCQlpZiAocmV0ID09IDAgJiYgZXZlbnQpIHsKPiAgCQkJc3Bpbl9sb2NrX2lycSgmZGV2LT5l dmVudF9sb2NrKTsKPiAgCQkJZHJtX3NlbmRfdmJsYW5rX2V2ZW50KGRldiwgcGlwZSwgZXZlbnQp Owo+IAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4g SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK PiBodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 CgotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24K aHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK