From: Matt Roper <matthew.d.roper@intel.com>
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Use helper to set CRTC state's mode
Date: Tue, 16 Jun 2015 15:12:11 -0700 [thread overview]
Message-ID: <20150616221211.GF30250@intel.com> (raw)
In-Reply-To: <5575213A.5080307@linux.intel.com>
On Mon, Jun 08, 2015 at 06:59:38AM +0200, Maarten Lankhorst wrote:
> Hey,
>
> Op 06-06-15 om 00:08 schreef Matt Roper:
> > We need to call drm_atomic_set_mode_for_crtc() rather than copying the
> > mode in manually. As of commit
> >
> > commit 99cf4a29fa24461bbfe22125967188a18383eb5c
> > Author: Daniel Stone <daniels@collabora.com>
> > Date: Mon May 25 19:11:51 2015 +0100
> >
> > drm/atomic: Add current-mode blob to CRTC state
> >
> > the helper now also takes care of setting up the mode property blob for
> > us; if we don't use the helper and never setup the mode blob, this will
> > also trigger a failure in drm_atomic_crtc_check() when we have the
> > DRIVER_ATOMIC flag set (i.e., when using the nuclear pageflip support
> > via i915.nuclear_pageflip kernel command line parameter).
> >
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> You're probably correct, but convert to atomic part 3 removes this code entirely. :-)
I'm probably getting confused by all the different spins of atomic
conversion series now, but it looks like this is still needed, even on
top of your latest "Convert to atomic, part 3" set (from June 15th);
we'll end up with no mode blob which leads to warnings and failures from
the DRM core if we don't apply a fix like this to use the helper
function.
Matt
>
> ~Maarten
--
Matt Roper
Graphics Software Engineer
IoTG Platform Enabling & Development
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-16 22:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-05 22:08 [PATCH] drm/i915: Use helper to set CRTC state's mode Matt Roper
2015-06-06 10:50 ` shuang.he
2015-06-08 4:59 ` Maarten Lankhorst
2015-06-16 22:12 ` Matt Roper [this message]
2015-06-17 5:47 ` Maarten Lankhorst
2015-06-17 11:42 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150616221211.GF30250@intel.com \
--to=matthew.d.roper@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=maarten.lankhorst@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox