From: Daniel Vetter <daniel@ffwll.ch>
To: Sagar Arun Kamble <sagar.a.kamble@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 1/1] drm/i915: Tracepoints for profiling DC9 entry and exit programming
Date: Mon, 22 Jun 2015 14:56:50 +0200 [thread overview]
Message-ID: <20150622125650.GX25769@phenom.ffwll.local> (raw)
In-Reply-To: <1434862209.30388.3.camel@sakamble-desktop>
On Sun, Jun 21, 2015 at 10:20:09AM +0530, Sagar Arun Kamble wrote:
> On Wed, 2015-06-17 at 13:30 +0200, Daniel Vetter wrote:
> > On Wed, Jun 17, 2015 at 04:21:10PM +0530, Sagar Arun Kamble wrote:
> > > DC9 entry and exit programming is critical part of suspend/resume
> > > sequences. This patch adds tracepoints that can help analyze time
> > > taken using analyze_suspend.py/FTrace.
> > >
> > > Change-Id: I22fca5313c4349f8937eeb5a1c441c8ef76e5f4e
> > > Signed-off-by: Sagar Arun Kamble <sagar.a.kamble@intel.com>
> >
> > Tracepoints are for system profiling when benchmarking and all that. What
> > exactly is this here for?
> Hi Daniel,
> These trace points are added so that we can know how much time is spent
> in entry/exit programming of DC9 state which is done during
> runtime/system suspend. Analyzing these times is critical for resume
> time KPIs.
What's a KPI? Also if we want to instrument our runtime pm interface then
I think we should do this across the driver (probably at the power well
interface). Also you seem to instrument only suspend resume and not rpm
here.
> > Also note that tracepoints are pretty much ABI, so high standards apply
> > here.
> Already these tracepoints are present at PM Core level.
You're adding new labels and stuff and (see above) it looks not all that
well thought out yet.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-22 12:54 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 10:51 [PATCH 1/1] drm/i915: Tracepoints for profiling DC9 entry and exit programming Sagar Arun Kamble
2015-06-17 11:30 ` Daniel Vetter
2015-06-21 4:50 ` Sagar Arun Kamble
2015-06-22 12:56 ` Daniel Vetter [this message]
2015-06-29 5:25 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150622125650.GX25769@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=sagar.a.kamble@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox