From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC PATCH 2/7] drm/i915: Read hw state into an atomic state struct, try 2. Date: Mon, 22 Jun 2015 17:31:36 +0200 Message-ID: <20150622153136.GT25769@phenom.ffwll.local> References: <1434700950-16242-1-git-send-email-maarten.lankhorst@linux.intel.com> <1434700950-16242-3-git-send-email-maarten.lankhorst@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by gabe.freedesktop.org (Postfix) with ESMTP id 7308E720BC for ; Mon, 22 Jun 2015 08:28:49 -0700 (PDT) Received: by wicnd19 with SMTP id nd19so80235813wic.1 for ; Mon, 22 Jun 2015 08:28:48 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1434700950-16242-3-git-send-email-maarten.lankhorst@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gRnJpLCBKdW4gMTksIDIwMTUgYXQgMTA6MDI6MjVBTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gIC8qIFNjYW4gb3V0IHRoZSBjdXJyZW50IGh3IG1vZGVzZXQgc3RhdGUsIHNh bml0aXplcyBpdCBhbmQgbWFwcyBpdCBpbnRvIHRoZSBkcm0KPiBAQCAtMTU0OTEsMzcgKzE1NTY5 LDYxIEBAIHZvaWQgaW50ZWxfbW9kZXNldF9zZXR1cF9od19zdGF0ZShzdHJ1Y3QgZHJtX2Rldmlj ZSAqZGV2LAo+ICAJCQkJICBib29sIGZvcmNlX3Jlc3RvcmUpCj4gIHsKPiAgCXN0cnVjdCBkcm1f aTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZhdGU7Cj4gLQllbnVtIHBpcGUg cGlwZTsKPiAtCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRjOwo+ICsJc3RydWN0IGRybV9jcnRjICpj cnRjOwo+ICsJc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+ICAJc3RydWN0IGlu dGVsX2VuY29kZXIgKmVuY29kZXI7Cj4gKwlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGU7 Cj4gKwlzdHJ1Y3QgaW50ZWxfc2hhcmVkX2RwbGxfY29uZmlnIHNoYXJlZF9kcGxsc1tJOTE1X05V TV9QTExTXTsKPiAgCWludCBpOwo+ICAKPiAtCWludGVsX21vZGVzZXRfcmVhZG91dF9od19zdGF0 ZShkZXYpOwo+IC0KPiAtCS8qCj4gLQkgKiBOb3cgdGhhdCB3ZSBoYXZlIHRoZSBjb25maWcsIGNv cHkgaXQgdG8gZWFjaCBDUlRDIHN0cnVjdAo+IC0JICogTm90ZSB0aGF0IHRoaXMgY291bGQgZ28g YXdheSBpZiB3ZSBtb3ZlIHRvIHVzaW5nIGNydGNfY29uZmlnCj4gLQkgKiBjaGVja2luZyBldmVy eXdoZXJlLgo+IC0JICovCj4gLQlmb3JfZWFjaF9pbnRlbF9jcnRjKGRldiwgY3J0Yykgewo+IC0J CWlmIChjcnRjLT5hY3RpdmUgJiYgaTkxNS5mYXN0Ym9vdCkgewo+IC0JCQlpbnRlbF9tb2RlX2Zy b21fcGlwZV9jb25maWcoJmNydGMtPmJhc2UubW9kZSwKPiAtCQkJCQkJICAgIGNydGMtPmNvbmZp Zyk7Cj4gLQkJCURSTV9ERUJVR19LTVMoIltDUlRDOiVkXSBmb3VuZCBhY3RpdmUgbW9kZTogIiwK PiAtCQkJCSAgICAgIGNydGMtPmJhc2UuYmFzZS5pZCk7Cj4gLQkJCWRybV9tb2RlX2RlYnVnX3By aW50bW9kZWxpbmUoJmNydGMtPmJhc2UubW9kZSk7Cj4gLQkJfQo+ICsJc3RhdGUgPSBpbnRlbF9t b2Rlc2V0X3JlYWRvdXRfaHdfc3RhdGUoZGV2KTsKPiArCWlmIChJU19FUlIoc3RhdGUpKSB7Cj4g KwkJRFJNX0VSUk9SKCJGYWlsZWQgdG8gcmVhZCBvdXQgaHcgc3RhdGVcbiIpOwo+ICsJCXJldHVy bjsKPiAgCX0KPiAgCj4gKwlkcm1fYXRvbWljX2hlbHBlcl9zd2FwX3N0YXRlKGRldiwgc3RhdGUp Owo+ICsKPiArCS8qIHN3YXAgc3cvaHcgZHBsbCBzdGF0ZSAqLwo+ICsJaW50ZWxfYXRvbWljX2R1 cGxpY2F0ZV9kcGxsX3N0YXRlKGRldl9wcml2LCBzaGFyZWRfZHBsbHMpOwo+ICsJaW50ZWxfc2hh cmVkX2RwbGxfY29tbWl0KHN0YXRlKTsKPiArCW1lbWNweSh0b19pbnRlbF9hdG9taWNfc3RhdGUo c3RhdGUpLT5zaGFyZWRfZHBsbCwKPiArCSAgICAgICBzaGFyZWRfZHBsbHMsIHNpemVvZigqc2hh cmVkX2RwbGxzKSAqIGRldl9wcml2LT5udW1fc2hhcmVkX2RwbGwpOwoKVGhpcyBpcyBpbW8gd2F5 IHRvbyBtdWNoIG9wZW4tY29kaW5nIG9mIHN0dWZmIHRoYXQncyBhbHJlYWR5IHRoZXJlLiBXaGF0 IEkKaGFkIGluIG1pbmQgZm9yIGZvcmNlX3Jlc3RvcmUgd2FzIGEgZ2VuZXJpYyBoZWxwZXIgdG8g ZHVwbGljYXRlIGFsbCB0aGUKc3RhdGUgb2JqZWN0cyBpbnRvIGEgZHJtX2F0b21pY19zdGF0ZSwg d2l0aG91dCBjYWxsaW5nIGFueSBvZiB0aGUKLT5hdG9taWNfY2hlY2sgZnVuY3Rpb25zIG9yIGFu eXRoaW5nLiBUaGVuIHRoZSBzZXF1ZW5jZSBmb3IgcmVzdG9yaW5nCnN0YXRlIHdvdWxkIGJlLgoK MS4gc2F2ZWRfc3RhdGUgPSBkcm1fYXRvbWljX2hlbHBlcl9kdXBsaWNhdGVfc3RhdGUoKQoyLiBp bnRlbF9yZWFkb3V0X2h3X3NhdGUoKSA8LSB0aGlzIHdvdWxkIGp1c3QgdXBkYXRlIC0+c3RhdGUg YW5kIHNhbml0aXplCml0LgozLiBkcm1fYXRvbWljX2NvbW1pdChzYXZlZF9zdGF0ZSkgd3JhcHBl ZCBpbiBhIFdBUk5fT04gdG8gbWFrZSBzdXJlIGl0CmFsd2F5cyB3b3Jrcy4KCk9mYyB3ZSBzdGls bCBuZWVkIHRoZSB3dy1tdXRleCBkZWFkbG9jayBhdm9pZGFuY2Ugd3JhcHBlZCBhcm91bmQgdGhp cywgYnV0CnNpbmNlIGF0b21pY19jb21taXQgd2lsbCBmaXJzdCBjb21wdXRlIGFsbCBkZXJpdmVk IHN0YXRlIHRoZXJlJ3Mgbm8gbmVlZAp0byBkdXBsaWNhdGUgYWxsIHRoZSBpOTE1LWludGVybmFs IHN0YXRlIHRvby4gVGhhdCBzaG91bGQgYWxsIHdvcmsgbGlrZQp3aXRoIGFueSBvdGhlciBub3Jt YWwgbW9kZXNldC4KLURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwg SW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRl bC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcv bWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK