From: David Weinehall <david.weinehall@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/skl: Buffer translation improvements
Date: Tue, 23 Jun 2015 13:47:11 +0300 [thread overview]
Message-ID: <20150623104711.GK14570@boom> (raw)
In-Reply-To: <20150618150521.GI7752@phenom.ffwll.local>
On Thu, Jun 18, 2015 at 05:05:21PM +0200, Daniel Vetter wrote:
> On Thu, Jun 18, 2015 at 12:50:33PM +0300, David Weinehall wrote:
> > @@ -3520,6 +3545,9 @@ intel_dp_set_signal_levels(struct intel_dp *intel_dp, uint32_t *DP)
> > } else if (HAS_DDI(dev)) {
> > signal_levels = hsw_signal_levels(train_set);
> > mask = DDI_BUF_EMP_MASK;
> > +
> > + if (IS_SKYLAKE(dev))
> > + skl_set_iboost(intel_dp);
>
> Imo this should be put into hsw_signal_levels and then hsw_signal_levels
> be moved into intel_ddi.c - that way everything related to low-level ddi
> DP signal level code in intel_ddi.c.
I'll have a go at it.
Regards, David
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-06-23 10:47 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 9:50 [PATCH] drm/i915/skl: Buffer translation improvements David Weinehall
2015-06-18 10:10 ` Chris Wilson
2015-06-18 10:47 ` David Weinehall
2015-06-18 10:59 ` Chris Wilson
2015-06-23 10:28 ` David Weinehall
2015-06-25 8:09 ` David Weinehall
2015-06-18 15:05 ` Daniel Vetter
2015-06-23 10:47 ` David Weinehall [this message]
2015-06-23 11:12 ` David Weinehall
2015-06-23 12:07 ` Daniel Vetter
2015-06-24 4:47 ` Jindal, Sonika
2015-06-25 10:18 ` David Weinehall
2015-06-25 8:11 ` [PATCH v2] " David Weinehall
2015-06-29 10:35 ` Antti Koskipää
2015-06-29 16:12 ` Daniel Vetter
2015-06-30 10:27 ` David Weinehall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150623104711.GK14570@boom \
--to=david.weinehall@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox