From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [RFC PATCH 2/7] drm/i915: Read hw state into an atomic state struct, try 2. Date: Tue, 23 Jun 2015 13:40:39 +0200 Message-ID: <20150623114039.GV25769@phenom.ffwll.local> References: <1434700950-16242-1-git-send-email-maarten.lankhorst@linux.intel.com> <1434700950-16242-3-git-send-email-maarten.lankhorst@linux.intel.com> <20150622153136.GT25769@phenom.ffwll.local> <5589399C.7060400@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f181.google.com (mail-wi0-f181.google.com [209.85.212.181]) by gabe.freedesktop.org (Postfix) with ESMTP id 78ACC6E8D1 for ; Tue, 23 Jun 2015 04:37:52 -0700 (PDT) Received: by wiwl6 with SMTP id l6so63632174wiw.0 for ; Tue, 23 Jun 2015 04:37:51 -0700 (PDT) Content-Disposition: inline In-Reply-To: <5589399C.7060400@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKdW4gMjMsIDIwMTUgYXQgMTI6NDk6MDBQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMjItMDYtMTUgb20gMTc6MzEgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+ ID4gT24gRnJpLCBKdW4gMTksIDIwMTUgYXQgMTA6MDI6MjVBTSArMDIwMCwgTWFhcnRlbiBMYW5r aG9yc3Qgd3JvdGU6Cj4gPj4gIC8qIFNjYW4gb3V0IHRoZSBjdXJyZW50IGh3IG1vZGVzZXQgc3Rh dGUsIHNhbml0aXplcyBpdCBhbmQgbWFwcyBpdCBpbnRvIHRoZSBkcm0KPiA+PiBAQCAtMTU0OTEs MzcgKzE1NTY5LDYxIEBAIHZvaWQgaW50ZWxfbW9kZXNldF9zZXR1cF9od19zdGF0ZShzdHJ1Y3Qg ZHJtX2RldmljZSAqZGV2LAo+ID4+ICAJCQkJICBib29sIGZvcmNlX3Jlc3RvcmUpCj4gPj4gIHsK PiA+PiAgCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IGRldi0+ZGV2X3ByaXZh dGU7Cj4gPj4gLQllbnVtIHBpcGUgcGlwZTsKPiA+PiAtCXN0cnVjdCBpbnRlbF9jcnRjICpjcnRj Owo+ID4+ICsJc3RydWN0IGRybV9jcnRjICpjcnRjOwo+ID4+ICsJc3RydWN0IGRybV9jcnRjX3N0 YXRlICpjcnRjX3N0YXRlOwo+ID4+ICAJc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXI7Cj4g Pj4gKwlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGU7Cj4gPj4gKwlzdHJ1Y3QgaW50ZWxf c2hhcmVkX2RwbGxfY29uZmlnIHNoYXJlZF9kcGxsc1tJOTE1X05VTV9QTExTXTsKPiA+PiAgCWlu dCBpOwo+ID4+ICAKPiA+PiAtCWludGVsX21vZGVzZXRfcmVhZG91dF9od19zdGF0ZShkZXYpOwo+ ID4+IC0KPiA+PiAtCS8qCj4gPj4gLQkgKiBOb3cgdGhhdCB3ZSBoYXZlIHRoZSBjb25maWcsIGNv cHkgaXQgdG8gZWFjaCBDUlRDIHN0cnVjdAo+ID4+IC0JICogTm90ZSB0aGF0IHRoaXMgY291bGQg Z28gYXdheSBpZiB3ZSBtb3ZlIHRvIHVzaW5nIGNydGNfY29uZmlnCj4gPj4gLQkgKiBjaGVja2lu ZyBldmVyeXdoZXJlLgo+ID4+IC0JICovCj4gPj4gLQlmb3JfZWFjaF9pbnRlbF9jcnRjKGRldiwg Y3J0Yykgewo+ID4+IC0JCWlmIChjcnRjLT5hY3RpdmUgJiYgaTkxNS5mYXN0Ym9vdCkgewo+ID4+ IC0JCQlpbnRlbF9tb2RlX2Zyb21fcGlwZV9jb25maWcoJmNydGMtPmJhc2UubW9kZSwKPiA+PiAt CQkJCQkJICAgIGNydGMtPmNvbmZpZyk7Cj4gPj4gLQkJCURSTV9ERUJVR19LTVMoIltDUlRDOiVk XSBmb3VuZCBhY3RpdmUgbW9kZTogIiwKPiA+PiAtCQkJCSAgICAgIGNydGMtPmJhc2UuYmFzZS5p ZCk7Cj4gPj4gLQkJCWRybV9tb2RlX2RlYnVnX3ByaW50bW9kZWxpbmUoJmNydGMtPmJhc2UubW9k ZSk7Cj4gPj4gLQkJfQo+ID4+ICsJc3RhdGUgPSBpbnRlbF9tb2Rlc2V0X3JlYWRvdXRfaHdfc3Rh dGUoZGV2KTsKPiA+PiArCWlmIChJU19FUlIoc3RhdGUpKSB7Cj4gPj4gKwkJRFJNX0VSUk9SKCJG YWlsZWQgdG8gcmVhZCBvdXQgaHcgc3RhdGVcbiIpOwo+ID4+ICsJCXJldHVybjsKPiA+PiAgCX0K PiA+PiAgCj4gPj4gKwlkcm1fYXRvbWljX2hlbHBlcl9zd2FwX3N0YXRlKGRldiwgc3RhdGUpOwo+ ID4+ICsKPiA+PiArCS8qIHN3YXAgc3cvaHcgZHBsbCBzdGF0ZSAqLwo+ID4+ICsJaW50ZWxfYXRv bWljX2R1cGxpY2F0ZV9kcGxsX3N0YXRlKGRldl9wcml2LCBzaGFyZWRfZHBsbHMpOwo+ID4+ICsJ aW50ZWxfc2hhcmVkX2RwbGxfY29tbWl0KHN0YXRlKTsKPiA+PiArCW1lbWNweSh0b19pbnRlbF9h dG9taWNfc3RhdGUoc3RhdGUpLT5zaGFyZWRfZHBsbCwKPiA+PiArCSAgICAgICBzaGFyZWRfZHBs bHMsIHNpemVvZigqc2hhcmVkX2RwbGxzKSAqIGRldl9wcml2LT5udW1fc2hhcmVkX2RwbGwpOwo+ ID4gVGhpcyBpcyBpbW8gd2F5IHRvbyBtdWNoIG9wZW4tY29kaW5nIG9mIHN0dWZmIHRoYXQncyBh bHJlYWR5IHRoZXJlLiBXaGF0IEkKPiA+IGhhZCBpbiBtaW5kIGZvciBmb3JjZV9yZXN0b3JlIHdh cyBhIGdlbmVyaWMgaGVscGVyIHRvIGR1cGxpY2F0ZSBhbGwgdGhlCj4gPiBzdGF0ZSBvYmplY3Rz IGludG8gYSBkcm1fYXRvbWljX3N0YXRlLCB3aXRob3V0IGNhbGxpbmcgYW55IG9mIHRoZQo+ID4g LT5hdG9taWNfY2hlY2sgZnVuY3Rpb25zIG9yIGFueXRoaW5nLiBUaGVuIHRoZSBzZXF1ZW5jZSBm b3IgcmVzdG9yaW5nCj4gPiBzdGF0ZSB3b3VsZCBiZS4KPiA+Cj4gPiAxLiBzYXZlZF9zdGF0ZSA9 IGRybV9hdG9taWNfaGVscGVyX2R1cGxpY2F0ZV9zdGF0ZSgpCj4gPiAyLiBpbnRlbF9yZWFkb3V0 X2h3X3NhdGUoKSA8LSB0aGlzIHdvdWxkIGp1c3QgdXBkYXRlIC0+c3RhdGUgYW5kIHNhbml0aXpl Cj4gPiBpdC4KPiA+IDMuIGRybV9hdG9taWNfY29tbWl0KHNhdmVkX3N0YXRlKSB3cmFwcGVkIGlu IGEgV0FSTl9PTiB0byBtYWtlIHN1cmUgaXQKPiA+IGFsd2F5cyB3b3Jrcy4KPiBXZWxsLCBmb3Ig IWZvcmNlX3Jlc3RvcmUgd2Ugd2FudCB0byBkbyBhbiBpbml0aWFsIHNhbml0aXppbmcgbW9kZXNl dCB0b28sIGJ1dCB3aXRoIHRoZSBmdWxsIGRpc2FibGVkIHN0YXRlIGFzIHJlZmVyZW5jZSBwb2lu dC4KPiBJJ20gbm90IHN1cmUgZHVwZSBzdGF0ZSBmb2xsb3dlZCBieSBhIHN3YXAsIGlzIGRpZmZl cmVudCBmcm9tIHNhdmUgb2xkIHN0YXRlLCBhbmQgcmVhZCBvdXQgdG8gY3VycmVudCBzdGF0ZS4K CllvdSBhbHNvIGR1cGUgaW50ZXJuYWwgc3RhdGUgbGlrZSBkcGxscywgdGhhdCdzIHdoYXQgYSBo ZWxwZXItbGV2ZWwKZHVwbGljYXQgc3RhdGUgd291bGQgYXZvaWQuIEFuZCBpbW8gdGhhdCdzIGNs ZWFuZXIuIC0+YXRvbWljX2NoZWNrIHNob3VsZAp0aGVuIGdyYWIgYWxsIHRoZSBpbnRlcm5hbCBz dGF0ZXMgbmVlZGVkLCBpZiBhbnkgYXJlIG5lY2Vzc2FyeS4gVGhlIGdvYWwKcmVhbGx5IGlzIHRv IGF2b2lkIGFub3RoZXIgc3BlY2lhbCBjYXNlIHdpdGggdG9vIG11Y2gga25vd2xlZGdlIG9mIGk5 MTUKaW50ZXJuYWxzLCB3aGljaCBhdG9taWMgcmVhbGx5IHNob3VsZCBhbGxvdyB1cyB0byBkby4K LURhbmllbAotLSAKRGFuaWVsIFZldHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9y YXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu ZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9pbnRlbC1nZngK