From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH] drm/i915: Officially give up on seqno coherency Date: Tue, 23 Jun 2015 13:52:27 +0200 Message-ID: <20150623115227.GX25769@phenom.ffwll.local> References: <1434732184-27338-1-git-send-email-daniel.vetter@ffwll.ch> <1434741369-28932-1-git-send-email-daniel.vetter@ffwll.ch> <87381i20zu.fsf@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <87381i20zu.fsf@intel.com> Sender: stable-owner@vger.kernel.org To: Jani Nikula Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter , stable@vger.kernel.org List-Id: intel-gfx@lists.freedesktop.org On Tue, Jun 23, 2015 at 01:05:41PM +0300, Jani Nikula wrote: > On Fri, 19 Jun 2015, Daniel Vetter wrote: > > We've never figured out the magic trick to make irq vs. seqno > > updates coherent, only tricks to make it work. And since > > > > commit 094f9a54e35500739da185cdb78f2e92fc379458 > > Author: Chris Wilson > > Date: Wed Sep 25 17:34:55 2013 +0100 > > > > drm/i915: Fix __wait_seqno to use true infinite timeouts > > > > we automatically fall back to an irq augmented with polling scheme > > after the first missed interrupt. There's really nothing else we ca= n > > do, hence tune down the message to informational level. It's still > > useful for users in case it reliable preceedes a hard system hang. > > > > v2: Use NOTICE since it might be of value for bug reports (Chris). > > > > Cc: Mark Janes > > Cc: Chris Wilson > > Cc: stable@vger.kernel.org > > Signed-off-by: Daniel Vetter > > --- > > drivers/gpu/drm/i915/i915_irq.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915= /i915_irq.c > > index e6bb72dca3ff..5072fb49367e 100644 > > --- a/drivers/gpu/drm/i915/i915_irq.c > > +++ b/drivers/gpu/drm/i915/i915_irq.c > > @@ -2946,8 +2946,8 @@ static void i915_hangcheck_elapsed(struct wor= k_struct *work) > > /* Issue a wake-up to catch stuck h/w. */ > > if (!test_and_set_bit(ring->id, &dev_priv->gpu_error.missed_i= rq_rings)) { > > if (!(dev_priv->gpu_error.test_irq_rings & intel_ring_flag(r= ing))) > > - DRM_ERROR("Hangcheck timer elapsed... %s idle\n", > > - ring->name); > > + DRM_NOTICE("Hangcheck timer elapsed... %s idle\n", >=20 > drivers/gpu/drm/i915/i915_irq.c: In function =E2=80=98i915_hangcheck_= elapsed=E2=80=99: > drivers/gpu/drm/i915/i915_irq.c:2949:8: error: implicit declaration o= f function =E2=80=98DRM_NOTICE=E2=80=99 [-Werror=3Dimplicit-function-de= claration] > DRM_NOTICE("Hangcheck timer elapsed... %s idle\n", > ^ Embarassing. Can you pick up v1 instead please? -Daniel --=20 Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch