From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
DRI Development <dri-devel@lists.freedesktop.org>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH 00/11] [RFC] drm_for_each_* macros and list locking
Date: Wed, 24 Jun 2015 10:35:35 +0200 [thread overview]
Message-ID: <20150624083535.GV25769@phenom.ffwll.local> (raw)
In-Reply-To: <20150624074447.GU12403@nuc-i3427.alporthouse.com>
On Wed, Jun 24, 2015 at 08:44:47AM +0100, Chris Wilson wrote:
> On Tue, Jun 23, 2015 at 10:45:51PM +0200, Daniel Vetter wrote:
> > Hi all,
> >
> > Dave&I have been discussing connector hotplug and unplugging around DP MST and
> > if there's one thing that's clear it's that we don't even really know where all
> > the problems are. Hence first step is to figure that out. One of the bigger
> > items is walking the encoder/connector lists without appropriate locking to
> > protect against concurrent hotadd/removal of connectors.
> >
> > This patch series tries to untangle things a bit here. RFC since only lightly
> > tested and missing conversion of the radoen mst code to the new locking scheme.
> > I think rolling out the new macros for i915 should be done as a second step, to
> > avoid hitting too many WARN_ON ;-)
>
> Bah, I was hoping to see scru! :)
This is just to start figuring out how bad the situation is and who's all
affected. Later on we need to figure out how to properly protect the
connector/encoder list without just grabbing all kinds of locks in the
hotadd/remove code - stalling screen updates on the main screen just
because you plug something in tends to upset people.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-06-24 8:32 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-23 20:45 [PATCH 00/11] [RFC] drm_for_each_* macros and list locking Daniel Vetter
2015-06-23 20:45 ` [PATCH 01/11] drm: Simplify drm_for_each_legacy_plane arguments Daniel Vetter
2015-06-23 20:45 ` [PATCH 02/11] drm: Add modeset object iterators Daniel Vetter
2015-06-23 20:45 ` [PATCH 03/11] drm/probe-helper: Grab mode_config.mutex in poll_init/enable Daniel Vetter
2015-06-23 20:45 ` [PATCH 04/11] drm/fbdev-helper: Grab mode_config.mutex in drm_fb_helper_single_add_all_connectors Daniel Vetter
2015-06-23 20:45 ` [PATCH 05/11] drm: Check locking in drm_for_each_encoder/connector Daniel Vetter
2015-06-23 20:45 ` [PATCH 06/11] drm/i915: Use drm_for_each_fb in i915_debugfs.c Daniel Vetter
2015-06-23 20:45 ` [PATCH 07/11] drm: Check locking in drm_for_each_fb Daniel Vetter
2015-06-23 20:45 ` [PATCH 08/11] drm/i915: Take all modeset locks for DP MST hotplug Daniel Vetter
2015-06-23 20:46 ` [PATCH 09/11] drm: Amend connector/encoder list locking rules Daniel Vetter
2015-06-24 7:57 ` Chris Wilson
2015-06-24 8:36 ` Daniel Vetter
2015-06-23 20:46 ` [PATCH 10/11] drm: Roll out drm_for_each_connector more Daniel Vetter
2015-06-23 20:46 ` [PATCH 11/11] drm: Roll out drm_for_each_{plane, crtc, encoder} Daniel Vetter
2015-06-29 3:41 ` shuang.he
2015-06-24 7:44 ` [PATCH 00/11] [RFC] drm_for_each_* macros and list locking Chris Wilson
2015-06-24 8:35 ` Daniel Vetter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150624083535.GV25769@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox