Re: [PATCH v2] drm/i915/skl: Buffer translation improvements

David Weinehall
2015-06-30T10:27:38Z

On Mon, Jun 29, 2015 at 06:12:54PM +0200, Daniel Vetter wrote:
> On Mon, Jun 29, 2015 at 01:35:06PM +0300, Antti Koskipää wrote:
> > Looks fine to me.
> >
> > Reviewed-by: Antti Koskipää <antti.koskipaa@linux.intel.com>
> >
> >
> > On 06/25/2015 11:11 AM, David Weinehall wrote:
> > > This patch adds support for 0.85V VccIO on Skylake Y,
> > > separate buffer translation tables for Skylake U,
> > > and support for I_boost for the entries that needs this.
> > >
> > > Changes in v2:
> > > * Refactored the code a bit to move all DDI signal level setup to
> > > intel_ddi.c
>
> For next time around please split out refactoring from actual code
> changes, makes it a pain to review. And if this blows up in a
> regression that's really annoying. Also please head checkpatch's
> suggestions a bit more, I fixed that up when applying.

OK, noted.

Kind regards, David