public inbox for intel-gfx@lists.freedesktop.org
 help / color / mirror / Atom feed
From: Damien Lespiau <damien.lespiau@intel.com>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
	Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915/skl: Skip remaining dividers when deviation is 0
Date: Fri, 26 Jun 2015 18:23:27 +0100	[thread overview]
Message-ID: <20150626172327.GA31959@strange.ger.corp.intel.com> (raw)
In-Reply-To: <CA+gsUGSABP4G2-QBWHrOmW9OA_9ubZNbejnGUGeT_zBkwfA2eQ@mail.gmail.com>

On Fri, Jun 26, 2015 at 02:18:39PM -0300, Paulo Zanoni wrote:
> > @@ -1311,13 +1320,15 @@ skl_ddi_calculate_wrpll(int clock /* in Hz */,
> >                                 unsigned int p = dividers[d].list[i];
> >                                 uint64_t dco_freq = p * afe_clock;
> >
> > -                               skl_wrpll_try_divider(&ctx,
> > -                                                     dco_central_freq[dco],
> > -                                                     dco_freq,
> > -                                                     p);
> > +                               if (skl_wrpll_try_divider(&ctx,
> > +                                                         dco_central_freq[dco],
> > +                                                         dco_freq,
> > +                                                         p))
> > +                                       goto skip_remaining_dividers;
> 
> Bikeshed: instead of touching skl_wrpll_try_divider(), you could just:
> 
> if (ctx.min_deviation == 0) goto skip_remaining_dividers;
> 
> That would keep the logic of the optimization restricted to this
> function. IMHO, much simpler.
> 
> With or without changes: Reviewed-by: Paulo Zanoni <paulo.r.zanoni@intel.com>

I like that, v2 it is!

-- 
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx

  reply	other threads:[~2015-06-26 17:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-25 17:08 [PATCH] drm/i915/skl: Skip remaining dividers when deviation is 0 Damien Lespiau
2015-06-26 17:18 ` Paulo Zanoni
2015-06-26 17:23   ` Damien Lespiau [this message]
2015-06-26 17:34   ` [PATCH v2] " Damien Lespiau
2015-06-26 17:42     ` Daniel Vetter
2015-06-28 19:15     ` shuang.he
2015-06-29  4:57 ` [PATCH] " shuang.he

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150626172327.GA31959@strange.ger.corp.intel.com \
    --to=damien.lespiau@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=paulo.r.zanoni@intel.com \
    --cc=przanoni@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox