From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH] drm/i915: Fix failure paths around initial
 fbdev allocation
Date: Mon, 29 Jun 2015 16:39:25 +0200
Message-ID: <20150629143925.GA7955@wunner.de>
References: <1434365392-19808-1-git-send-email-tvrtko.ursulin@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mailout3.hostsharing.net (mailout3.hostsharing.net
 [176.9.242.54])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 1267E6E18F
 for <Intel-gfx@lists.freedesktop.org>; Mon, 29 Jun 2015 07:39:26 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1434365392-19808-1-git-send-email-tvrtko.ursulin@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

SGksCgpPbiBNb24sIEp1biAxNSwgMjAxNSBhdCAxMTo0OTo1MkFNICswMTAwLCBUdnJ0a28gVXJz
dWxpbiB3cm90ZToKPiBGcm9tOiBUdnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwu
Y29tPgo+IAo+IFdlIGhhZCB0d28gZmFpbHVyZSBtb2RlcyBoZXJlOgo+IAo+IDEuCj4gRGVhZGxv
Y2sgaW4gaW50ZWxmYl9hbGxvYyBmYWlsdXJlIHBhdGggd2hlcmUgaXQgY2FsbHMgZHJtX2ZyYW1l
YnVmZmVyX3JlbW92ZSwKPiB3aGljaCBncmFicyB0aGUgc3RydWN0IG11dGV4IGFuZCBpbnRlbGZi
X2NyZWF0ZSAoY2FsbGVyIG9mIGludGVsZmJfYWxsb2MpIHdhcwo+IGFscmVhZHkgaG9sZGluZyBp
dC4KCnMvaW50ZWxmYl9hbGxvYy9pbnRlbGZiX2NyZWF0ZS8Kcy8oY2FsbGVyIG9mIGludGVsZmJf
YWxsb2MpLy8KCgo+IAo+IDIuCj4gRG91YmxlIHVucmVmZXJlbmNlIG9uIHRoZSBvYmplY3QgaWYg
X19pbnRlbF9mcmFtZWJ1ZmZlcl9jcmVhdGUgZmFpbHMgc2luY2UKPiBib3RoIGl0IGFuZCB0aGUg
Y2FsbGVyIChpbnRlbGZiX2FsbG9jKSBkbyB0aGUgdW5yZWZlcmVuY2UuCj4gCj4gU2lnbmVkLW9m
Zi1ieTogVHZydGtvIFVyc3VsaW4gPHR2cnRrby51cnN1bGluQGludGVsLmNvbT4KPiBDYzogQ2hy
aXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzD
pCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+CgpGaXhlczogNjBhNWNhMDE1ZmZkMmFh
Y2ZlNTY3NGI1YTQwMWNkMmEzNzE1OWUwNwpSZXBvcnRlZC1CeTogTHVrYXMgV3VubmVyIDxsdWth
c0B3dW5uZXIuZGU+CgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJkZXYu
YyB8IDIxICsrKysrKysrKysrKystLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTMgaW5zZXJ0
aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJt
L2k5MTUvaW50ZWxfZmJkZXYuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMK
PiBpbmRleCA2MzcyY2ZjLi5iOTk4ZjY5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2ZiZGV2LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRl
di5jCj4gQEAgLTE0MSw3ICsxNDEsNyBAQCBzdGF0aWMgaW50IGludGVsZmJfYWxsb2Moc3RydWN0
IGRybV9mYl9oZWxwZXIgKmhlbHBlciwKPiAgewo+ICAJc3RydWN0IGludGVsX2ZiZGV2ICppZmJk
ZXYgPQo+ICAJCWNvbnRhaW5lcl9vZihoZWxwZXIsIHN0cnVjdCBpbnRlbF9mYmRldiwgaGVscGVy
KTsKPiAtCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiOwo+ICsJc3RydWN0IGRybV9mcmFtZWJ1
ZmZlciAqZmIgPSBOVUxMOwo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGhlbHBlci0+ZGV2
Owo+ICAJc3RydWN0IGRybV9tb2RlX2ZiX2NtZDIgbW9kZV9jbWQgPSB7fTsKPiAgCXN0cnVjdCBk
cm1faTkxNV9nZW1fb2JqZWN0ICpvYmo7Cj4gQEAgLTE1OSw2ICsxNTksOCBAQCBzdGF0aWMgaW50
IGludGVsZmJfYWxsb2Moc3RydWN0IGRybV9mYl9oZWxwZXIgKmhlbHBlciwKPiAgCW1vZGVfY21k
LnBpeGVsX2Zvcm1hdCA9IGRybV9tb2RlX2xlZ2FjeV9mYl9mb3JtYXQoc2l6ZXMtPnN1cmZhY2Vf
YnBwLAo+ICAJCQkJCQkJICBzaXplcy0+c3VyZmFjZV9kZXB0aCk7Cj4gIAo+ICsJbXV0ZXhfbG9j
aygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+ICsKPiAgCXNpemUgPSBtb2RlX2NtZC5waXRjaGVzWzBd
ICogbW9kZV9jbWQuaGVpZ2h0Owo+ICAJc2l6ZSA9IFBBR0VfQUxJR04oc2l6ZSk7Cj4gIAlvYmog
PSBpOTE1X2dlbV9vYmplY3RfY3JlYXRlX3N0b2xlbihkZXYsIHNpemUpOwo+IEBAIC0xNzIsOCAr
MTc0LDkgQEAgc3RhdGljIGludCBpbnRlbGZiX2FsbG9jKHN0cnVjdCBkcm1fZmJfaGVscGVyICpo
ZWxwZXIsCj4gIAo+ICAJZmIgPSBfX2ludGVsX2ZyYW1lYnVmZmVyX2NyZWF0ZShkZXYsICZtb2Rl
X2NtZCwgb2JqKTsKPiAgCWlmIChJU19FUlIoZmIpKSB7Cj4gKwkJLyogRHJvcHMgb2JqZWN0IHJl
ZmVyZW5jZSBvbiBmYWlsdXJlLiAqLwo+ICAJCXJldCA9IFBUUl9FUlIoZmIpOwo+IC0JCWdvdG8g
b3V0X3VucmVmOwo+ICsJCWdvdG8gb3V0Owo+ICAJfQo+ICAKPiAgCS8qIEZsdXNoIGV2ZXJ5dGhp
bmcgb3V0LCB3ZSdsbCBiZSBkb2luZyBHVFQgb25seSBmcm9tIG5vdyBvbiAqLwo+IEBAIC0xODMs
MTUgKzE4NiwxOCBAQCBzdGF0aWMgaW50IGludGVsZmJfYWxsb2Moc3RydWN0IGRybV9mYl9oZWxw
ZXIgKmhlbHBlciwKPiAgCQlnb3RvIG91dF9mYjsKPiAgCX0KPiAgCj4gKwltdXRleF91bmxvY2so
JmRldi0+c3RydWN0X211dGV4KTsKPiArCj4gIAlpZmJkZXYtPmZiID0gdG9faW50ZWxfZnJhbWVi
dWZmZXIoZmIpOwo+ICAKPiAgCXJldHVybiAwOwo+ICAKPiAgb3V0X2ZiOgo+IC0JZHJtX2ZyYW1l
YnVmZmVyX3JlbW92ZShmYik7Cj4gLW91dF91bnJlZjoKPiAgCWRybV9nZW1fb2JqZWN0X3VucmVm
ZXJlbmNlKCZvYmotPmJhc2UpOwo+ICBvdXQ6Cj4gKwltdXRleF91bmxvY2soJmRldi0+c3RydWN0
X211dGV4KTsKPiArCWlmIChmYikKPiArCQlkcm1fZnJhbWVidWZmZXJfcmVtb3ZlKGZiKTsKCkht
LCB0aGUgb3JkZXIgb2YgZHJtX2dlbV9vYmplY3RfdW5yZWZlcmVuY2UoKSBhbmQgZHJtX2ZyYW1l
YnVmZmVyX3JlbW92ZSgpCmlzIHJldmVyc2VkIG5vdywgY291bGQgdGhpcyBjYXVzZSBhbnkgaXNz
dWVzPwoKQXBhcnQgZnJvbSB0aGF0LAoKUmV2aWV3ZWQtQnk6IEx1a2FzIFd1bm5lciA8bHVrYXNA
d3VubmVyLmRlPgoKSSB3aWxsIGFsc28gdGVzdCB0aGUgcGF0Y2ggYW5kIHJlcG9ydCBiYWNrIGlu
IGEgYml0LgoKVGhhbmtzIGEgbG90LAoKTHVrYXMKCgo+ICAJcmV0dXJuIHJldDsKPiAgfQo+ICAK
PiBAQCAtMjA5LDggKzIxNSw2IEBAIHN0YXRpYyBpbnQgaW50ZWxmYl9jcmVhdGUoc3RydWN0IGRy
bV9mYl9oZWxwZXIgKmhlbHBlciwKPiAgCWludCBzaXplLCByZXQ7Cj4gIAlib29sIHByZWFsbG9j
ID0gZmFsc2U7Cj4gIAo+IC0JbXV0ZXhfbG9jaygmZGV2LT5zdHJ1Y3RfbXV0ZXgpOwo+IC0KPiAg
CWlmIChpbnRlbF9mYiAmJgo+ICAJICAgIChzaXplcy0+ZmJfd2lkdGggPiBpbnRlbF9mYi0+YmFz
ZS53aWR0aCB8fAo+ICAJICAgICBzaXplcy0+ZmJfaGVpZ2h0ID4gaW50ZWxfZmItPmJhc2UuaGVp
Z2h0KSkgewo+IEBAIC0yMjUsNyArMjI5LDcgQEAgc3RhdGljIGludCBpbnRlbGZiX2NyZWF0ZShz
dHJ1Y3QgZHJtX2ZiX2hlbHBlciAqaGVscGVyLAo+ICAJCURSTV9ERUJVR19LTVMoIm5vIEJJT1Mg
ZmIsIGFsbG9jYXRpbmcgYSBuZXcgb25lXG4iKTsKPiAgCQlyZXQgPSBpbnRlbGZiX2FsbG9jKGhl
bHBlciwgc2l6ZXMpOwo+ICAJCWlmIChyZXQpCj4gLQkJCWdvdG8gb3V0X3VubG9jazsKPiArCQkJ
cmV0dXJuIHJldDsKPiAgCQlpbnRlbF9mYiA9IGlmYmRldi0+ZmI7Cj4gIAl9IGVsc2Ugewo+ICAJ
CURSTV9ERUJVR19LTVMoInJlLXVzaW5nIEJJT1MgZmJcbiIpOwo+IEBAIC0yMzcsNiArMjQxLDgg
QEAgc3RhdGljIGludCBpbnRlbGZiX2NyZWF0ZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqaGVscGVy
LAo+ICAJb2JqID0gaW50ZWxfZmItPm9iajsKPiAgCXNpemUgPSBvYmotPmJhc2Uuc2l6ZTsKPiAg
Cj4gKwltdXRleF9sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4gKwo+ICAJaW5mbyA9IGZyYW1l
YnVmZmVyX2FsbG9jKDAsICZkZXYtPnBkZXYtPmRldik7Cj4gIAlpZiAoIWluZm8pIHsKPiAgCQly
ZXQgPSAtRU5PTUVNOwo+IEBAIC0zMDcsNyArMzEzLDYgQEAgc3RhdGljIGludCBpbnRlbGZiX2Ny
ZWF0ZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqaGVscGVyLAo+ICBvdXRfdW5waW46Cj4gIAlpOTE1
X2dlbV9vYmplY3RfZ2d0dF91bnBpbihvYmopOwo+ICAJZHJtX2dlbV9vYmplY3RfdW5yZWZlcmVu
Y2UoJm9iai0+YmFzZSk7Cj4gLW91dF91bmxvY2s6Cj4gIAltdXRleF91bmxvY2soJmRldi0+c3Ry
dWN0X211dGV4KTsKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiAtLSAKPiAyLjQuMgo+IAo+IF9fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gSW50ZWwtZ2Z4IG1h
aWxpbmcgbGlzdAo+IEludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBodHRwOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cl9fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxp
c3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0
b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==