Re: [PATCH] drm/i915: Migrate stolen objects before hibernation

Chris Wilson
2015-06-30T12:37:13Z

On Tue, Jun 30, 2015 at 01:54:14PM +0200, Daniel Vetter wrote:
> Ok, reality still matches with my expectations then. I'll wish for an igt
> and your fix extracted ;-)
>
> Without looking, do you just lock-drop and then retry (and block in the
> interruptible acquisition of dev->struct_mutex)?

It will have to change behaviour with TDR and partial resets, but the
obversation is that with a total GPU reset pending, the current contents
of the active bo are irrelevant. The reset will clobber state and it
doesn't matter if that happens before this ioctl or the next. Therefore
there is only place (waiting for ring space) where it matters that a
reset is pending, and moving the special case handling there is much
easier than adding the recovery protocol everywhere.