From: David Weinehall <david.weinehall@linux.intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/i915/skl: Buffer translation improvements
Date: Tue, 30 Jun 2015 13:27:00 +0300 [thread overview]
Message-ID: <20150630102700.GS14570@boom> (raw)
In-Reply-To: <20150629161254.GZ30960@phenom.ffwll.local>
On Mon, Jun 29, 2015 at 06:12:54PM +0200, Daniel Vetter wrote:
> On Mon, Jun 29, 2015 at 01:35:06PM +0300, Antti Koskipää wrote:
> > Looks fine to me.
> >
> > Reviewed-by: Antti Koskipää <antti.koskipaa@linux.intel.com>
> >
> >
> > On 06/25/2015 11:11 AM, David Weinehall wrote:
> > > This patch adds support for 0.85V VccIO on Skylake Y,
> > > separate buffer translation tables for Skylake U,
> > > and support for I_boost for the entries that needs this.
> > >
> > > Changes in v2:
> > > * Refactored the code a bit to move all DDI signal level setup to
> > > intel_ddi.c
>
> For next time around please split out refactoring from actual code
> changes, makes it a pain to review. And if this blows up in a
> regression that's really annoying. Also please head checkpatch's
> suggestions a bit more, I fixed that up when applying.
OK, noted.
Kind regards, David
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
prev parent reply other threads:[~2015-06-30 10:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-18 9:50 [PATCH] drm/i915/skl: Buffer translation improvements David Weinehall
2015-06-18 10:10 ` Chris Wilson
2015-06-18 10:47 ` David Weinehall
2015-06-18 10:59 ` Chris Wilson
2015-06-23 10:28 ` David Weinehall
2015-06-25 8:09 ` David Weinehall
2015-06-18 15:05 ` Daniel Vetter
2015-06-23 10:47 ` David Weinehall
2015-06-23 11:12 ` David Weinehall
2015-06-23 12:07 ` Daniel Vetter
2015-06-24 4:47 ` Jindal, Sonika
2015-06-25 10:18 ` David Weinehall
2015-06-25 8:11 ` [PATCH v2] " David Weinehall
2015-06-29 10:35 ` Antti Koskipää
2015-06-29 16:12 ` Daniel Vetter
2015-06-30 10:27 ` David Weinehall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150630102700.GS14570@boom \
--to=david.weinehall@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox