Re: [PATCH 1/6] drm/i915/skl: Print the DMC firmware status in debugfs

[Damien Lespiau <damien.lespiau@intel.com>]

On Wed, Jul 01, 2015 at 03:16:24PM +0200, Daniel Vetter wrote:
> On Tue, Jun 30, 2015 at 07:28:54PM +0100, Damien Lespiau wrote:
> > Create a new debufs file for it, we'll have a few more things to add
> > there.
> > 
> > Signed-off-by: Damien Lespiau <damien.lespiau@intel.com>
> > ---
> >  drivers/gpu/drm/i915/i915_debugfs.c | 22 ++++++++++++++++++++++
> >  1 file changed, 22 insertions(+)
> > 
> > diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> > index 31d8768..df35448 100644
> > --- a/drivers/gpu/drm/i915/i915_debugfs.c
> > +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> > @@ -2598,6 +2598,27 @@ static int i915_power_domain_info(struct seq_file *m, void *unused)
> >  	return 0;
> >  }
> >  
> > +static int i915_dmc_info(struct seq_file *m, void *unused)
> > +{
> > +
> > +	struct drm_info_node *node = m->private;
> > +	struct drm_device *dev = node->minor->dev;
> > +	struct drm_i915_private *dev_priv = dev->dev_private;
> > +	static const char *csr_state_str[] = { "unknown", "loaded", "error" };
> > +	enum csr_state csr_state;
> > +
> > +
> > +	if (!HAS_CSR(dev)) {
> > +		seq_puts(m, "not supported\n");
> > +		return 0;
> > +	}
> > +
> > +	csr_state = intel_csr_load_status_get(dev_priv);
> 
> This will disappear after the dmc loader rework.

Are you suggesting that we shouldn't touch that code until someone
reworks it? (seems fairly unbounded to me).

-- 
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx