From mboxrd@z Thu Jan  1 00:00:00 1970
From: Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH] drm/i915: Fix failure paths around initial
 fbdev allocation
Date: Thu, 2 Jul 2015 15:23:52 +0200
Message-ID: <20150702132352.GA3087@wunner.de>
References: <1435655187-8769-1-git-send-email-tvrtko.ursulin@linux.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mailout2.hostsharing.net (mailout2.hostsharing.net
 [83.223.90.233])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 37A3F6E56D
 for <Intel-gfx@lists.freedesktop.org>; Thu,  2 Jul 2015 06:23:49 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1435655187-8769-1-git-send-email-tvrtko.ursulin@linux.intel.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>
Cc: Intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

SGksCgpub3Qgc3VyZSBpZiBhbm90aGVyIHJlYWN0aW9uIGZyb20gbWUgaXMgcmVxdWlyZWQsIGJ1
dCBpbiBjYXNlIHRoZXJlIGlzOgpUaGUgcGF0Y2ggYXMgcXVvdGVkIGJlbG93IExHVE0gbm93LCBz
byB1bmxlc3MgVmlsbGUgdmV0b2VzIGJlY2F1c2Ugb2YKaGlzIHN1Z2dlc3Rpb24gKHNlZSBiZWxv
dykgSSB0aGluayB0aGlzIGlzIHJlYWR5IGZvciBpbmNsdXNpb24gaW4gNC4yLgoKVGhhbmtzLAoK
THVrYXMKCk9uIFR1ZSwgSnVuIDMwLCAyMDE1IGF0IDEwOjA2OjI3QU0gKzAxMDAsIFR2cnRrbyBV
cnN1bGluIHdyb3RlOgo+IEZyb206IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRl
bC5jb20+Cj4gCj4gV2UgaGFkIHRocmVlIGZhaWx1cmUgbW9kZXMgaGVyZToKPiAKPiAxLgo+IERl
YWRsb2NrIGluIGludGVsZmJfYWxsb2MgZmFpbHVyZSBwYXRoIHdoZXJlIGl0IGNhbGxzCj4gZHJt
X2ZyYW1lYnVmZmVyX3JlbW92ZSwgd2hpY2ggZ3JhYnMgdGhlIHN0cnVjdCBtdXRleCBhbmQgaW50
ZWxmYl9jcmVhdGUKPiAoY2FsbGVyIG9mIGludGVsZmJfYWxsb2MpIHdhcyBhbHJlYWR5IGhvbGRp
bmcgaXQuCj4gCj4gMi4KPiBEb3VibGUgdW5yZWZlcmVuY2Ugb24gdGhlIG9iamVjdCBpZiBfX2lu
dGVsX2ZyYW1lYnVmZmVyX2NyZWF0ZSBmYWlscwo+IHNpbmNlIGJvdGggaXQgYW5kIHRoZSBjYWxs
ZXIgKGludGVsZmJfYWxsb2MpIGRvIHRoZSB1bnJlZmVyZW5jZS4KPiAKPiAzLgo+IERlYWRsb2Nr
IGluIGludGVsZmJfY3JlYXRlIGZhaWx1cmUgcGF0aCB3aGVyZSBpdCBjYWxscwo+IGRybV9mcmFt
ZWJ1ZmZlcl91bnJlZmVyZW5jZSwgd2hpY2ggZ3JhYnMgdGhlIHN0cnVjdCBtdXRleCBhbmQKPiBp
bnRlbGZiX2NyZWF0ZSB3YXMgYWxyZWFkeSBob2xkaW5nIGl0Lgo+IAo+IHYyOgo+ICAgICogUmVm
b3JtYXQgY29tbWl0IG1zZyB0byA3MiBjaGFycy4gKEx1a2FzIFd1bm5lcikKPiAgICAqIEFkZGVk
IHRoaXJkIGZhaWx1cmUgbW9kZS4gKEx1a2FzIFd1bm5lcikKPiAKPiBTaWduZWQtb2ZmLWJ5OiBU
dnJ0a28gVXJzdWxpbiA8dHZydGtvLnVyc3VsaW5AaW50ZWwuY29tPgo+IEZpeGVzOiA2MGE1Y2Ew
MTVmZmQyYWFjZmU1Njc0YjVhNDAxY2QyYTM3MTU5ZTA3Cj4gUmVwb3J0ZWQtQnk6IEx1a2FzIFd1
bm5lciA8bHVrYXNAd3VubmVyLmRlPgo+IFRlc3RlZC1CeTogTHVrYXMgV3VubmVyIDxsdWthc0B3
dW5uZXIuZGU+Cj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVrPgo+
IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+IENj
OiBMdWthcyBXdW5uZXIgPGx1a2FzQHd1bm5lci5kZT4KPiAtLS0KPiBWaWxsZSwgeW91IHN1Z2dl
c3RlZCBzb21lIGNoYW5nZXMgZWFybGllcjsKPiAKPiAiIiIKPiBJIHN1Z2dlc3QgcmVtb3Zpbmcg
dGhlIHVucmVmIGZyb20gX19pbnRlbF9mcmFtZWJ1ZmZlcl9jcmVhdGUoKS4KPiAiIiIKPiAKPiBE
byB5b3UgdmlldyB0aGF0IGFzIGFuIGltcHJvdmVtZW50IGluIGNvZGUgY2xhcml0eS9vcmdhbmlz
YXRpb24sCj4gb3IgeW91IHRoaW5rIG15IHZlcnNpb24gaXMgYWN0dWFsbHkgd3JvbmcgZm9yIHNv
bWUgcmVhc29uPwo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9mYmRldi5jIHwg
MjEgKysrKysrKysrKysrKy0tLS0tLS0tCj4gIDEgZmlsZSBjaGFuZ2VkLCAxMyBpbnNlcnRpb25z
KCspLCA4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF9mYmRldi5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZmJkZXYuYwo+IGlu
ZGV4IDJhMTcyNGUuLjExODQyMGIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUv
aW50ZWxfZmJkZXYuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2ZiZGV2LmMK
PiBAQCAtMTQxLDcgKzE0MSw3IEBAIHN0YXRpYyBpbnQgaW50ZWxmYl9hbGxvYyhzdHJ1Y3QgZHJt
X2ZiX2hlbHBlciAqaGVscGVyLAo+ICB7Cj4gIAlzdHJ1Y3QgaW50ZWxfZmJkZXYgKmlmYmRldiA9
Cj4gIAkJY29udGFpbmVyX29mKGhlbHBlciwgc3RydWN0IGludGVsX2ZiZGV2LCBoZWxwZXIpOwo+
IC0Jc3RydWN0IGRybV9mcmFtZWJ1ZmZlciAqZmI7Cj4gKwlzdHJ1Y3QgZHJtX2ZyYW1lYnVmZmVy
ICpmYiA9IE5VTEw7Cj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2ID0gaGVscGVyLT5kZXY7Cj4g
IAlzdHJ1Y3QgZHJtX21vZGVfZmJfY21kMiBtb2RlX2NtZCA9IHt9Owo+ICAJc3RydWN0IGRybV9p
OTE1X2dlbV9vYmplY3QgKm9iajsKPiBAQCAtMTU5LDYgKzE1OSw4IEBAIHN0YXRpYyBpbnQgaW50
ZWxmYl9hbGxvYyhzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqaGVscGVyLAo+ICAJbW9kZV9jbWQucGl4
ZWxfZm9ybWF0ID0gZHJtX21vZGVfbGVnYWN5X2ZiX2Zvcm1hdChzaXplcy0+c3VyZmFjZV9icHAs
Cj4gIAkJCQkJCQkgIHNpemVzLT5zdXJmYWNlX2RlcHRoKTsKPiAgCj4gKwltdXRleF9sb2NrKCZk
ZXYtPnN0cnVjdF9tdXRleCk7Cj4gKwo+ICAJc2l6ZSA9IG1vZGVfY21kLnBpdGNoZXNbMF0gKiBt
b2RlX2NtZC5oZWlnaHQ7Cj4gIAlzaXplID0gUEFHRV9BTElHTihzaXplKTsKPiAgCW9iaiA9IGk5
MTVfZ2VtX29iamVjdF9jcmVhdGVfc3RvbGVuKGRldiwgc2l6ZSk7Cj4gQEAgLTE3Miw4ICsxNzQs
OSBAQCBzdGF0aWMgaW50IGludGVsZmJfYWxsb2Moc3RydWN0IGRybV9mYl9oZWxwZXIgKmhlbHBl
ciwKPiAgCj4gIAlmYiA9IF9faW50ZWxfZnJhbWVidWZmZXJfY3JlYXRlKGRldiwgJm1vZGVfY21k
LCBvYmopOwo+ICAJaWYgKElTX0VSUihmYikpIHsKPiArCQkvKiBEcm9wcyBvYmplY3QgcmVmZXJl
bmNlIG9uIGZhaWx1cmUuICovCj4gIAkJcmV0ID0gUFRSX0VSUihmYik7Cj4gLQkJZ290byBvdXRf
dW5yZWY7Cj4gKwkJZ290byBvdXQ7Cj4gIAl9Cj4gIAo+ICAJLyogRmx1c2ggZXZlcnl0aGluZyBv
dXQsIHdlJ2xsIGJlIGRvaW5nIEdUVCBvbmx5IGZyb20gbm93IG9uICovCj4gQEAgLTE4MywxNSAr
MTg2LDE4IEBAIHN0YXRpYyBpbnQgaW50ZWxmYl9hbGxvYyhzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAq
aGVscGVyLAo+ICAJCWdvdG8gb3V0X2ZiOwo+ICAJfQo+ICAKPiArCW11dGV4X3VubG9jaygmZGV2
LT5zdHJ1Y3RfbXV0ZXgpOwo+ICsKPiAgCWlmYmRldi0+ZmIgPSB0b19pbnRlbF9mcmFtZWJ1ZmZl
cihmYik7Cj4gIAo+ICAJcmV0dXJuIDA7Cj4gIAo+ICBvdXRfZmI6Cj4gLQlkcm1fZnJhbWVidWZm
ZXJfcmVtb3ZlKGZiKTsKPiAtb3V0X3VucmVmOgo+ICAJZHJtX2dlbV9vYmplY3RfdW5yZWZlcmVu
Y2UoJm9iai0+YmFzZSk7Cj4gIG91dDoKPiArCW11dGV4X3VubG9jaygmZGV2LT5zdHJ1Y3RfbXV0
ZXgpOwo+ICsJaWYgKGZiKQo+ICsJCWRybV9mcmFtZWJ1ZmZlcl9yZW1vdmUoZmIpOwo+ICAJcmV0
dXJuIHJldDsKPiAgfQo+ICAKPiBAQCAtMjA5LDggKzIxNSw2IEBAIHN0YXRpYyBpbnQgaW50ZWxm
Yl9jcmVhdGUoc3RydWN0IGRybV9mYl9oZWxwZXIgKmhlbHBlciwKPiAgCWludCBzaXplLCByZXQ7
Cj4gIAlib29sIHByZWFsbG9jID0gZmFsc2U7Cj4gIAo+IC0JbXV0ZXhfbG9jaygmZGV2LT5zdHJ1
Y3RfbXV0ZXgpOwo+IC0KPiAgCWlmIChpbnRlbF9mYiAmJgo+ICAJICAgIChzaXplcy0+ZmJfd2lk
dGggPiBpbnRlbF9mYi0+YmFzZS53aWR0aCB8fAo+ICAJICAgICBzaXplcy0+ZmJfaGVpZ2h0ID4g
aW50ZWxfZmItPmJhc2UuaGVpZ2h0KSkgewo+IEBAIC0yMjUsNyArMjI5LDcgQEAgc3RhdGljIGlu
dCBpbnRlbGZiX2NyZWF0ZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqaGVscGVyLAo+ICAJCURSTV9E
RUJVR19LTVMoIm5vIEJJT1MgZmIsIGFsbG9jYXRpbmcgYSBuZXcgb25lXG4iKTsKPiAgCQlyZXQg
PSBpbnRlbGZiX2FsbG9jKGhlbHBlciwgc2l6ZXMpOwo+ICAJCWlmIChyZXQpCj4gLQkJCWdvdG8g
b3V0X3VubG9jazsKPiArCQkJcmV0dXJuIHJldDsKPiAgCQlpbnRlbF9mYiA9IGlmYmRldi0+ZmI7
Cj4gIAl9IGVsc2Ugewo+ICAJCURSTV9ERUJVR19LTVMoInJlLXVzaW5nIEJJT1MgZmJcbiIpOwo+
IEBAIC0yMzcsNiArMjQxLDggQEAgc3RhdGljIGludCBpbnRlbGZiX2NyZWF0ZShzdHJ1Y3QgZHJt
X2ZiX2hlbHBlciAqaGVscGVyLAo+ICAJb2JqID0gaW50ZWxfZmItPm9iajsKPiAgCXNpemUgPSBv
YmotPmJhc2Uuc2l6ZTsKPiAgCj4gKwltdXRleF9sb2NrKCZkZXYtPnN0cnVjdF9tdXRleCk7Cj4g
Kwo+ICAJaW5mbyA9IGZyYW1lYnVmZmVyX2FsbG9jKDAsICZkZXYtPnBkZXYtPmRldik7Cj4gIAlp
ZiAoIWluZm8pIHsKPiAgCQlyZXQgPSAtRU5PTUVNOwo+IEBAIC0zMDcsNyArMzEzLDYgQEAgc3Rh
dGljIGludCBpbnRlbGZiX2NyZWF0ZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqaGVscGVyLAo+ICBv
dXRfdW5waW46Cj4gIAlpOTE1X2dlbV9vYmplY3RfZ2d0dF91bnBpbihvYmopOwo+ICAJZHJtX2dl
bV9vYmplY3RfdW5yZWZlcmVuY2UoJm9iai0+YmFzZSk7Cj4gLW91dF91bmxvY2s6Cj4gIAltdXRl
eF91bmxvY2soJmRldi0+c3RydWN0X211dGV4KTsKPiAgCXJldHVybiByZXQ7Cj4gIH0KPiAtLSAK
PiAyLjQuMgo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
XwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK
aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=