From: Daniel Vetter <daniel@ffwll.ch>
To: Daniel Stone <daniels@collabora.com>
Cc: John Hunter <zhaojunwang@pku.edu.cn>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>,
Daniel Vetter <daniel.vetter@intel.com>
Subject: Re: [PATCH] drm/crtc-helper: Fixup error handling in drm_helper_crtc_mode_set
Date: Thu, 2 Jul 2015 16:29:10 +0200 [thread overview]
Message-ID: <20150702142910.GD23343@phenom.ffwll.local> (raw)
In-Reply-To: <4C658DEE-AEB2-474D-BB43-FF67DD542DBA@collabora.com>
On Thu, Jul 02, 2015 at 02:27:30PM +0100, Daniel Stone wrote:
> Hi,
>
> > On 2 Jul 2015, at 2:16 pm, Daniel Vetter <daniel.vetter@ffwll.ch> wrote:
> >
> > In
> >
> > commit 9f658b7b62e7aefc1ee067136126eca3f58cabfd
> > Author: Daniel Stone <daniels@collabora.com>
> > Date: Fri May 22 13:34:45 2015 +0100
> >
> > drm/crtc_helper: Replace open-coded CRTC state helpers
> >
> > error handling code was broken, resulting in the first path not being
> > checked correctly. Fix this by using the same pattern as in the
> > transitional plane helper function drm_plane_helper_update.
> >
> > v2: Simplify the cleanup code while at it too.
> >
> > v3: After some debugging with John we realized that the above patch
> > from Daniel also accidentally removed the if (crtc_state) check. This
> > is legal when transitioning to atomic, when the initial state reset
> > isn't all wired up yet properly. Reinstate that check to fix the bug
> > John has hit.
>
> Still misses the crtc_state->crtc assignment in the kzalloc path.
Yeah I was random-walking over that code badly. Please disregard v4 too.
I'll follow up with a patch to use the reset helper if crtc->state isnt'
set both here and for plane transitional helpers too.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-02 14:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-02 7:23 [PATCH] drm/crtc-helper: Fixup error handling in drm_helper_crtc_mode_set Daniel Vetter
2015-07-02 7:29 ` Daniel Vetter
2015-07-02 9:01 ` Daniel Stone
2015-07-02 13:16 ` Daniel Vetter
2015-07-02 13:27 ` Daniel Stone
2015-07-02 14:29 ` Daniel Vetter [this message]
2015-07-02 14:33 ` [PATCH] drm: reset empty state in transitional helpers Daniel Vetter
2015-07-02 14:39 ` John Hunter
2015-07-03 7:10 ` Daniel Stone
2015-07-02 14:40 ` [PATCH] drm/crtc-helper: Fixup error handling in drm_helper_crtc_mode_set John Hunter
2015-07-04 16:57 ` shuang.he
2015-07-02 14:00 ` [PATCH 1/2] " Daniel Vetter
2015-07-02 14:00 ` [PATCH 2/2] drm/plane-helper: Use init state when freshly allocating them Daniel Vetter
2015-07-04 19:11 ` shuang.he
2015-07-04 10:39 ` [PATCH] drm/crtc-helper: Fixup error handling in drm_helper_crtc_mode_set shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150702142910.GD23343@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=daniels@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=zhaojunwang@pku.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox