From: Damien Lespiau <damien.lespiau@intel.com>
To: Kausal Malladi <Kausal.Malladi@intel.com>
Cc: indranil.mukherjee@intel.com, dhanya.p.r@intel.com,
annie.j.matheson@intel.com, jyoti.r.yadav@intel.com,
avinash.reddy.palleti@intel.com, intel-gfx@lists.freedesktop.org,
dri-devel@lists.freedesktop.org, vijay.a.purushothaman@intel.com,
jesse.barnes@intel.com, daniel.vetter@intel.com,
sunil.kamath@intel.com, shashank.sharma@intel.com
Subject: Re: [PATCH 03/12] drm/i915: Attach color properties to CRTC
Date: Thu, 2 Jul 2015 17:35:11 +0100 [thread overview]
Message-ID: <20150702163511.GF7203@strange.ger.corp.intel.com> (raw)
In-Reply-To: <1435765702-3094-4-git-send-email-Kausal.Malladi@intel.com>
On Wed, Jul 01, 2015 at 09:18:13PM +0530, Kausal Malladi wrote:
> From: Kausal Malladi <Kausal.Malladi@intel.com>
>
> This patch does the following:
> 1. Adds new files intel_color_manager(.c/.h)
> 2. Attaches color properties to CRTC while initialization
We usually order the series so that "it always works". In this case, you
are attaching the properties to the CRTC before having any code to
handle them, so if we are bisecting the tree and end up in the middle of
the series we get a broken behaviour.
If you put the attach() at the end of the series, we'll only expose the
properties when we do have to handle them.
--
Damien
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-02 16:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1435765702-3094-1-git-send-email-Kausal.Malladi@intel.com>
[not found] ` <1435765702-3094-10-git-send-email-Kausal.Malladi@intel.com>
2015-07-02 16:00 ` [PATCH 09/12] drm/i915: Add pipe level Gamma correction for CHV/BSW Damien Lespiau
2015-07-03 8:03 ` Jani Nikula
2015-07-03 8:29 ` [Intel-gfx] " Malladi, Kausal
2015-07-03 8:58 ` Jani Nikula
[not found] ` <1435765702-3094-5-git-send-email-Kausal.Malladi@intel.com>
2015-07-02 16:20 ` [PATCH 04/12] drm: Add structures for querying color capabilities Damien Lespiau
2015-07-02 16:45 ` Damien Lespiau
2015-07-02 17:04 ` [Intel-gfx] " Ville Syrjälä
2015-07-03 6:41 ` Daniel Vetter
2015-07-03 10:28 ` Damien Lespiau
2015-07-03 12:36 ` [Intel-gfx] " Ville Syrjälä
[not found] ` <1435765702-3094-8-git-send-email-Kausal.Malladi@intel.com>
2015-07-02 16:30 ` [PATCH 07/12] drm: Add structures to set/get a palette color property Damien Lespiau
[not found] ` <1435765702-3094-9-git-send-email-Kausal.Malladi@intel.com>
2015-07-02 16:32 ` [PATCH 08/12] drm: Export drm_property_replace_global_blob function Damien Lespiau
[not found] ` <1435765702-3094-4-git-send-email-Kausal.Malladi@intel.com>
2015-07-02 16:25 ` [PATCH 03/12] drm/i915: Attach color properties to CRTC Damien Lespiau
2015-07-02 16:35 ` Damien Lespiau [this message]
2015-07-03 3:31 [PATCH 00/12] Color Manager Implementation Kausal Malladi
2015-07-03 3:31 ` [PATCH 03/12] drm/i915: Attach color properties to CRTC Kausal Malladi
2015-07-07 23:23 ` Matt Roper
2015-07-08 4:29 ` Malladi, Kausal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150702163511.GF7203@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=Kausal.Malladi@intel.com \
--cc=annie.j.matheson@intel.com \
--cc=avinash.reddy.palleti@intel.com \
--cc=daniel.vetter@intel.com \
--cc=dhanya.p.r@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=indranil.mukherjee@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jesse.barnes@intel.com \
--cc=jyoti.r.yadav@intel.com \
--cc=shashank.sharma@intel.com \
--cc=sunil.kamath@intel.com \
--cc=vijay.a.purushothaman@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox