Re: [PATCH v3 1/5] drm: Add config for detecting libdrm

Mike Frysinger
2015-07-23T09:48:21Z

[-- Attachment #1.1: Type: text/plain, Size: 957 bytes --]

On 01 Jul 2015 14:52, Patrik Jakobsson wrote:
> Use pkg-config to try to find libdrm. If that fails use the standard
> include directory for kernel drm headers in /usr/include/drm.
>
> * configure.ac: Use pkg-config to find libdrm
>
> Signed-off-by: Patrik Jakobsson <patrik.jakobsson-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
> ---
> configure.ac | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/configure.ac b/configure.ac
> index bb8bf46..aa63af7 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -844,6 +844,10 @@ fi
> AM_CONDITIONAL([USE_LIBUNWIND], [test "x$use_libunwind" = xyes])
> AC_MSG_RESULT([$use_libunwind])
>
> +PKG_CHECK_MODULES([libdrm], [libdrm],
> + [CPPFLAGS="$CPPFLAGS $libdrm_CFLAGS"],
> + [CPPFLAGS="$CPPFLAGS -I/usr/include/drm"])

yikes, no, this is a really really bad idea. it should read:
PKG_CHECK_MODULES([LIBDRM], [libdrm],
[CPPFLAGS="$CPPFLAGS $LIBDRM_CFLAGS"], [:])
-mike

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 79 bytes --]

------------------------------------------------------------------------------

[-- Attachment #3: Type: text/plain, Size: 195 bytes --]

_______________________________________________
Strace-devel mailing list
Strace-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org