Re: [PATCH v3 1/5] drm: Add config for detecting libdrm

Mike Frysinger
2015-07-30T14:04:48Z

[-- Attachment #1.1: Type: text/plain, Size: 1456 bytes --]

On 30 Jul 2015 15:30, Patrik Jakobsson wrote:
> On Thu, Jul 23, 2015 at 05:48:21AM -0400, Mike Frysinger wrote:
> > On 01 Jul 2015 14:52, Patrik Jakobsson wrote:
> > > Use pkg-config to try to find libdrm. If that fails use the standard
> > > include directory for kernel drm headers in /usr/include/drm.
> > >
> > > * configure.ac: Use pkg-config to find libdrm
> > >
> > > Signed-off-by: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>
> > > ---
> > > configure.ac | 4 ++++
> > > 1 file changed, 4 insertions(+)
> > >
> > > diff --git a/configure.ac b/configure.ac
> > > index bb8bf46..aa63af7 100644
> > > --- a/configure.ac
> > > +++ b/configure.ac
> > > @@ -844,6 +844,10 @@ fi
> > > AM_CONDITIONAL([USE_LIBUNWIND], [test "x$use_libunwind" = xyes])
> > > AC_MSG_RESULT([$use_libunwind])
> > >
> > > +PKG_CHECK_MODULES([libdrm], [libdrm],
> > > + [CPPFLAGS="$CPPFLAGS $libdrm_CFLAGS"],
> > > + [CPPFLAGS="$CPPFLAGS -I/usr/include/drm"])
> >
> > yikes, no, this is a really really bad idea. it should read:
> > PKG_CHECK_MODULES([LIBDRM], [libdrm],
> > [CPPFLAGS="$CPPFLAGS $LIBDRM_CFLAGS"], [:])
>
> I take it you don't want me to fallback on kernel headers and skip
> compiling with drm support if libdrm is not available?

you cannot hardcode any path at all. if the kernel headers provide all
of the defines/structs that you need, then just include them directly
via #include <drm/xxx.h>.
-mike

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]