Re: [PATCH v3 4/5] drm: Add decoding of i915 ioctls

Dmitry V. Levin
2015-07-10T12:57:36Z

[-- Attachment #1.1: Type: text/plain, Size: 1194 bytes --]

On Fri, Jul 10, 2015 at 02:36:38PM +0200, Patrik Jakobsson wrote:
> On Wed, Jul 08, 2015 at 03:11:36AM +0300, Dmitry V. Levin wrote:
> > On Mon, Jul 06, 2015 at 04:40:24PM +0200, Gabriel Laskar wrote:
[...]
> > > Anyway, SYS_FUNC(ioctl) is a bit complicated, and the handling of the
> > > fallbacks on failure should be more generic.
> >
> > What would be useful is a way for "on entering" parsers to return
> > "done with decoding" information to their callers.
> >
> > This could be implemented by or'ing return value in the current semantics
> > with a flag with "done with decoding" meaning, e.g. RVAL_DONE.
> >
> > If an ioctl parser returned RVAL_DONE, this would tell SYS_FUNC(ioctl)
> > that the decoding is finished but fallback decoding is needed, while
> > RVAL_DONE+1 would mean that the decoding is finished and no fallback
> > decoding is needed.
>
> I like that idea but isn't the current return semantics already good enough
> for that? The problem right now is that we ignore the return value from
> ioctl_decode() "on entering".

After commit v4.10-104-g204c2bc we no longer ignore the return value from
ioctl_decode() "on entering".

--
ldv

[-- Attachment #1.2: Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]