From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lukas Wunner Subject: Re: [PATCH v3 2/2] drm/i915: On fb alloc failure, unref gem object where it gets refed Date: Sun, 5 Jul 2015 18:49:02 +0200 Message-ID: <20150705164902.GA29613@wunner.de> References: <559543BC.9030307@linux.intel.com> <6b1a9663dd6f320988077a077a5fbeab9d5988fb.1436007416.git.lukas@wunner.de> <20150704123148.GC5312@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mailout3.hostsharing.net (mailout3.hostsharing.net [176.9.242.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id 13E5D89CA0 for ; Sun, 5 Jul 2015 09:48:49 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20150704123148.GC5312@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org, Tvrtko Ursulin , Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , Daniel Vetter List-Id: intel-gfx@lists.freedesktop.org SGkgQ2hyaXMsCgp0aGFuayB5b3UgZm9yIHRoZSBxdWljayByZXNwb25zZSAob24gYSB3ZWVrZW5k IG5vIGxlc3MpLgoKCk9uIFNhdCwgSnVsIDA0LCAyMDE1IGF0IDAxOjMxOjQ4UE0gKzAxMDAsIENo cmlzIFdpbHNvbiB3cm90ZToKPiA+IC0JcmV0dXJuIGludGVsX2ZyYW1lYnVmZmVyX2NyZWF0ZShk ZXYsICZtb2RlX2NtZCwgb2JqKTsKPiA+ICsJZmIgPSBpbnRlbF9mcmFtZWJ1ZmZlcl9jcmVhdGUo ZGV2LCAmbW9kZV9jbWQsIG9iaik7Cj4gPiArCWlmIChJU19FUlIoZmIpKQo+ID4gKwkJZHJtX2dl bV9vYmplY3RfdW5yZWZlcmVuY2UoJm9iai0+YmFzZSk7Cj4gCj4gVGhpcyBuZWVkcyB0byBiZSBk cm1fZ2VtX29iamVjdF91bnJlZmVyZW5jZV91bmxvY2tlZCgpLgoKWW91J3JlIGFic29sdXRlbHkg cmlnaHQsIHRoYW5rcyBmb3IgcG9pbnRpbmcgdGhpcyBvdXQuCkknbSBwb3N0aW5nIGEgcmVjdGlm aWVkIHY0IHJpZ2h0IG5vdy4KCgo+IEl0J3MgbXVjaCBzaW1wbGVyIGlmIHlvdSBqdXN0IGRvY3Vt ZW50IHRoaXMgYXMgY29uc3VtaW5nIHRoZQo+IG9iaiByZWZlcmVuY2UuCgpZZXMgYnV0IEkgYmVs aWV2ZSB0aGF0IGlzIHdoYXQgVmlsbGUgdG9vayBleGNlcHRpb24gdG8uCgpJZiB5b3UgZ3V5cyBh bGwgYWdyZWUgdGhhdCBkb2N1bWVudGluZyB0aGlzIGlzIHN1ZmZpY2llbnQgdGhlbgp5b3UgY2Fu IGp1c3QgbWVyZ2UgVHZydGtvJ3MgdjIuIFRoZSByYXRpb25hbGUgb2YgdGhlIHYzICsgdjQKSSd2 ZSBzdWJtaXR0ZWQgaXMgdG8gb2ZmZXIgYW4gYWx0ZXJuYXRpdmUgaW4gdGhlIGhvcGUgb2YgcHVz aGluZwp0aGlzIGZvcndhcmQuCgoKPiBJZiB5b3Ugd2FudCB0byBmaXggaXQsIHlvdSBoYXZlIHRv IG1vdmUgdGhlIHN0cnVjdF9tdXRleCBpbnRvCj4gdGhlIGNhbGxlciBpLmUuIGVsaW1pbmF0ZSBp bnRlbF9mcmFtZWJ1ZmZlcl9jcmVhdGUoKSBhbmQgY2FsbAo+IF9faW50ZWxfZnJhbWVidWZmZXJf Y3JlYXRlKCkuCgpIbSwgSSBkb24ndCB1bmRlcnN0YW5kLiBUaGUgKGxvY2tpbmcpIGludGVsX2Zy YW1lYnVmZmVyX2NyZWF0ZQppcyB1c2VkIGJ5IGludGVsX2ZyYW1lYnVmZmVyX2NyZWF0ZV9mb3Jf bW9kZSBhcyB3ZWxsIGFzCmludGVsX3VzZXJfZnJhbWVidWZmZXJfY3JlYXRlLgoKVGhlIChub24t bG9ja2luZykgX19pbnRlbF9mcmFtZWJ1ZmZlcl9jcmVhdGUgaXMgdXNlZCBieQppbnRlbGZiX2Fs bG9jLiBTbyBpdCBzZWVtcyBib3RoIGFyZSBuZWVkZWQuIERhbmllbCBhZGRlZApfX2ludGVsX2Zy YW1lYnVmZmVyX2NyZWF0ZSB3aXRoIGE4YmI2ODE4MjcwYyAoImRybS9pOTE1OgpGaXggZXJyb3Ig cGF0aCBsZWFrIGluIGZiZGV2IGZiIGFsbG9jYXRpb24iKS4gSW5jaWRlbnRhbGx5CnRoaXMgaXMg YWxzbyB0aGUgY29tbWl0IHRoYXQgaW50cm9kdWNlZCB0aGUgZG91YmxlIHVucmVmLiA6LSkKCldl IGNvdWxkIGVsaW1pbmF0ZSB0aGUgKG5vbi1sb2NraW5nKSBfX2ludGVsX2ZyYW1lYnVmZmVyX2Ny ZWF0ZQpob3dldmVyIGJ5IGJyaWVmbHkgdW5sb2NraW5nIHN0cnVjdF9tdXRleCBpbiBpbnRlbGZi X2FsbG9jIGFmdGVyCmk5MTVfZ2VtX2FsbG9jX29iamVjdCBhbmQgdGhlbiByZWxvY2tpbmcgYmVm b3JlCmludGVsX3Bpbl9hbmRfZmVuY2VfZmJfb2JqICh0aGlzIGlzIG9uIHRvcCBvZiBUdnJ0a28n cyBwYXRjaAp3aGljaCBtb3ZlcyB0aGUgbG9ja2luZyBmcm9tIGludGVsZmJfY3JlYXRlIHRvIGlu dGVsZmJfYWxsb2MpLgoKQmVzdCByZWdhcmRzLAoKTHVrYXMKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK