From mboxrd@z Thu Jan  1 00:00:00 1970
From: Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [PATCH v4 2/2] drm/i915: On fb alloc failure,
 unref gem object where it gets refed
Date: Mon, 6 Jul 2015 09:41:51 +0200
Message-ID: <20150706074151.GC2156@phenom.ffwll.local>
References: <20150704123148.GC5312@nuc-i3427.alporthouse.com>
 <6ce2e2be9d2d19a3fb740a017f9f41de30dd9493.1436041426.git.lukas@wunner.de>
 <874c025b04129f1ca71a66be4568258fc5b6c133.1436041426.git.lukas@wunner.de>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com
 [209.85.212.171])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 1A2D96E2E7
 for <intel-gfx@lists.freedesktop.org>; Mon,  6 Jul 2015 00:39:05 -0700 (PDT)
Received: by wiwl6 with SMTP id l6so276010880wiw.0
 for <intel-gfx@lists.freedesktop.org>; Mon, 06 Jul 2015 00:39:03 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <874c025b04129f1ca71a66be4568258fc5b6c133.1436041426.git.lukas@wunner.de>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gU2F0LCBKdWwgMDQsIDIwMTUgYXQgMTE6NTA6NThBTSArMDIwMCwgTHVrYXMgV3VubmVyIHdy
b3RlOgo+IEN1cnJlbnRseSB3aGVuIGFsbG9jYXRpbmcgYSBmcmFtZWJ1ZmZlciBmYWlscywgdGhl
IGdlbSBvYmplY3QgZ2V0cwo+IHVucmVmZWQgYXQgdGhlIGJvdHRvbSBvZiB0aGUgY2FsbCBjaGFp
biBpbiBfX2ludGVsX2ZyYW1lYnVmZmVyX2NyZWF0ZSwKPiBub3Qgd2hlcmUgaXQgZ2V0cyByZWZl
ZCwgd2hpY2ggaXMgaW4gaW50ZWxfZnJhbWVidWZmZXJfY3JlYXRlX2Zvcl9tb2RlCj4gKHZpYSBp
OTE1X2dlbV9hbGxvY19vYmplY3QpIGFuZCBpbiBpbnRlbF91c2VyX2ZyYW1lYnVmZmVyX2NyZWF0
ZQo+ICh2aWEgZHJtX2dlbV9vYmplY3RfbG9va3VwKS4KPiAKPiBUaGlzIGludml0ZXMgbWlzdGFr
ZXM6IEFzIGRpc2NvdmVyZWQgYnkgVHZydGtvIFVyc3VsaW4sIGEgZG91YmxlIHVucmVmCj4gaGFz
IHNuZWFrZWQgaW50byBpbnRlbGZiX2FsbG9jICh3aGljaCBjYWxscyBfX2ludGVsX2ZyYW1lYnVm
ZmVyX2NyZWF0ZSkuCj4gCj4gQXMgc3VnZ2VzdGVkIGJ5IFZpbGxlIFN5cmrDpGzDpCwgaW1wcm92
ZSBjb2RlIGNsYXJpdHkgYnkgbW92aW5nIHRoZSB1bnJlZgo+IGF3YXkgZnJvbSBfX2ludGVsX2Zy
YW1lYnVmZmVyX2NyZWF0ZSB0byB3aGVyZSB0aGUgZ2VtIG9iamVjdCBnZXRzIHJlZmVkLgo+IAo+
IFNpZ25lZC1vZmYtYnk6IEx1a2FzIFd1bm5lciA8bHVrYXNAd3VubmVyLmRlPgo+IEZpeGVzOiBh
OGJiNjgxODI3MGMgKCJkcm0vaTkxNTogRml4IGVycm9yIHBhdGggbGVhayBpbiBmYmRldiBmYgo+
ICAgICBhbGxvY2F0aW9uIikKPiBDYzogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24u
Y28udWs+Cj4gQ2M6IFR2cnRrbyBVcnN1bGluIDx0dnJ0a28udXJzdWxpbkBpbnRlbC5jb20+Cj4g
Q2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6
IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZndsbC5jaD4KClBsZWFzZSBrZWVwIGEgcmVjb3JkIG9m
IHRoZSBjaGFuZ2VzIHlvdSBkbyB0byB0aGUgcGF0Y2ggc28gSSBrbm93IHdoYXQgdG8KbG9vayBv
dXQgZm9yLiBKdXN0IHJldmluZyB0aGUgcGF0Y2ggcmV2aXNpb24gYWxvbmUgZG9lc24ndCBhZGQg
bXVjaAppbmZvcm1hdGlvbiBmb3IgcmV2aWV3ZXJzL21haW50YWluZXJzLgoKVGhhbmtzLCBEYW5p
ZWwKCj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYyB8IDIxICsr
KysrKysrKysrKysrLS0tLS0tLQo+ICAxIGZpbGUgY2hhbmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwg
NyBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50
ZWxfZGlzcGxheS5jIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gaW5k
ZXggOTA3OWZjZC4uZDU5N2FmYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p
bnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5
LmMKPiBAQCAtODg3NiwyMCArODg3NiwxNyBAQCBfX2ludGVsX2ZyYW1lYnVmZmVyX2NyZWF0ZShz
dHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJaW50IHJldDsKPiAgCj4gIAlpbnRlbF9mYiA9IGt6
YWxsb2Moc2l6ZW9mKCppbnRlbF9mYiksIEdGUF9LRVJORUwpOwo+IC0JaWYgKCFpbnRlbF9mYikg
ewo+IC0JCWRybV9nZW1fb2JqZWN0X3VucmVmZXJlbmNlKCZvYmotPmJhc2UpOwo+ICsJaWYgKCFp
bnRlbF9mYikKPiAgCQlyZXR1cm4gRVJSX1BUUigtRU5PTUVNKTsKPiAtCX0KPiAgCj4gIAlyZXQg
PSBpbnRlbF9mcmFtZWJ1ZmZlcl9pbml0KGRldiwgaW50ZWxfZmIsIG1vZGVfY21kLCBvYmopOwo+
ICAJaWYgKHJldCkKPiAgCQlnb3RvIGVycjsKPiAgCj4gIAlyZXR1cm4gJmludGVsX2ZiLT5iYXNl
Owo+ICsKPiAgZXJyOgo+IC0JZHJtX2dlbV9vYmplY3RfdW5yZWZlcmVuY2UoJm9iai0+YmFzZSk7
Cj4gIAlrZnJlZShpbnRlbF9mYik7Cj4gLQo+ICAJcmV0dXJuIEVSUl9QVFIocmV0KTsKPiAgfQo+
ICAKPiBAQCAtODkyOSw2ICs4OTI2LDcgQEAgaW50ZWxfZnJhbWVidWZmZXJfY3JlYXRlX2Zvcl9t
b2RlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJCQkgIHN0cnVjdCBkcm1fZGlzcGxheV9t
b2RlICptb2RlLAo+ICAJCQkJICBpbnQgZGVwdGgsIGludCBicHApCj4gIHsKPiArCXN0cnVjdCBk
cm1fZnJhbWVidWZmZXIgKmZiOwo+ICAJc3RydWN0IGRybV9pOTE1X2dlbV9vYmplY3QgKm9iajsK
PiAgCXN0cnVjdCBkcm1fbW9kZV9mYl9jbWQyIG1vZGVfY21kID0geyAwIH07Cj4gIAo+IEBAIC04
OTQzLDcgKzg5NDEsMTEgQEAgaW50ZWxfZnJhbWVidWZmZXJfY3JlYXRlX2Zvcl9tb2RlKHN0cnVj
dCBkcm1fZGV2aWNlICpkZXYsCj4gIAkJCQkJCQkJYnBwKTsKPiAgCW1vZGVfY21kLnBpeGVsX2Zv
cm1hdCA9IGRybV9tb2RlX2xlZ2FjeV9mYl9mb3JtYXQoYnBwLCBkZXB0aCk7Cj4gIAo+IC0JcmV0
dXJuIGludGVsX2ZyYW1lYnVmZmVyX2NyZWF0ZShkZXYsICZtb2RlX2NtZCwgb2JqKTsKPiArCWZi
ID0gaW50ZWxfZnJhbWVidWZmZXJfY3JlYXRlKGRldiwgJm1vZGVfY21kLCBvYmopOwo+ICsJaWYg
KElTX0VSUihmYikpCj4gKwkJZHJtX2dlbV9vYmplY3RfdW5yZWZlcmVuY2VfdW5sb2NrZWQoJm9i
ai0+YmFzZSk7Cj4gKwo+ICsJcmV0dXJuIGZiOwo+ICB9Cj4gIAo+ICBzdGF0aWMgc3RydWN0IGRy
bV9mcmFtZWJ1ZmZlciAqCj4gQEAgLTEzMzc5LDYgKzEzMzgxLDcgQEAgaW50ZWxfdXNlcl9mcmFt
ZWJ1ZmZlcl9jcmVhdGUoc3RydWN0IGRybV9kZXZpY2UgKmRldiwKPiAgCQkJICAgICAgc3RydWN0
IGRybV9maWxlICpmaWxwLAo+ICAJCQkgICAgICBzdHJ1Y3QgZHJtX21vZGVfZmJfY21kMiAqbW9k
ZV9jbWQpCj4gIHsKPiArCXN0cnVjdCBkcm1fZnJhbWVidWZmZXIgKmZiOwo+ICAJc3RydWN0IGRy
bV9pOTE1X2dlbV9vYmplY3QgKm9iajsKPiAgCj4gIAlvYmogPSB0b19pbnRlbF9ibyhkcm1fZ2Vt
X29iamVjdF9sb29rdXAoZGV2LCBmaWxwLAo+IEBAIC0xMzM4Niw3ICsxMzM4OSwxMSBAQCBpbnRl
bF91c2VyX2ZyYW1lYnVmZmVyX2NyZWF0ZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LAo+ICAJaWYg
KCZvYmotPmJhc2UgPT0gTlVMTCkKPiAgCQlyZXR1cm4gRVJSX1BUUigtRU5PRU5UKTsKPiAgCj4g
LQlyZXR1cm4gaW50ZWxfZnJhbWVidWZmZXJfY3JlYXRlKGRldiwgbW9kZV9jbWQsIG9iaik7Cj4g
KwlmYiA9IGludGVsX2ZyYW1lYnVmZmVyX2NyZWF0ZShkZXYsIG1vZGVfY21kLCBvYmopOwo+ICsJ
aWYgKElTX0VSUihmYikpCj4gKwkJZHJtX2dlbV9vYmplY3RfdW5yZWZlcmVuY2VfdW5sb2NrZWQo
Jm9iai0+YmFzZSk7Cj4gKwo+ICsJcmV0dXJuIGZiOwo+ICB9Cj4gIAo+ICBzdGF0aWMgdm9pZCBp
bnRlbF9vdXRwdXRfcG9sbF9jaGFuZ2VkKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYpCj4gLS0gCj4g
Mi4xLjAKPiAKCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jw
b3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0
cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp
c3RpbmZvL2ludGVsLWdmeAo=