From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Abdiel Janulgue <abdiel.janulgue@linux.intel.com>,
intel-gfx@lists.freedesktop.org,
Jani Nikula <jani.nikula@intel.com>
Subject: Re: [PATCH v3 5/5] drm/i915: Expose I915_EXEC_RESOURCE_STREAMER flag
Date: Mon, 6 Jul 2015 10:28:28 +0200 [thread overview]
Message-ID: <20150706082828.GG2156@phenom.ffwll.local> (raw)
In-Reply-To: <20150702101540.GT21398@nuc-i3427.alporthouse.com>
On Thu, Jul 02, 2015 at 11:15:40AM +0100, Chris Wilson wrote:
> On Wed, Jul 01, 2015 at 10:12:23AM +0300, Abdiel Janulgue wrote:
> > Ensures that the batch buffer is executed by the resource streamer
> >
> > v2: Don't skip 1<<15 for the exec flags (Jani Nikula)
> > v3: Use HAS_RESOURCE_STREAMER macro for execbuf validation (Chris Wilson)
> >
> > Testcase: igt/gem_exec_params
> > Cc: Jani Nikula <jani.nikula@intel.com>
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
> > Signed-off-by: Abdiel Janulgue <abdiel.janulgue@linux.intel.com>
>
> This no longer applies (unrecognised base). Honestly, I would prefer 4&5
> squashed together, or 4 after 5 so that we do not declare
> HAS_RESOURCE_STREAMER before we accept the RS execbuf.
>
> Minor bit of patch reordering, but the code in 4 looks ok, so
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> # for 4/5
Yeah I just reordered 5 to go before 4. Series merged to dinq, thanks.
Abdiel can you pls push the corresponding igts (or ask Thomas to do it for
you)?
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-07-06 8:25 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-16 10:39 [PATCH resend 1/5] drm/i915: Enable resource streamer bits on MI_BATCH_BUFFER_START Abdiel Janulgue
2015-06-16 10:39 ` [PATCH resend 2/5] drm/i915: Enable Resource Streamer state save/restore on MI_SET_CONTEXT Abdiel Janulgue
2015-06-16 10:39 ` [PATCH resend 3/5] drm/i915: Enable resource streamer on Execlists Abdiel Janulgue
2015-06-26 14:10 ` Siluvery, Arun
2015-06-16 10:39 ` [PATCH resend 4/5] drm/i915: add I915_PARAM_HAS_RESOURCE_STREAMER to i915_getparam Abdiel Janulgue
2015-06-16 12:02 ` [PATCH v2 " Abdiel Janulgue
2015-06-16 12:21 ` Chris Wilson
2015-06-16 12:41 ` [PATCH v3 " Abdiel Janulgue
2015-06-24 6:30 ` Abdiel Janulgue
2015-06-29 7:52 ` Abdiel Janulgue
2015-06-29 8:03 ` Chris Wilson
2015-07-01 7:06 ` [PATCH v4 " Abdiel Janulgue
2015-06-16 10:39 ` [PATCH resend 5/5] drm/i915: Expose I915_EXEC_RESOURCE_STREAMER flag Abdiel Janulgue
2015-07-01 7:12 ` [PATCH v3 " Abdiel Janulgue
2015-07-02 10:15 ` Chris Wilson
2015-07-06 8:28 ` Daniel Vetter [this message]
2015-07-06 8:46 ` Abdiel Janulgue
2015-07-06 9:21 ` Thomas Wood
2015-07-02 13:33 ` [PATCH resend 1/5] drm/i915: Enable resource streamer bits on MI_BATCH_BUFFER_START Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706082828.GG2156@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=abdiel.janulgue@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox