From: Daniel Vetter <daniel@ffwll.ch>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx@lists.freedesktop.org, Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH] drm/i915: set FDI translations to NULL on SKL
Date: Mon, 6 Jul 2015 11:33:41 +0200 [thread overview]
Message-ID: <20150706093341.GP2156@phenom.ffwll.local> (raw)
In-Reply-To: <1435937490-1633-1-git-send-email-przanoni@gmail.com>
On Fri, Jul 03, 2015 at 12:31:30PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> drivers/gpu/drm/i915/intel_ddi.c: In function ‘intel_prepare_ddi’:
> drivers/gpu/drm/i915/intel_ddi.c:517:6: warning:
> ‘ddi_translations_fdi’ may be used uninitialized in this function
> [-Wmaybe-uninitialized]
> if (ddi_translations_fdi)
> ^
> drivers/gpu/drm/i915/intel_ddi.c:446:30: note: ‘ddi_translations_fdi’
> was declared here
> const struct ddi_buf_trans *ddi_translations_fdi;
> ^
>
> This line used to be there, but was removed by:
>
> commit f8896f5d58e64bfd3c2b5f7c5ba5c3f3967e93c7
> Author: David Weinehall <david.weinehall@linux.intel.com>
> Date: Thu Jun 25 11:11:03 2015 +030
> drm/i915/skl: Buffer translation improvements
>
> Cc: David Weinehall <david.weinehall@linux.intel.com>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
Queued for -next, thanks for the patch.
-Daniel
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 15fc66a..782310f 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -458,6 +458,7 @@ static void intel_prepare_ddi_buffers(struct drm_device *dev, enum port port,
> INTEL_OUTPUT_HDMI);
> return;
> } else if (IS_SKYLAKE(dev)) {
> + ddi_translations_fdi = NULL;
> ddi_translations_dp =
> skl_get_buf_trans_dp(dev, &n_dp_entries);
> ddi_translations_edp =
> --
> 2.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-07-06 9:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 15:31 [PATCH] drm/i915: set FDI translations to NULL on SKL Paulo Zanoni
2015-07-06 9:33 ` Daniel Vetter [this message]
2015-07-06 10:47 ` David Weinehall
2015-07-06 12:40 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706093341.GP2156@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=paulo.r.zanoni@intel.com \
--cc=przanoni@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox