From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Mika Kuoppala <mika.kuoppala@linux.intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 7/7] drm/i915: Mark elsps submitted when they are pushed to hw
Date: Mon, 6 Jul 2015 16:52:31 +0200 [thread overview]
Message-ID: <20150706145231.GN2156@phenom.ffwll.local> (raw)
In-Reply-To: <20150706093211.GF5312@nuc-i3427.alporthouse.com>
On Mon, Jul 06, 2015 at 10:32:11AM +0100, Chris Wilson wrote:
> On Mon, Jul 06, 2015 at 10:25:17AM +0100, Chris Wilson wrote:
> > On Mon, Jul 06, 2015 at 11:09:25AM +0300, Mika Kuoppala wrote:
> > > Now when we have requests this deep on call chain, we can mark
> > > the elsp being submitted when it actually is. Remove temp variable
> > > and readjust commenting to more closely fit to the code.
> > >
> > > v2: Avoid tmp variable and reduce number of writes (Chris)
> > >
> > > Cc: Chris Wilson <chris@chris-wilson.co.uk>
> > > Signed-off-by: Mika Kuoppala <mika.kuoppala@intel.com>
> >
> > Looks cleaner to me,
> > Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
>
> In fact, nothing in the series scared me and with the two minor changes,
> might as well apply that r-b to the whole series. For the benefit of
> others, can you repost the contracted series with my r-b applied?
Yeah maybe this was a bit too much splitting but I didn't find it too much
so just went ahead and applied it all.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-07-06 14:49 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-03 14:09 [RFC 0/7] Convert parts of intel_lrc.c to requests Mika Kuoppala
2015-07-03 14:09 ` [PATCH 1/7] drm/i915: Convert execlist_submit_contexts() for requests Mika Kuoppala
2015-07-07 16:49 ` Yu Dai
2015-07-07 21:44 ` Yu Dai
2015-07-08 7:23 ` Mika Kuoppala
2015-07-03 14:09 ` [PATCH 2/7] drm/i915: Convert execlists_update_context() " Mika Kuoppala
2015-07-03 14:09 ` [PATCH 3/7] drm/i915: Assign request ringbuf before pin Mika Kuoppala
2015-07-03 14:11 ` Chris Wilson
2015-07-06 8:08 ` Mika Kuoppala
2015-07-03 14:09 ` [PATCH 4/7] drm/i915: Convert intel_lr_context_pin() for requests Mika Kuoppala
2015-07-03 14:09 ` [PATCH 5/7] drm/i915: Convert execlists_elsp_writ() " Mika Kuoppala
2015-07-03 14:09 ` [PATCH 6/7] drm/i915: Convert execlists_ctx_descriptor() " Mika Kuoppala
2015-07-08 16:40 ` Yu Dai
2015-07-08 17:04 ` Dave Gordon
2015-07-08 17:26 ` Mika Kuoppala
2015-07-03 14:09 ` [PATCH 7/7] drm/i915: Mark elsps submitted when they are pushed to hw Mika Kuoppala
2015-07-03 15:36 ` Chris Wilson
2015-07-06 8:09 ` Mika Kuoppala
2015-07-06 9:25 ` Chris Wilson
2015-07-06 9:32 ` Chris Wilson
2015-07-06 14:52 ` Daniel Vetter [this message]
2015-07-06 15:35 ` [PATCH 1/2] drm/i915: Convert execlist_submit_contexts() for requests Mika Kuoppala
2015-07-05 3:34 ` [PATCH 7/7] drm/i915: Mark elsps submitted when they are pushed to hw shuang.he
2015-07-03 15:38 ` [RFC 0/7] Convert parts of intel_lrc.c to requests Chris Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706145231.GN2156@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=intel-gfx@lists.freedesktop.org \
--cc=mika.kuoppala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox