From: Daniel Vetter <daniel@ffwll.ch>
To: Matt Roper <matthew.d.roper@intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Don't dereference NULL plane while setting up scalers
Date: Mon, 6 Jul 2015 21:25:17 +0200 [thread overview]
Message-ID: <20150706192517.GK7568@phenom.ffwll.local> (raw)
In-Reply-To: <1436199564-21228-1-git-send-email-matthew.d.roper@intel.com>
On Mon, Jul 06, 2015 at 09:19:24AM -0700, Matt Roper wrote:
> intel_atomic_setup_scalers() dereferences 'plane' before the plane has
> been assigned. The plane ID assignment doing this dereference is only
> needed for debugging messages later in the function, so just move the
> assignment farther down the function to a point where plane will no
> longer be NULL.
>
> This was introduced in:
>
> commit 133b0d128be39e308ccd3b3d765c31ebdbf5380e
> Author: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Date: Mon Jun 15 12:33:39 2015 +0200
>
> drm/i915: Clean up intel_atomic_setup_scalers slightly.
>
> Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> Cc: Bob Paauwe <bob.j.paauwe@intel.com>
> Reported-by: Bob Paauwe <bob.j.paauwe@intel.com>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-07-06 19:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 16:19 [PATCH] drm/i915: Don't dereference NULL plane while setting up scalers Matt Roper
2015-07-06 19:25 ` Daniel Vetter [this message]
2015-07-07 5:32 ` Maarten Lankhorst
2015-07-07 21:28 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150706192517.GK7568@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=matthew.d.roper@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox