From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 10/20] drm/i915: Convert suspend/resume to atomic. Date: Tue, 7 Jul 2015 15:14:57 +0200 Message-ID: <20150707131457.GR7568@phenom.ffwll.local> References: <1436252911-5703-1-git-send-email-maarten.lankhorst@linux.intel.com> <1436252911-5703-11-git-send-email-maarten.lankhorst@linux.intel.com> <20150707095708.GD7568@phenom.ffwll.local> <559BAAF5.5060807@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f170.google.com (mail-wi0-f170.google.com [209.85.212.170]) by gabe.freedesktop.org (Postfix) with ESMTPS id 03E116E555 for ; Tue, 7 Jul 2015 06:12:13 -0700 (PDT) Received: by wiclp1 with SMTP id lp1so50398691wic.0 for ; Tue, 07 Jul 2015 06:12:11 -0700 (PDT) Content-Disposition: inline In-Reply-To: <559BAAF5.5060807@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKdWwgMDcsIDIwMTUgYXQgMTI6MzM6MjVQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMDctMDctMTUgb20gMTE6NTcgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+ ID4gT24gVHVlLCBKdWwgMDcsIDIwMTUgYXQgMDk6MDg6MjFBTSArMDIwMCwgTWFhcnRlbiBMYW5r aG9yc3Qgd3JvdGU6Cj4gPj4gQEAgLTEwNDIxLDEwICsxMDQxNCw2IEBAIHZvaWQgaW50ZWxfcmVs ZWFzZV9sb2FkX2RldGVjdF9waXBlKHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4g Pj4gIAkJaWYgKElTX0VSUihjcnRjX3N0YXRlKSkKPiA+PiAgCQkJZ290byBmYWlsOwo+ID4+ICAK PiA+PiAtCQl0b19pbnRlbF9jb25uZWN0b3IoY29ubmVjdG9yKS0+bmV3X2VuY29kZXIgPSBOVUxM Owo+ID4+IC0JCWludGVsX2VuY29kZXItPm5ld19jcnRjID0gTlVMTDsKPiA+PiAtCQlpbnRlbF9j cnRjLT5uZXdfZW5hYmxlZCA9IGZhbHNlOwo+ID4gbG9hZF9kZXRlY3QgY2hhbmdlcyBzaG91bGQg YmUgYSBzZXBhcmF0ZSBwYXRjaC4gT3IgdGhlIGNvbW1pdCBtZXNzYWdlCj4gPiBuZWVkcyB0byBl eHBsYWluIHdoeSB0aGlzIG5lZWRzIHRvIGJlIG9uZS4KPiBUaGVzZSBtZW1iZXJzIG5vIGxvbmdl ciBleGlzdC4gOy0pIGFsbCB0aGUgbmV3XyBzdHVmZiB3YXMgdG8gcmVzdG9yZSB0aGluZ3MgcHJl LWF0b21pYywgdGhlIGF0b21pYyB1cGRhdGVzIGFyZSBnb29kIGVub3VnaCBoZXJlLgo+IAo+IE1h a2luZyBpdCBhIHNlcGFyYXRlIHBhdGNoJ3MgcHJvYmFibHkgb2suCgpZZWFoIEkgdGhpbmsgc3Bs aXR0aW5nIG91dCB0aGUgbmV3XyogcmVtb3ZhbCB3b3VsZCBhZGRyZXNzIG1vc3Qgb2YgbXkKY29u Y2VybnMgaGVyZS4KCltzbmlwXQoKPiA+PiArCXN0cnVjdCBpbnRlbF9jb25uZWN0b3IgKmNvbm47 Cj4gPj4gKwlzdHJ1Y3QgaW50ZWxfcGxhbmUgKnBsYW5lOwo+ID4+ICsJc3RydWN0IGRybV9jcnRj ICpjcnRjOwo+ID4+ICsJaW50IHJldDsKPiA+PiAgCj4gPj4gLQkJLyoKPiA+PiAtCQkgKiBXZSBu ZWVkIHRvIHVzZSByYXcgaW50ZXJmYWNlcyBmb3IgcmVzdG9yaW5nIHN0YXRlIHRvIGF2b2lkCj4g Pj4gLQkJICogY2hlY2tpbmcgKGJvZ3VzKSBpbnRlcm1lZGlhdGUgc3RhdGVzLgo+ID4+IC0JCSAq Lwo+ID4+IC0JCWZvcl9lYWNoX3BpcGUoZGV2X3ByaXYsIHBpcGUpIHsKPiA+PiAtCQkJc3RydWN0 IGRybV9jcnRjICpjcnRjID0KPiA+PiAtCQkJCWRldl9wcml2LT5waXBlX3RvX2NydGNfbWFwcGlu Z1twaXBlXTsKPiA+PiArCWlmICghc3RhdGUpCj4gPiBkZWJ1ZyBvdXRwdXQgbWlzc2luZyB0aGF0 IHRoZSBzdGF0ZSBhbGxvYyBmYWlsZWQuIFBlcmhhcHMganVzdCBnb3RvIGZhaWw7Cj4gPiBzaW5j ZSBzdGF0ZV9mcmVlIGNhbiBjb3BlIHdpdGggYSBOVUxMIHN0YXRlLgo+IEl0IGNhbiBvbmx5IGZh aWwgYmVjYXVzZSBvZiBrbWFsbG9jLCB3aGljaCBwcmludHMgaXRzIG93biB3YXJuaW5ncy4KCk1p Z2h0IHN0aWxsIGJlIHVzZWZ1bCBqdXN0IHRvIGhhdmUgdW5pZmllZCBlcnJvciByZXBvcnRpbmcg LSB5b3UgbmVlZCB0bwpndWVzcyB0aGUgY2FsbGVyIG90aGVyd2lzZSB3aGljaCB3b3VsZCBtYWtl IGRlYnVnIChpZiB0aGlzIGV2ZXIgaGFwcGVzbikKaGFyZGVyLiBCdXQgcmVhbGx5IGp1c3QgYSBi aWtlc2hlZC4KCj4gCj4gPj4gKwkJcmV0dXJuOwo+ID4+ICAKPiA+PiAtCQkJaW50ZWxfY3J0Y19y ZXN0b3JlX21vZGUoY3J0Yyk7Cj4gPj4gLQkJfQo+ID4+IC0JfSBlbHNlIHsKPiA+PiAtCQlpbnRl bF9tb2Rlc2V0X3VwZGF0ZV9zdGFnZWRfb3V0cHV0X3N0YXRlKGRldik7Cj4gPj4gKwlzdGF0ZS0+ YWNxdWlyZV9jdHggPSBkZXYtPm1vZGVfY29uZmlnLmFjcXVpcmVfY3R4Owo+ID4+ICsKPiA+PiAr CS8qIHByZXNlcnZlIGNvbXBsZXRlIG9sZCBzdGF0ZSwgaW5jbHVkaW5nIGRwbGwgKi8KPiA+PiAr CWludGVsX2F0b21pY19nZXRfc2hhcmVkX2RwbGxfc3RhdGUoc3RhdGUpOwo+ID4+ICsKPiA+PiAr CWZvcl9lYWNoX2NydGMoZGV2LCBjcnRjKSB7Cj4gPj4gKwkJc3RydWN0IGRybV9jcnRjX3N0YXRl ICpjcnRjX3N0YXRlID0KPiA+PiArCQkJZHJtX2F0b21pY19nZXRfY3J0Y19zdGF0ZShzdGF0ZSwg Y3J0Yyk7Cj4gPj4gKwo+ID4+ICsJCXJldCA9IFBUUl9FUlJfT1JfWkVSTyhjcnRjX3N0YXRlKTsK PiA+PiArCQlpZiAocmV0KQo+ID4+ICsJCQlnb3RvIGVycjsKPiA+PiArCj4gPj4gKwkJLyogZm9y Y2UgYSByZXN0b3JlICovCj4gPj4gKwkJY3J0Y19zdGF0ZS0+bW9kZV9jaGFuZ2VkID0gdHJ1ZTsK PiA+PiArCX0KPiA+PiArCj4gPj4gKwlmb3JfZWFjaF9pbnRlbF9wbGFuZShkZXYsIHBsYW5lKSB7 Cj4gPj4gKwkJcmV0ID0gUFRSX0VSUl9PUl9aRVJPKGRybV9hdG9taWNfZ2V0X3BsYW5lX3N0YXRl KHN0YXRlLCAmcGxhbmUtPmJhc2UpKTsKPiA+PiArCQlpZiAocmV0KQo+ID4+ICsJCQlnb3RvIGVy cjsKPiA+PiArCX0KPiA+PiArCj4gPj4gKwlmb3JfZWFjaF9pbnRlbF9jb25uZWN0b3IoZGV2LCBj b25uKSB7Cj4gPj4gKwkJcmV0ID0gUFRSX0VSUl9PUl9aRVJPKGRybV9hdG9taWNfZ2V0X2Nvbm5l Y3Rvcl9zdGF0ZShzdGF0ZSwgJmNvbm4tPmJhc2UpKTsKPiA+PiArCQlpZiAocmV0KQo+ID4+ICsJ CQlnb3RvIGVycjsKPiA+PiAgCX0KPiA+PiAgCj4gPj4gLQlpbnRlbF9tb2Rlc2V0X2NoZWNrX3N0 YXRlKGRldik7Cj4gPj4gKwlpbnRlbF9tb2Rlc2V0X3NldHVwX2h3X3N0YXRlKGRldik7Cj4gPj4g Kwo+ID4+ICsJaTkxNV9yZWRpc2FibGVfdmdhKGRldik7Cj4gPiBTaW5jZSB3ZSd2ZSBvbmx5IGJh ZGx5IGJydWlzZWQgZXNjYXBlIHRoaXMgdHJhcCBJIHRoaW5rIHRoaXMgZGVzZXJ2ZXMgYQo+ID4g Y29tbWVudDoKPiA+Cj4gPiAJLyoKPiA+IAkgKiBXQVJOSU5HOiBXZSBjYW4ndCBkbyBhIGZ1bGwg YXRvbWljIG1vZGVzZXQgaW5jbHVkaW5nCj4gPiAJICogY29tcHV0ZS9jaGVjayBwaGFzZSBoZXJl IHNpbmNlIGVzcGVjaWFsbHkgZW5jb2Rlcgo+ID4gCSAqIGNvbXB1dGVfY29uZmlnIGZ1bmN0aW9u cyBkZXBlbmQgdXBvbiBvdXRwdXQgZGV0ZWN0aW9uIHN0YXRlLgo+ID4gCSAqIEFuZCB0aGF0J3Mg anVzdCBub3QgeWV0IGF2YWlsYWJsZSBhdCBkcml2ZXIgbG9hZC4gVGhlcmVmb3JlIHdlCj4gPiAJ ICogbXVzdCByZWFkIG91dCB0aGUgZW50aXJlIHJlbGV2YW50IGh3IHN0YXRlIChpbmNsdWRpbmcg YW55Cj4gPiAJICogZHJpdmVyIGludGVybmFsIHN0YXRlKSBmYWl0aGZ1bGx5IGhlcmUgYW5kIG9u bHkgYXBwbHkgdGhlCj4gPiAJICogY29tbWl0IHNpZGUuCj4gPiAJICovCj4gPgo+ID4gSG0sIG1h a2VzIG1lIHRoaW5rIC4uLiBzaG91bGQgd2UgZW5kIHVwIGNhbGxpbmcganVzdCBkZXYtPmF0b21p Y19jb21taXQoc3RhdGUpIGhlcmUKPiA+IG9uY2UgYXRvbWljIG1vZGVzZXQgaXMgZnVsbHkgd29y a2luZz8KPiBOb3QgZm9yIGluaXRpYWwgaHcgcmVhZG91dCB1bmxlc3MgeW91IHdhbnQgdG8gY2Fs bCBkZXRlY3QgaW4gdGhpcyBmdW5jdGlvbiBmb3IgYWxsIGVuY29kZXJzLi4gcmVzdW1lJ3MgZmlu ZSBwcm9iYWJseS4KCkkgbWVhbnQgY2FsbGluZyBkZXYtPm1vZGVfY29uZmlnLmZ1bmNzLT5hdG9t aWNfY29tbWl0KHN0YXRlKSBkaXJlY3RseSwKd2l0aG91dCBjYWxsaW5nIC0+YXRvbWljX2NoZWNr IGF0IGFsbC4gVGhhdCBzaG91bGQgYXZvaWQgYW55IHN0YXRlCnJlY29tcHV0YXRpb24gKG90aGVy d2lzZSBvdXIgY2hlY2svY29tbWl0IHNwbGl0IGlzIGJvdGNoZWQpIGFuZCBoZW5jZSBiZQpleGFj dGx5IHdoYXQgd2UgbmVlZCBoZXJlLiBJIGRpZG4ndCBjaGVjayBob3cgY2xvc2UgaW50ZWxfc2V0 X21vZGUgaXMKY29tcGFyZWQgb3VyIC0+YXRvbWljX2NvbW1pdCBpbXBsZW1lbnRhdGlvbiBhZnRl ciB0aGlzIHNlcmllcyAoZGlkbid0CmFwcGx5IHRoZW0gYWxsKS4gQnV0IEkgdGhpbmsgZnJvbSBh IHNlbWFudGljIHBvdiB0aG9zZSB0d28gc2hvdWxkIG1hdGNoLgotRGFuaWVsCi0tIApEYW5pZWwg VmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBDb3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5m ZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=