From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 13/20] drm/i915: Always reset in intel_crtc_restore_mode Date: Tue, 7 Jul 2015 15:16:59 +0200 Message-ID: <20150707131659.GS7568@phenom.ffwll.local> References: <1436252911-5703-1-git-send-email-maarten.lankhorst@linux.intel.com> <1436252911-5703-14-git-send-email-maarten.lankhorst@linux.intel.com> <20150707101744.GG7568@phenom.ffwll.local> <559BAE84.4030606@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f173.google.com (mail-wi0-f173.google.com [209.85.212.173]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD9DB6E3E9 for ; Tue, 7 Jul 2015 06:14:13 -0700 (PDT) Received: by wiga1 with SMTP id a1so256428716wig.0 for ; Tue, 07 Jul 2015 06:14:12 -0700 (PDT) Content-Disposition: inline In-Reply-To: <559BAE84.4030606@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gVHVlLCBKdWwgMDcsIDIwMTUgYXQgMTI6NDg6MzZQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMDctMDctMTUgb20gMTI6MTcgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+ ID4gT24gVHVlLCBKdWwgMDcsIDIwMTUgYXQgMDk6MDg6MjRBTSArMDIwMCwgTWFhcnRlbiBMYW5r aG9yc3Qgd3JvdGU6Cj4gPj4gQW5kIGdldCByaWQgb2YgdGhpbmdzIHRoYXQgYXJlIG5vIGxvbmdl ciB0cnVlLiBUaGlzIGZ1bmN0aW9uIGlzIG9ubHkKPiA+PiB1c2VkIGZvciBmb3JjaW5nIGEgbW9k ZXNldCB3aGVuIGVuY29kZXIgcHJvcGVydGllcyBhcmUgY2hhbmdlZC4KPiA+Pgo+ID4+IEFsbCB0 aGUgZXhpc3Rpbmcgc3RhdGUgaXMgZmluZSBpbiB0aGlzIGNhc2UsIG9ubHkgc2V0dGluZyBtb2Rl X2NoYW5nZWQKPiA+PiB3aWxsIGZvcmNlIGEgZnVsbCByZWNhbGN1bGF0aW9uIGhlcmUsIGFuZCB0 YWtlIGFsbCB0aGUgc3RhdGUgbmVlZGVkLgo+ID4+Cj4gPj4gVGhlIHByZXZpb3VzIGNvbW1pdCB3 aWxsIHByZXZlbnQgdW5uZWVkZWQgbW9kZXNldHMgYW55d2F5Lgo+ID4+Cj4gPj4gU2lnbmVkLW9m Zi1ieTogTWFhcnRlbiBMYW5raG9yc3QgPG1hYXJ0ZW4ubGFua2hvcnN0QGxpbnV4LmludGVsLmNv bT4KPiA+PiAtLS0KPiA+PiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jIHwg NTggKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPj4gIDEgZmlsZSBjaGFu Z2VkLCAxNiBpbnNlcnRpb25zKCspLCA0MiBkZWxldGlvbnMoLSkKPiA+Pgo+ID4+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+PiBpbmRleCAxNjM3MzMwOWRjYWUuLmY3YjFmYzI4 MTQyYyAxMDA2NDQKPiA+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5 LmMKPiA+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNwbGF5LmMKPiA+PiBA QCAtMTMyNjAsNjMgKzEzMjYwLDM3IEBAIHZvaWQgaW50ZWxfY3J0Y19yZXN0b3JlX21vZGUoc3Ry dWN0IGRybV9jcnRjICpjcnRjKQo+ID4+ICB7Cj4gPj4gIAlzdHJ1Y3QgZHJtX2RldmljZSAqZGV2 ID0gY3J0Yy0+ZGV2Owo+ID4+ICAJc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlOwo+ID4+ IC0Jc3RydWN0IGludGVsX2VuY29kZXIgKmVuY29kZXI7Cj4gPj4gLQlzdHJ1Y3QgaW50ZWxfY29u bmVjdG9yICpjb25uZWN0b3I7Cj4gPj4gLQlzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29u bmVjdG9yX3N0YXRlOwo+ID4+IC0Jc3RydWN0IGludGVsX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7 Cj4gPj4gKwlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gPj4gIAlpbnQgcmV0 Owo+ID4+ICAKPiA+PiAgCXN0YXRlID0gZHJtX2F0b21pY19zdGF0ZV9hbGxvYyhkZXYpOwo+ID4+ ICAJaWYgKCFzdGF0ZSkgewo+ID4+IC0JCURSTV9ERUJVR19LTVMoIltDUlRDOiVkXSBtb2RlIHJl c3RvcmUgZmFpbGVkLCBvdXQgb2YgbWVtb3J5IiwKPiA+PiArCQlEUk1fREVCVUdfS01TKCJbQ1JU QzolZF0gY3J0YyByZXN0b3JlIGZhaWxlZCwgb3V0IG9mIG1lbW9yeSIsCj4gPj4gIAkJCSAgICAg IGNydGMtPmJhc2UuaWQpOwo+ID4+ICAJCXJldHVybjsKPiA+PiAgCX0KPiA+PiAgCj4gPj4gLQlz dGF0ZS0+YWNxdWlyZV9jdHggPSBkZXYtPm1vZGVfY29uZmlnLmFjcXVpcmVfY3R4Owo+ID4+IC0K PiA+PiAtCS8qIFRoZSBmb3JjZSByZXN0b3JlIHBhdGggaW4gdGhlIEhXIHJlYWRvdXQgY29kZSBy ZWxpZXMgb24gdGhlIHN0YWdlZAo+ID4+IC0JICogY29uZmlnIHN0aWxsIGtlZXBpbmcgdGhlIHVz ZXIgcmVxdWVzdGVkIGNvbmZpZyB3aGlsZSB0aGUgYWN0dWFsCj4gPj4gLQkgKiBzdGF0ZSBoYXMg YmVlbiBvdmVyd3JpdHRlbiBieSB0aGUgY29uZmlndXJhdGlvbiByZWFkIGZyb20gSFcuIFdlCj4g Pj4gLQkgKiBuZWVkIHRvIGNvcHkgdGhlIHN0YWdlZCBjb25maWcgdG8gdGhlIGF0b21pYyBzdGF0 ZSwgb3RoZXJ3aXNlIHRoZQo+ID4+IC0JICogbW9kZSBzZXQgd2lsbCBqdXN0IHJlYXBwbHkgdGhl IHN0YXRlIHRoZSBIVyBpcyBhbHJlYWR5IGluLiAqLwo+ID4+IC0JZm9yX2VhY2hfaW50ZWxfZW5j b2RlcihkZXYsIGVuY29kZXIpIHsKPiA+PiAtCQlpZiAoZW5jb2Rlci0+YmFzZS5jcnRjICE9IGNy dGMpCj4gPj4gLQkJCWNvbnRpbnVlOwo+ID4+ICsJc3RhdGUtPmFjcXVpcmVfY3R4ID0gZHJtX21v ZGVzZXRfbGVnYWN5X2FjcXVpcmVfY3R4KGNydGMpOwo+ID4+ICAKPiA+PiAtCQlmb3JfZWFjaF9p bnRlbF9jb25uZWN0b3IoZGV2LCBjb25uZWN0b3IpIHsKPiA+PiAtCQkJaWYgKGNvbm5lY3Rvci0+ YmFzZS5zdGF0ZS0+YmVzdF9lbmNvZGVyICE9Cj4gPj4gLQkJCSAgICAmZW5jb2Rlci0+YmFzZSkK PiA+PiAtCQkJCWNvbnRpbnVlOwo+ID4+IC0KPiA+PiAtCQkJY29ubmVjdG9yX3N0YXRlID0gZHJt X2F0b21pY19nZXRfY29ubmVjdG9yX3N0YXRlKHN0YXRlLCAmY29ubmVjdG9yLT5iYXNlKTsKPiA+ PiAtCQkJaWYgKElTX0VSUihjb25uZWN0b3Jfc3RhdGUpKSB7Cj4gPj4gLQkJCQlEUk1fREVCVUdf S01TKCJGYWlsZWQgdG8gYWRkIFtDT05ORUNUT1I6JWQ6JXNdIHRvIHN0YXRlOiAlbGRcbiIsCj4g Pj4gLQkJCQkJICAgICAgY29ubmVjdG9yLT5iYXNlLmJhc2UuaWQsCj4gPj4gLQkJCQkJICAgICAg Y29ubmVjdG9yLT5iYXNlLm5hbWUsCj4gPj4gLQkJCQkJICAgICAgUFRSX0VSUihjb25uZWN0b3Jf c3RhdGUpKTsKPiA+PiAtCQkJCWNvbnRpbnVlOwo+ID4+IC0JCQl9Cj4gPj4gK3JldHJ5Ogo+ID4+ ICsJY3J0Y19zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X2NydGNfc3RhdGUoc3RhdGUsIGNydGMpOwo+ ID4+ICsJcmV0ID0gUFRSX0VSUl9PUl9aRVJPKGNydGNfc3RhdGUpOwo+ID4+ICsJaWYgKCFyZXQp IHsKPiA+PiArCQlpZiAoIWNydGNfc3RhdGUtPmFjdGl2ZSkKPiA+PiArCQkJZ290byBvdXQ7Cj4g Pj4gIAo+ID4+IC0JCQljb25uZWN0b3Jfc3RhdGUtPmNydGMgPSBjcnRjOwo+ID4+IC0JCX0KPiA+ PiArCQljcnRjX3N0YXRlLT5tb2RlX2NoYW5nZWQgPSB0cnVlOwo+ID4+ICsJCXJldCA9IGludGVs X3NldF9tb2RlKHN0YXRlKTsKPiA+IEkgdGhpbmsgaGVyZSAoaW5zdGVhZCBvZiB0aGUgaHcgc3Rh dGUgcmVhZG91dC9yZXN0b3JlIGNvZGUpIHdlIG11c3QgZG8gYQo+ID4gZnVsbCBjb21wdXRlIGNv bmZpZyBvZiB0aGUgcGlwZSBzdGF0ZSAtIG1vc3Qgb2YgdGhlIGNvbm5lY3RvciBwcm9wZXJ0aWVz Cj4gPiBuZWVkIHRoYXQgdG8gZ2V0IHJlZmxlY3RlZC4gU2hvdWxkIGJlIGVhc3kgdG8gdGVzdCBi eSBjaGFuZ2luZyB0aGUgcGFuZWwKPiA+IHVwc2NhbGluZyBwcm9wZXJ0eS4gSGVuY2UgSSB0aGlu ayB3ZSBzaG91bGQgYmUgYWJsZSB0byBydW4gYSBmdWxsLWJsb3duCj4gPiBkcm1fYXRvbWljX2Nv bW1pdCBoZXJlLgo+IFdoaWNoIGlzIHdoYXQgdGhpcyBjb2RlIGRvZXM/Cj4gVG9nZXRoZXIgd2l0 aCB0aGUgcHJldmlvdXMgY29tbWl0IGF0IGxlYXN0LCB3aXRob3V0IGl0IGl0IGp1c3QgcGVyZm9y bXMgYSBmdWxsIG1vZGVzZXQgYW5kIHJlY2FsY3VsYXRpb24uCgpPaCBJIGhhZCBhIGNvbmZ1c2lv biBhYm91dCB3aGF0IGludGVsX3NldF9tb2RlIGRvZXMsIEkgdGhvdWdodCBpdCBvbmx5CmRvZXMg dGhlIGNvbW1pdCBzaWRlIG9mIHRoaW5ncyBhbmQgZG9lc24ndCBkbyBhbGwgdGhlIGNvbXB1dGVf Y29uZmlnCnN0dWZmLiBJIGd1ZXNzIHRoaXMgaXMgc29tZXRoaW5nIHRvIGNsZWFuIHVwIG9uY2Ug d2UgaGF2ZSBpdCBhbGwgbGFuZGVkLApidXQgSSdkIGhhdmUgZXhwZWN0ZWQgdGhhdCBhIGRybV9h dG9taWNfY29tbWl0KHN0YXRlKSB3b3VsZCBleGFjdGx5IGRvCndoYXQgd2Ugd2FudCB0byBkbyBo ZXJlLgotRGFuaWVsCi0tIApEYW5pZWwgVmV0dGVyClNvZnR3YXJlIEVuZ2luZWVyLCBJbnRlbCBD b3Jwb3JhdGlvbgpodHRwOi8vYmxvZy5mZndsbC5jaApfX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBs aXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFu L2xpc3RpbmZvL2ludGVsLWdmeAo=