From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 02/20] drm: Don't update plane properties for atomic planes if it stays the same Date: Wed, 8 Jul 2015 10:55:08 +0200 Message-ID: <20150708085508.GD7568@phenom.ffwll.local> References: <1436252911-5703-1-git-send-email-maarten.lankhorst@linux.intel.com> <1436252911-5703-3-git-send-email-maarten.lankhorst@linux.intel.com> <20150707091847.GX7568@phenom.ffwll.local> <559BA7DA.8010701@linux.intel.com> <20150707121011.GQ7568@phenom.ffwll.local> <559BEB72.1050702@linux.intel.com> <20150707164352.GZ7568@phenom.ffwll.local> <559CD896.8040301@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wg0-f41.google.com (mail-wg0-f41.google.com [74.125.82.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id AACA16E5E8 for ; Wed, 8 Jul 2015 01:52:23 -0700 (PDT) Received: by wgxm20 with SMTP id m20so6031993wgx.3 for ; Wed, 08 Jul 2015 01:52:22 -0700 (PDT) Content-Disposition: inline In-Reply-To: <559CD896.8040301@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKdWwgMDgsIDIwMTUgYXQgMTA6MDA6MjJBTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMDctMDctMTUgb20gMTg6NDMgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+ ID4gT24gVHVlLCBKdWwgMDcsIDIwMTUgYXQgMDU6MDg6MzRQTSArMDIwMCwgTWFhcnRlbiBMYW5r aG9yc3Qgd3JvdGU6Cj4gPj4gT3AgMDctMDctMTUgb20gMTQ6MTAgc2NocmVlZiBEYW5pZWwgVmV0 dGVyOgo+ID4+PiBPbiBUdWUsIEp1bCAwNywgMjAxNSBhdCAxMjoyMDoxMFBNICswMjAwLCBNYWFy dGVuIExhbmtob3JzdCB3cm90ZToKPiA+Pj4+IE9wIDA3LTA3LTE1IG9tIDExOjE4IHNjaHJlZWYg RGFuaWVsIFZldHRlcjoKPiA+Pj4+PiBPbiBUdWUsIEp1bCAwNywgMjAxNSBhdCAwOTowODoxM0FN ICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90ZToKPiA+Pj4+Pj4gVGhpcyBhbGxvd3MgdGhl IGZpcnN0IGF0b21pYyBjYWxsIGR1cmluZyBodyBpbml0IHRvIGJlIGEgcmVhbCBtb2Rlc2V0LAo+ ID4+Pj4+PiB3aGljaCBpcyB1c2VmdWwgZm9yIGZvcmNpbmcgYSByZWNhbGN1bGF0aW9uLgo+ID4+ Pj4+IGZiY29uIGlzIG9wdGlvbmFsLCB5b3UgY2FuJ3QgcmVseSBvbiBhbnl0aGluZyBiZWluZyBk b25lIGluIGFueSBzcGVjaWZpYwo+ID4+Pj4+IHdheS4gV2hhdCBleGFjdGx5IGRvIHlvdSBuZWVk IHRoaXMgZm9yLCB3aGF0J3MgdGhlIGltcGxpY2F0aW9ucz8KPiA+Pj4+IEluIHRoZSBodyByZWFk b3V0IEkgbm90aWNlZCBzb21lIHdhcm5pbmdzIHdoZW4gSSB3YXNuJ3Qgc2V0dGluZyBhbnkgbW9k ZSBwcm9wZXJ0eSBpbiB0aGUgcmVhZG91dC4KPiA+Pj4+IEkgd2FudCB0aGUgZmlyc3QgZnVuY3Rp b24gdG8gYmUgdGhlIG1vZGVzZXQsIHNvIHdlIGhhdmUgYSBzYW5lIGJhc2UgdG8gY29tbWl0IGNo YW5nZXMgb24uCj4gPj4+PiBJZGVhbGx5IHRoaXMgd2hvbGUgZnVuY3Rpb24gd291bGQgaGF2ZSBh IGF0b21pYyBjb3VudGVycGFydCB3aGljaCBkb2VzIGl0IGluIG9uZSBnby4gOikKPiA+Pj4gWWVh aC4gT3RvaCBhcyBzb29uIGFzIHdlIGhhdmUgYXRvbWljIG1vZGVzZXQgd29ya2luZyB3ZSBjYW4g cmVwbGFjZSBhbGwKPiA+Pj4gdGhlIGxlZ2FjeSBlbnRyeSBwb2ludHMgd2l0aCBhdG9taWMgaGVs cGVycywgYW5kIHRoZW4gZXZlbiBwbGFuZV9kaXNhYmxlCj4gPj4+IHdpbGwgYmUgYSBmdWxsIGF0 b21pYyBtb2Rlc2V0Lgo+ID4+Pgo+ID4+PiBXaGF0IGRpZCBmYWxsIGFwYXJ0IHdpdGgganVzdCB0 b3VjaGluZyBwcm9wZXJ0aWVzL3BsYW5lcyBub3c/Cj4gPj4gQWxzbyB3aGVuIGk5MTUgaXMgZnVs bHkgYXRvbWljIGl0IGNhbGN1bGF0ZXMgaW4gaW50ZWxfbW9kZXNldF9jb21wdXRlX2NvbmZpZwo+ ID4+IGlmIGEgbW9kZXNldCBpcyBuZWVkZWQgYWZ0ZXIgdGhlIGZpcnN0IGF0b21pYyBjYWxsLiBS aWdodCBub3cgYmVjYXVzZQo+ID4+IGludGVsX21vZGVzZXRfY29tcHV0ZV9jb25maWcgaXMgb25s eSBjYWxsZWQgaW4gc2V0X2NvbmZpZyBzbyB0aGlzIHdvcmtzIGFzIGV4cGVjdGVkLgo+ID4+IE90 aGVyd2lzZSBkcm1fcGxhbmVfZm9yY2VfZGlzYWJsZSBvciByb3RhdGVfMCB3aWxsIGZvcmNlIGEg bW9kZXNldCwKPiA+PiBhbmQgaWYgdGhlIGZpbmFsIG1vZGUgaXMgZGlmZmVyZW50IHRoaXMgd2ls bCBpbnRyb2R1Y2UgYSBkb3VibGUgbW9kZXNldC4KPiA+IEZvciBleHBlbnNpdmUgcHJvcGVydGll cyAoaS5lLiBhIG5vLW9wIGNoYW5nZXMgY2F1c2VzIHNvbWV0aGluZyB0aGF0IHRha2VzCj4gPiB0 aW1lIGxpa2UgbW9kZXNldCBvciB2Ymxhbmsgd2FpdCkgd2UgbmVlZCB0byBtYWtlIHN1cmUgd2Ug ZmlsdGVyIHRoZW0gb3V0Cj4gPiBpbiBhdG9taWNfY2hlY2suIFllYWggbm90IHF1aXRlIHRoZXJl IHlldCB3aXRoIHB1cmUgYXRvbWljLCBidXQgbWVhbndoaWxlCj4gPiB0aGUgZXhpc3RpbmcgbGVn YWN5IHNldF9wcm9wIGZ1bmN0aW9ucyBzaG91bGQgYWxsIGZpbHRlciBvdXQgbm8tb3AgY2hhbmdl cwo+ID4gdGhlbXNlbHZlcy4gSWYgd2UgZG9uJ3QgZG8gdGhhdCBmb3Igcm90YXRpb24gdGhlbiB0 aGF0J3MgYSBidWcuCj4gPgo+ID4gU2FtZSBmb3IgZGlzYWJsaW5nIHBsYW5lcyBoYXJkZXIsIHRo YXQgc2hvdWxkbid0IHRha2UgdGltZS4gRXNwZWNpYWxseQo+ID4gc2luY2UgZmJjb24gb25seSBm b3JjZS1kaXNhYmxlIG5vbi1wcmltYXJ5IHBsYW5lLCBhbmQgZm9yIGRyaXZlciBsb2FkCj4gPiB0 aGF0J3MgdGhlIGV4YWN0IHRoaW5nIHdlIGFscmVhZHkgZG8gaW4gdGhlIGRyaXZlciBhbnl3YXku Cj4gCj4gU29tZXRoaW5nIGxpa2UgdGhpcz8KPiAtLS0KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19o ZWxwZXIuYwo+IGluZGV4IGExZDRlMTNmMzkwOC4uMjk4OTIzMmY0OTk2IDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2RybV9hdG9taWNfaGVscGVyLmMKPiBAQCAtMzAsNiArMzAsNyBAQAo+ICAjaW5jbHVkZSA8 ZHJtL2RybV9wbGFuZV9oZWxwZXIuaD4KPiAgI2luY2x1ZGUgPGRybS9kcm1fY3J0Y19oZWxwZXIu aD4KPiAgI2luY2x1ZGUgPGRybS9kcm1fYXRvbWljX2hlbHBlci5oPgo+ICsjaW5jbHVkZSAiZHJt X2NydGNfaW50ZXJuYWwuaCIKPiAgI2luY2x1ZGUgPGxpbnV4L2ZlbmNlLmg+Cj4gIAo+ICAvKioK PiBAQCAtMTcxNiw3ICsxNzE3LDEyIEBAIGRybV9hdG9taWNfaGVscGVyX2NydGNfc2V0X3Byb3Bl cnR5KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPiAgewo+ICAJc3RydWN0IGRybV9hdG9taWNfc3Rh dGUgKnN0YXRlOwo+ICAJc3RydWN0IGRybV9jcnRjX3N0YXRlICpjcnRjX3N0YXRlOwo+IC0JaW50 IHJldCA9IDA7Cj4gKwl1aW50NjRfdCByZXR2YWw7Cj4gKwlpbnQgcmV0Owo+ICsKPiArCXJldCA9 IGRybV9hdG9taWNfZ2V0X3Byb3BlcnR5KCZjcnRjLT5iYXNlLCBwcm9wZXJ0eSwgJnJldHZhbCk7 Cj4gKwlpZiAoIXJldCAmJiB2YWwgPT0gcmV0dmFsKQo+ICsJCXJldHVybiAwOwo+ICAKPiAgCXN0 YXRlID0gZHJtX2F0b21pY19zdGF0ZV9hbGxvYyhjcnRjLT5kZXYpOwo+ICAJaWYgKCFzdGF0ZSkK PiBAQCAtMTc3Niw3ICsxNzgyLDEyIEBAIGRybV9hdG9taWNfaGVscGVyX3BsYW5lX3NldF9wcm9w ZXJ0eShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiAgewo+ICAJc3RydWN0IGRybV9hdG9taWNf c3RhdGUgKnN0YXRlOwo+ICAJc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqcGxhbmVfc3RhdGU7Cj4g LQlpbnQgcmV0ID0gMDsKPiArCXVpbnQ2NF90IHJldHZhbDsKPiArCWludCByZXQ7Cj4gKwo+ICsJ cmV0ID0gZHJtX2F0b21pY19nZXRfcHJvcGVydHkoJnBsYW5lLT5iYXNlLCBwcm9wZXJ0eSwgJnJl dHZhbCk7Cj4gKwlpZiAoIXJldCAmJiB2YWwgPT0gcmV0dmFsKQo+ICsJCXJldHVybiAwOwo+ICAK PiAgCXN0YXRlID0gZHJtX2F0b21pY19zdGF0ZV9hbGxvYyhwbGFuZS0+ZGV2KTsKPiAgCWlmICgh c3RhdGUpCj4gQEAgLTE4MzYsNyArMTg0NywxMiBAQCBkcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0 b3Jfc2V0X3Byb3BlcnR5KHN0cnVjdCBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gIHsKPiAg CXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpzdGF0ZTsKPiAgCXN0cnVjdCBkcm1fY29ubmVjdG9y X3N0YXRlICpjb25uZWN0b3Jfc3RhdGU7Cj4gLQlpbnQgcmV0ID0gMDsKPiArCXVpbnQ2NF90IHJl dHZhbDsKPiArCWludCByZXQ7Cj4gKwo+ICsJcmV0ID0gZHJtX2F0b21pY19nZXRfcHJvcGVydHko JmNvbm5lY3Rvci0+YmFzZSwgcHJvcGVydHksICZyZXR2YWwpOwo+ICsJaWYgKCFyZXQgJiYgdmFs ID09IHJldHZhbCkKPiArCQlyZXR1cm4gMDsKPiAgCj4gIAlzdGF0ZSA9IGRybV9hdG9taWNfc3Rh dGVfYWxsb2MoY29ubmVjdG9yLT5kZXYpOwo+ICAJaWYgKCFzdGF0ZSkKClRoZSByZWFzb24gSSBk aWRuJ3QgZG8gdGhpcyBpcyB0aGF0IGEgcHJvcCBjaGFuZ2UgbWlnaHQgc3RpbGwgcmVzdWx0IGlu IG5vCmh3IHN0YXRlIGNoYW5nZSAoZS5nLiBpZiB5b3UgZ28gYXV0b21pdGljLT5leHBsaWNpdCBz ZXR0aW5nIG1hdGNoaW5nCmF1dG9tYXRpYyBvbmUpLiBIZW5jZSBJIHRoaW5rIHdlIG5lZWQgdG8g c29sdmUgdGhpcyBpbiBsb3dlciBsZXZlbHMKYW55d2F5LCBpLmUuIGluIHdoZW4gY29tcHV0aW5n IHRoZSBjb25maWcuIEJ1dCBpdCBzaG91bGRuJ3QgY2F1c2UgdHJvdWJsZQp5ZXQuCgo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2NydGMuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1f Y3J0Yy5jCj4gaW5kZXggNDI0YzgzMzIzYWFhLi41YmFiN2JmZjhhMTUgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL2RybV9jcnRjLmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2Ny dGMuYwo+IEBAIC0xMzI3LDcgKzEzMjcsOCBAQCB2b2lkIGRybV9wbGFuZV9mb3JjZV9kaXNhYmxl KHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lKQo+ICB7Cj4gIAlpbnQgcmV0Owo+ICAKPiAtCWlmICgh cGxhbmUtPmZiKQo+ICsJaWYgKChwbGFuZS0+c3RhdGUgJiYgIXBsYW5lLT5zdGF0ZS0+ZmIpIHx8 Cj4gKwkgICAgKCFwbGFuZS0+c3RhdGUgJiYgIXBsYW5lLT5mYikpCj4gIAkJcmV0dXJuOwoKTmFo LCBhdG9taWMgaGVscGVycyBzaG91bGQgZmlndXJlIHRoaXMgb3V0IGltby4gU2luY2UgaWYgdXNl cnNwYWNlIGRvZXMKdGhlIHNhbWUgKGxvb3Agb3ZlciBhbGwgcGxhbmVzKSB0aGVuIGl0IHdvbid0 IGdvIHRocm91Z2ggZm9yY2VfZGlzYWJsZS4KLURhbmllbAoKPiAgCj4gIAlwbGFuZS0+b2xkX2Zi ID0gcGxhbmUtPmZiOwo+IAoKLS0gCkRhbmllbCBWZXR0ZXIKU29mdHdhcmUgRW5naW5lZXIsIElu dGVsIENvcnBvcmF0aW9uCmh0dHA6Ly9ibG9nLmZmd2xsLmNoCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwt Z2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==