From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [Intel-gfx] [PATCH v2 02/20] drm: Don't update plane properties for atomic planes if it stays the same Date: Wed, 8 Jul 2015 19:52:26 +0200 Message-ID: <20150708175151.GA21858@phenom.ffwll.local> References: <1436252911-5703-1-git-send-email-maarten.lankhorst@linux.intel.com> <1436252911-5703-3-git-send-email-maarten.lankhorst@linux.intel.com> <20150707091847.GX7568@phenom.ffwll.local> <559BA7DA.8010701@linux.intel.com> <20150707121011.GQ7568@phenom.ffwll.local> <559BEB72.1050702@linux.intel.com> <20150707164352.GZ7568@phenom.ffwll.local> <559CD896.8040301@linux.intel.com> <20150708085508.GD7568@phenom.ffwll.local> <559D5163.7060204@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <559D5163.7060204@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKdWwgMDgsIDIwMTUgYXQgMDY6MzU6NDdQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMDgtMDctMTUgb20gMTA6NTUgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+ ID4gT24gV2VkLCBKdWwgMDgsIDIwMTUgYXQgMTA6MDA6MjJBTSArMDIwMCwgTWFhcnRlbiBMYW5r aG9yc3Qgd3JvdGU6Cj4gPj4gT3AgMDctMDctMTUgb20gMTg6NDMgc2NocmVlZiBEYW5pZWwgVmV0 dGVyOgo+ID4+PiBPbiBUdWUsIEp1bCAwNywgMjAxNSBhdCAwNTowODozNFBNICswMjAwLCBNYWFy dGVuIExhbmtob3JzdCB3cm90ZToKPiA+Pj4+IE9wIDA3LTA3LTE1IG9tIDE0OjEwIHNjaHJlZWYg RGFuaWVsIFZldHRlcjoKPiA+Pj4+PiBPbiBUdWUsIEp1bCAwNywgMjAxNSBhdCAxMjoyMDoxMFBN ICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90ZToKPiA+Pj4+Pj4gT3AgMDctMDctMTUgb20g MTE6MTggc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+ID4+Pj4+Pj4gT24gVHVlLCBKdWwgMDcsIDIw MTUgYXQgMDk6MDg6MTNBTSArMDIwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4gPj4+Pj4+ Pj4gVGhpcyBhbGxvd3MgdGhlIGZpcnN0IGF0b21pYyBjYWxsIGR1cmluZyBodyBpbml0IHRvIGJl IGEgcmVhbCBtb2Rlc2V0LAo+ID4+Pj4+Pj4+IHdoaWNoIGlzIHVzZWZ1bCBmb3IgZm9yY2luZyBh IHJlY2FsY3VsYXRpb24uCj4gPj4+Pj4+PiBmYmNvbiBpcyBvcHRpb25hbCwgeW91IGNhbid0IHJl bHkgb24gYW55dGhpbmcgYmVpbmcgZG9uZSBpbiBhbnkgc3BlY2lmaWMKPiA+Pj4+Pj4+IHdheS4g V2hhdCBleGFjdGx5IGRvIHlvdSBuZWVkIHRoaXMgZm9yLCB3aGF0J3MgdGhlIGltcGxpY2F0aW9u cz8KPiA+Pj4+Pj4gSW4gdGhlIGh3IHJlYWRvdXQgSSBub3RpY2VkIHNvbWUgd2FybmluZ3Mgd2hl biBJIHdhc24ndCBzZXR0aW5nIGFueSBtb2RlIHByb3BlcnR5IGluIHRoZSByZWFkb3V0Lgo+ID4+ Pj4+PiBJIHdhbnQgdGhlIGZpcnN0IGZ1bmN0aW9uIHRvIGJlIHRoZSBtb2Rlc2V0LCBzbyB3ZSBo YXZlIGEgc2FuZSBiYXNlIHRvIGNvbW1pdCBjaGFuZ2VzIG9uLgo+ID4+Pj4+PiBJZGVhbGx5IHRo aXMgd2hvbGUgZnVuY3Rpb24gd291bGQgaGF2ZSBhIGF0b21pYyBjb3VudGVycGFydCB3aGljaCBk b2VzIGl0IGluIG9uZSBnby4gOikKPiA+Pj4+PiBZZWFoLiBPdG9oIGFzIHNvb24gYXMgd2UgaGF2 ZSBhdG9taWMgbW9kZXNldCB3b3JraW5nIHdlIGNhbiByZXBsYWNlIGFsbAo+ID4+Pj4+IHRoZSBs ZWdhY3kgZW50cnkgcG9pbnRzIHdpdGggYXRvbWljIGhlbHBlcnMsIGFuZCB0aGVuIGV2ZW4gcGxh bmVfZGlzYWJsZQo+ID4+Pj4+IHdpbGwgYmUgYSBmdWxsIGF0b21pYyBtb2Rlc2V0Lgo+ID4+Pj4+ Cj4gPj4+Pj4gV2hhdCBkaWQgZmFsbCBhcGFydCB3aXRoIGp1c3QgdG91Y2hpbmcgcHJvcGVydGll cy9wbGFuZXMgbm93Pwo+ID4+Pj4gQWxzbyB3aGVuIGk5MTUgaXMgZnVsbHkgYXRvbWljIGl0IGNh bGN1bGF0ZXMgaW4gaW50ZWxfbW9kZXNldF9jb21wdXRlX2NvbmZpZwo+ID4+Pj4gaWYgYSBtb2Rl c2V0IGlzIG5lZWRlZCBhZnRlciB0aGUgZmlyc3QgYXRvbWljIGNhbGwuIFJpZ2h0IG5vdyBiZWNh dXNlCj4gPj4+PiBpbnRlbF9tb2Rlc2V0X2NvbXB1dGVfY29uZmlnIGlzIG9ubHkgY2FsbGVkIGlu IHNldF9jb25maWcgc28gdGhpcyB3b3JrcyBhcyBleHBlY3RlZC4KPiA+Pj4+IE90aGVyd2lzZSBk cm1fcGxhbmVfZm9yY2VfZGlzYWJsZSBvciByb3RhdGVfMCB3aWxsIGZvcmNlIGEgbW9kZXNldCwK PiA+Pj4+IGFuZCBpZiB0aGUgZmluYWwgbW9kZSBpcyBkaWZmZXJlbnQgdGhpcyB3aWxsIGludHJv ZHVjZSBhIGRvdWJsZSBtb2Rlc2V0Lgo+ID4+PiBGb3IgZXhwZW5zaXZlIHByb3BlcnRpZXMgKGku ZS4gYSBuby1vcCBjaGFuZ2VzIGNhdXNlcyBzb21ldGhpbmcgdGhhdCB0YWtlcwo+ID4+PiB0aW1l IGxpa2UgbW9kZXNldCBvciB2Ymxhbmsgd2FpdCkgd2UgbmVlZCB0byBtYWtlIHN1cmUgd2UgZmls dGVyIHRoZW0gb3V0Cj4gPj4+IGluIGF0b21pY19jaGVjay4gWWVhaCBub3QgcXVpdGUgdGhlcmUg eWV0IHdpdGggcHVyZSBhdG9taWMsIGJ1dCBtZWFud2hpbGUKPiA+Pj4gdGhlIGV4aXN0aW5nIGxl Z2FjeSBzZXRfcHJvcCBmdW5jdGlvbnMgc2hvdWxkIGFsbCBmaWx0ZXIgb3V0IG5vLW9wIGNoYW5n ZXMKPiA+Pj4gdGhlbXNlbHZlcy4gSWYgd2UgZG9uJ3QgZG8gdGhhdCBmb3Igcm90YXRpb24gdGhl biB0aGF0J3MgYSBidWcuCj4gPj4+Cj4gPj4+IFNhbWUgZm9yIGRpc2FibGluZyBwbGFuZXMgaGFy ZGVyLCB0aGF0IHNob3VsZG4ndCB0YWtlIHRpbWUuIEVzcGVjaWFsbHkKPiA+Pj4gc2luY2UgZmJj b24gb25seSBmb3JjZS1kaXNhYmxlIG5vbi1wcmltYXJ5IHBsYW5lLCBhbmQgZm9yIGRyaXZlciBs b2FkCj4gPj4+IHRoYXQncyB0aGUgZXhhY3QgdGhpbmcgd2UgYWxyZWFkeSBkbyBpbiB0aGUgZHJp dmVyIGFueXdheS4KPiA+PiBTb21ldGhpbmcgbGlrZSB0aGlzPwo+ID4+IC0tLQo+ID4+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyBiL2RyaXZlcnMvZ3B1 L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gPj4gaW5kZXggYTFkNGUxM2YzOTA4Li4yOTg5MjMy ZjQ5OTYgMTAwNjQ0Cj4gPj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVy LmMKPiA+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ID4+IEBA IC0zMCw2ICszMCw3IEBACj4gPj4gICNpbmNsdWRlIDxkcm0vZHJtX3BsYW5lX2hlbHBlci5oPgo+ ID4+ICAjaW5jbHVkZSA8ZHJtL2RybV9jcnRjX2hlbHBlci5oPgo+ID4+ICAjaW5jbHVkZSA8ZHJt L2RybV9hdG9taWNfaGVscGVyLmg+Cj4gPj4gKyNpbmNsdWRlICJkcm1fY3J0Y19pbnRlcm5hbC5o Igo+ID4+ICAjaW5jbHVkZSA8bGludXgvZmVuY2UuaD4KPiA+PiAgCj4gPj4gIC8qKgo+ID4+IEBA IC0xNzE2LDcgKzE3MTcsMTIgQEAgZHJtX2F0b21pY19oZWxwZXJfY3J0Y19zZXRfcHJvcGVydHko c3RydWN0IGRybV9jcnRjICpjcnRjLAo+ID4+ICB7Cj4gPj4gIAlzdHJ1Y3QgZHJtX2F0b21pY19z dGF0ZSAqc3RhdGU7Cj4gPj4gIAlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4g Pj4gLQlpbnQgcmV0ID0gMDsKPiA+PiArCXVpbnQ2NF90IHJldHZhbDsKPiA+PiArCWludCByZXQ7 Cj4gPj4gKwo+ID4+ICsJcmV0ID0gZHJtX2F0b21pY19nZXRfcHJvcGVydHkoJmNydGMtPmJhc2Us IHByb3BlcnR5LCAmcmV0dmFsKTsKPiA+PiArCWlmICghcmV0ICYmIHZhbCA9PSByZXR2YWwpCj4g Pj4gKwkJcmV0dXJuIDA7Cj4gPj4gIAo+ID4+ICAJc3RhdGUgPSBkcm1fYXRvbWljX3N0YXRlX2Fs bG9jKGNydGMtPmRldik7Cj4gPj4gIAlpZiAoIXN0YXRlKQo+ID4+IEBAIC0xNzc2LDcgKzE3ODIs MTIgQEAgZHJtX2F0b21pY19oZWxwZXJfcGxhbmVfc2V0X3Byb3BlcnR5KHN0cnVjdCBkcm1fcGxh bmUgKnBsYW5lLAo+ID4+ICB7Cj4gPj4gIAlzdHJ1Y3QgZHJtX2F0b21pY19zdGF0ZSAqc3RhdGU7 Cj4gPj4gIAlzdHJ1Y3QgZHJtX3BsYW5lX3N0YXRlICpwbGFuZV9zdGF0ZTsKPiA+PiAtCWludCBy ZXQgPSAwOwo+ID4+ICsJdWludDY0X3QgcmV0dmFsOwo+ID4+ICsJaW50IHJldDsKPiA+PiArCj4g Pj4gKwlyZXQgPSBkcm1fYXRvbWljX2dldF9wcm9wZXJ0eSgmcGxhbmUtPmJhc2UsIHByb3BlcnR5 LCAmcmV0dmFsKTsKPiA+PiArCWlmICghcmV0ICYmIHZhbCA9PSByZXR2YWwpCj4gPj4gKwkJcmV0 dXJuIDA7Cj4gPj4gIAo+ID4+ICAJc3RhdGUgPSBkcm1fYXRvbWljX3N0YXRlX2FsbG9jKHBsYW5l LT5kZXYpOwo+ID4+ICAJaWYgKCFzdGF0ZSkKPiA+PiBAQCAtMTgzNiw3ICsxODQ3LDEyIEBAIGRy bV9hdG9taWNfaGVscGVyX2Nvbm5lY3Rvcl9zZXRfcHJvcGVydHkoc3RydWN0IGRybV9jb25uZWN0 b3IgKmNvbm5lY3RvciwKPiA+PiAgewo+ID4+ICAJc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0 YXRlOwo+ID4+ICAJc3RydWN0IGRybV9jb25uZWN0b3Jfc3RhdGUgKmNvbm5lY3Rvcl9zdGF0ZTsK PiA+PiAtCWludCByZXQgPSAwOwo+ID4+ICsJdWludDY0X3QgcmV0dmFsOwo+ID4+ICsJaW50IHJl dDsKPiA+PiArCj4gPj4gKwlyZXQgPSBkcm1fYXRvbWljX2dldF9wcm9wZXJ0eSgmY29ubmVjdG9y LT5iYXNlLCBwcm9wZXJ0eSwgJnJldHZhbCk7Cj4gPj4gKwlpZiAoIXJldCAmJiB2YWwgPT0gcmV0 dmFsKQo+ID4+ICsJCXJldHVybiAwOwo+ID4+ICAKPiA+PiAgCXN0YXRlID0gZHJtX2F0b21pY19z dGF0ZV9hbGxvYyhjb25uZWN0b3ItPmRldik7Cj4gPj4gIAlpZiAoIXN0YXRlKQo+ID4gVGhlIHJl YXNvbiBJIGRpZG4ndCBkbyB0aGlzIGlzIHRoYXQgYSBwcm9wIGNoYW5nZSBtaWdodCBzdGlsbCBy ZXN1bHQgaW4gbm8KPiA+IGh3IHN0YXRlIGNoYW5nZSAoZS5nLiBpZiB5b3UgZ28gYXV0b21pdGlj LT5leHBsaWNpdCBzZXR0aW5nIG1hdGNoaW5nCj4gPiBhdXRvbWF0aWMgb25lKS4gSGVuY2UgSSB0 aGluayB3ZSBuZWVkIHRvIHNvbHZlIHRoaXMgaW4gbG93ZXIgbGV2ZWxzCj4gPiBhbnl3YXksIGku ZS4gaW4gd2hlbiBjb21wdXRpbmcgdGhlIGNvbmZpZy4gQnV0IGl0IHNob3VsZG4ndCBjYXVzZSB0 cm91YmxlCj4gPiB5ZXQuCj4gSXMgdGhhdCBhIGFjayBvciBuYWNrPwoKSSB0aGluayB3ZSBzaG91 bGRuJ3QgbmVlZCB0aGlzIHJlYWxseSBmb3IgaTkxNSwgYW5kIGl0IG1pZ2h0IGNvdmVyIHVwCmJ1 Z3MuIEkgcHJlZmVyIHdlIGp1c3QgZG8gdGhlIGV2YWRlIG1vZGVzZXQgbG9naWMgeW91J3ZlIGlt cGxlbWVudGVkIG9uY2UKd2Ugc3dpdGNoIG92ZXIgdG8gYXRvbWljIHByb3BzLiBTaW5jZSBhdG0g d2Ugb25seSBoYXZlIGF0b21pYyBwcm9wcyB3aGljaApnZXQgdXBkYXRlZCBpbiBwYWdlZmxpcHMg d2Ugc2hvdWxkbid0IGhhdmUgc2VyaW91cyBwcm9ibGVtcyBoZXJlIHlldCAoZm9yCnNldHRpbmcg dGhlIHJvdGF0aW9uIHByb3AgdG8gMMKwIGFnYWluIHdoZW4gZmJkZXYgc3RhcnRzIHVwKS4KCk9y IGRvIEkgbWlzcyBzb21ldGhpbmcgc3RpbGwgaGVyZT8KLURhbmllbAotLSAKRGFuaWVsIFZldHRl cgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3bGwu Y2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK