From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 02/20] drm: Don't update plane properties for atomic planes if it stays the same Date: Wed, 8 Jul 2015 22:12:41 +0200 Message-ID: <20150708201241.GB21858@phenom.ffwll.local> References: <20150707091847.GX7568@phenom.ffwll.local> <559BA7DA.8010701@linux.intel.com> <20150707121011.GQ7568@phenom.ffwll.local> <559BEB72.1050702@linux.intel.com> <20150707164352.GZ7568@phenom.ffwll.local> <559CD896.8040301@linux.intel.com> <20150708085508.GD7568@phenom.ffwll.local> <559D5163.7060204@linux.intel.com> <20150708175151.GA21858@phenom.ffwll.local> <559D6B03.2060804@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f177.google.com (mail-wi0-f177.google.com [209.85.212.177]) by gabe.freedesktop.org (Postfix) with ESMTPS id B5EEC6E37C for ; Wed, 8 Jul 2015 13:09:56 -0700 (PDT) Received: by widjy10 with SMTP id jy10so226901755wid.1 for ; Wed, 08 Jul 2015 13:09:55 -0700 (PDT) Content-Disposition: inline In-Reply-To: <559D6B03.2060804@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Maarten Lankhorst Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCBKdWwgMDgsIDIwMTUgYXQgMDg6MjU6MDdQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9y c3Qgd3JvdGU6Cj4gT3AgMDgtMDctMTUgb20gMTk6NTIgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+ ID4gT24gV2VkLCBKdWwgMDgsIDIwMTUgYXQgMDY6MzU6NDdQTSArMDIwMCwgTWFhcnRlbiBMYW5r aG9yc3Qgd3JvdGU6Cj4gPj4gT3AgMDgtMDctMTUgb20gMTA6NTUgc2NocmVlZiBEYW5pZWwgVmV0 dGVyOgo+ID4+PiBPbiBXZWQsIEp1bCAwOCwgMjAxNSBhdCAxMDowMDoyMkFNICswMjAwLCBNYWFy dGVuIExhbmtob3JzdCB3cm90ZToKPiA+Pj4+IE9wIDA3LTA3LTE1IG9tIDE4OjQzIHNjaHJlZWYg RGFuaWVsIFZldHRlcjoKPiA+Pj4+PiBPbiBUdWUsIEp1bCAwNywgMjAxNSBhdCAwNTowODozNFBN ICswMjAwLCBNYWFydGVuIExhbmtob3JzdCB3cm90ZToKPiA+Pj4+Pj4gT3AgMDctMDctMTUgb20g MTQ6MTAgc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+ID4+Pj4+Pj4gT24gVHVlLCBKdWwgMDcsIDIw MTUgYXQgMTI6MjA6MTBQTSArMDIwMCwgTWFhcnRlbiBMYW5raG9yc3Qgd3JvdGU6Cj4gPj4+Pj4+ Pj4gT3AgMDctMDctMTUgb20gMTE6MTggc2NocmVlZiBEYW5pZWwgVmV0dGVyOgo+ID4+Pj4+Pj4+ PiBPbiBUdWUsIEp1bCAwNywgMjAxNSBhdCAwOTowODoxM0FNICswMjAwLCBNYWFydGVuIExhbmto b3JzdCB3cm90ZToKPiA+Pj4+Pj4+Pj4+IFRoaXMgYWxsb3dzIHRoZSBmaXJzdCBhdG9taWMgY2Fs bCBkdXJpbmcgaHcgaW5pdCB0byBiZSBhIHJlYWwgbW9kZXNldCwKPiA+Pj4+Pj4+Pj4+IHdoaWNo IGlzIHVzZWZ1bCBmb3IgZm9yY2luZyBhIHJlY2FsY3VsYXRpb24uCj4gPj4+Pj4+Pj4+IGZiY29u IGlzIG9wdGlvbmFsLCB5b3UgY2FuJ3QgcmVseSBvbiBhbnl0aGluZyBiZWluZyBkb25lIGluIGFu eSBzcGVjaWZpYwo+ID4+Pj4+Pj4+PiB3YXkuIFdoYXQgZXhhY3RseSBkbyB5b3UgbmVlZCB0aGlz IGZvciwgd2hhdCdzIHRoZSBpbXBsaWNhdGlvbnM/Cj4gPj4+Pj4+Pj4gSW4gdGhlIGh3IHJlYWRv dXQgSSBub3RpY2VkIHNvbWUgd2FybmluZ3Mgd2hlbiBJIHdhc24ndCBzZXR0aW5nIGFueSBtb2Rl IHByb3BlcnR5IGluIHRoZSByZWFkb3V0Lgo+ID4+Pj4+Pj4+IEkgd2FudCB0aGUgZmlyc3QgZnVu Y3Rpb24gdG8gYmUgdGhlIG1vZGVzZXQsIHNvIHdlIGhhdmUgYSBzYW5lIGJhc2UgdG8gY29tbWl0 IGNoYW5nZXMgb24uCj4gPj4+Pj4+Pj4gSWRlYWxseSB0aGlzIHdob2xlIGZ1bmN0aW9uIHdvdWxk IGhhdmUgYSBhdG9taWMgY291bnRlcnBhcnQgd2hpY2ggZG9lcyBpdCBpbiBvbmUgZ28uIDopCj4g Pj4+Pj4+PiBZZWFoLiBPdG9oIGFzIHNvb24gYXMgd2UgaGF2ZSBhdG9taWMgbW9kZXNldCB3b3Jr aW5nIHdlIGNhbiByZXBsYWNlIGFsbAo+ID4+Pj4+Pj4gdGhlIGxlZ2FjeSBlbnRyeSBwb2ludHMg d2l0aCBhdG9taWMgaGVscGVycywgYW5kIHRoZW4gZXZlbiBwbGFuZV9kaXNhYmxlCj4gPj4+Pj4+ PiB3aWxsIGJlIGEgZnVsbCBhdG9taWMgbW9kZXNldC4KPiA+Pj4+Pj4+Cj4gPj4+Pj4+PiBXaGF0 IGRpZCBmYWxsIGFwYXJ0IHdpdGgganVzdCB0b3VjaGluZyBwcm9wZXJ0aWVzL3BsYW5lcyBub3c/ Cj4gPj4+Pj4+IEFsc28gd2hlbiBpOTE1IGlzIGZ1bGx5IGF0b21pYyBpdCBjYWxjdWxhdGVzIGlu IGludGVsX21vZGVzZXRfY29tcHV0ZV9jb25maWcKPiA+Pj4+Pj4gaWYgYSBtb2Rlc2V0IGlzIG5l ZWRlZCBhZnRlciB0aGUgZmlyc3QgYXRvbWljIGNhbGwuIFJpZ2h0IG5vdyBiZWNhdXNlCj4gPj4+ Pj4+IGludGVsX21vZGVzZXRfY29tcHV0ZV9jb25maWcgaXMgb25seSBjYWxsZWQgaW4gc2V0X2Nv bmZpZyBzbyB0aGlzIHdvcmtzIGFzIGV4cGVjdGVkLgo+ID4+Pj4+PiBPdGhlcndpc2UgZHJtX3Bs YW5lX2ZvcmNlX2Rpc2FibGUgb3Igcm90YXRlXzAgd2lsbCBmb3JjZSBhIG1vZGVzZXQsCj4gPj4+ Pj4+IGFuZCBpZiB0aGUgZmluYWwgbW9kZSBpcyBkaWZmZXJlbnQgdGhpcyB3aWxsIGludHJvZHVj ZSBhIGRvdWJsZSBtb2Rlc2V0Lgo+ID4+Pj4+IEZvciBleHBlbnNpdmUgcHJvcGVydGllcyAoaS5l LiBhIG5vLW9wIGNoYW5nZXMgY2F1c2VzIHNvbWV0aGluZyB0aGF0IHRha2VzCj4gPj4+Pj4gdGlt ZSBsaWtlIG1vZGVzZXQgb3IgdmJsYW5rIHdhaXQpIHdlIG5lZWQgdG8gbWFrZSBzdXJlIHdlIGZp bHRlciB0aGVtIG91dAo+ID4+Pj4+IGluIGF0b21pY19jaGVjay4gWWVhaCBub3QgcXVpdGUgdGhl cmUgeWV0IHdpdGggcHVyZSBhdG9taWMsIGJ1dCBtZWFud2hpbGUKPiA+Pj4+PiB0aGUgZXhpc3Rp bmcgbGVnYWN5IHNldF9wcm9wIGZ1bmN0aW9ucyBzaG91bGQgYWxsIGZpbHRlciBvdXQgbm8tb3Ag Y2hhbmdlcwo+ID4+Pj4+IHRoZW1zZWx2ZXMuIElmIHdlIGRvbid0IGRvIHRoYXQgZm9yIHJvdGF0 aW9uIHRoZW4gdGhhdCdzIGEgYnVnLgo+ID4+Pj4+Cj4gPj4+Pj4gU2FtZSBmb3IgZGlzYWJsaW5n IHBsYW5lcyBoYXJkZXIsIHRoYXQgc2hvdWxkbid0IHRha2UgdGltZS4gRXNwZWNpYWxseQo+ID4+ Pj4+IHNpbmNlIGZiY29uIG9ubHkgZm9yY2UtZGlzYWJsZSBub24tcHJpbWFyeSBwbGFuZSwgYW5k IGZvciBkcml2ZXIgbG9hZAo+ID4+Pj4+IHRoYXQncyB0aGUgZXhhY3QgdGhpbmcgd2UgYWxyZWFk eSBkbyBpbiB0aGUgZHJpdmVyIGFueXdheS4KPiA+Pj4+IFNvbWV0aGluZyBsaWtlIHRoaXM/Cj4g Pj4+PiAtLS0KPiA+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19o ZWxwZXIuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gPj4+PiBpbmRl eCBhMWQ0ZTEzZjM5MDguLjI5ODkyMzJmNDk5NiAxMDA2NDQKPiA+Pj4+IC0tLSBhL2RyaXZlcnMv Z3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gPj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0v ZHJtX2F0b21pY19oZWxwZXIuYwo+ID4+Pj4gQEAgLTMwLDYgKzMwLDcgQEAKPiA+Pj4+ICAjaW5j bHVkZSA8ZHJtL2RybV9wbGFuZV9oZWxwZXIuaD4KPiA+Pj4+ICAjaW5jbHVkZSA8ZHJtL2RybV9j cnRjX2hlbHBlci5oPgo+ID4+Pj4gICNpbmNsdWRlIDxkcm0vZHJtX2F0b21pY19oZWxwZXIuaD4K PiA+Pj4+ICsjaW5jbHVkZSAiZHJtX2NydGNfaW50ZXJuYWwuaCIKPiA+Pj4+ICAjaW5jbHVkZSA8 bGludXgvZmVuY2UuaD4KPiA+Pj4+ICAKPiA+Pj4+ICAvKioKPiA+Pj4+IEBAIC0xNzE2LDcgKzE3 MTcsMTIgQEAgZHJtX2F0b21pY19oZWxwZXJfY3J0Y19zZXRfcHJvcGVydHkoc3RydWN0IGRybV9j cnRjICpjcnRjLAo+ID4+Pj4gIHsKPiA+Pj4+ICAJc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0 YXRlOwo+ID4+Pj4gIAlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gPj4+PiAt CWludCByZXQgPSAwOwo+ID4+Pj4gKwl1aW50NjRfdCByZXR2YWw7Cj4gPj4+PiArCWludCByZXQ7 Cj4gPj4+PiArCj4gPj4+PiArCXJldCA9IGRybV9hdG9taWNfZ2V0X3Byb3BlcnR5KCZjcnRjLT5i YXNlLCBwcm9wZXJ0eSwgJnJldHZhbCk7Cj4gPj4+PiArCWlmICghcmV0ICYmIHZhbCA9PSByZXR2 YWwpCj4gPj4+PiArCQlyZXR1cm4gMDsKPiA+Pj4+ICAKPiA+Pj4+ICAJc3RhdGUgPSBkcm1fYXRv bWljX3N0YXRlX2FsbG9jKGNydGMtPmRldik7Cj4gPj4+PiAgCWlmICghc3RhdGUpCj4gPj4+PiBA QCAtMTc3Niw3ICsxNzgyLDEyIEBAIGRybV9hdG9taWNfaGVscGVyX3BsYW5lX3NldF9wcm9wZXJ0 eShzdHJ1Y3QgZHJtX3BsYW5lICpwbGFuZSwKPiA+Pj4+ICB7Cj4gPj4+PiAgCXN0cnVjdCBkcm1f YXRvbWljX3N0YXRlICpzdGF0ZTsKPiA+Pj4+ICAJc3RydWN0IGRybV9wbGFuZV9zdGF0ZSAqcGxh bmVfc3RhdGU7Cj4gPj4+PiAtCWludCByZXQgPSAwOwo+ID4+Pj4gKwl1aW50NjRfdCByZXR2YWw7 Cj4gPj4+PiArCWludCByZXQ7Cj4gPj4+PiArCj4gPj4+PiArCXJldCA9IGRybV9hdG9taWNfZ2V0 X3Byb3BlcnR5KCZwbGFuZS0+YmFzZSwgcHJvcGVydHksICZyZXR2YWwpOwo+ID4+Pj4gKwlpZiAo IXJldCAmJiB2YWwgPT0gcmV0dmFsKQo+ID4+Pj4gKwkJcmV0dXJuIDA7Cj4gPj4+PiAgCj4gPj4+ PiAgCXN0YXRlID0gZHJtX2F0b21pY19zdGF0ZV9hbGxvYyhwbGFuZS0+ZGV2KTsKPiA+Pj4+ICAJ aWYgKCFzdGF0ZSkKPiA+Pj4+IEBAIC0xODM2LDcgKzE4NDcsMTIgQEAgZHJtX2F0b21pY19oZWxw ZXJfY29ubmVjdG9yX3NldF9wcm9wZXJ0eShzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9y LAo+ID4+Pj4gIHsKPiA+Pj4+ICAJc3RydWN0IGRybV9hdG9taWNfc3RhdGUgKnN0YXRlOwo+ID4+ Pj4gIAlzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9zdGF0ZSAqY29ubmVjdG9yX3N0YXRlOwo+ID4+Pj4g LQlpbnQgcmV0ID0gMDsKPiA+Pj4+ICsJdWludDY0X3QgcmV0dmFsOwo+ID4+Pj4gKwlpbnQgcmV0 Owo+ID4+Pj4gKwo+ID4+Pj4gKwlyZXQgPSBkcm1fYXRvbWljX2dldF9wcm9wZXJ0eSgmY29ubmVj dG9yLT5iYXNlLCBwcm9wZXJ0eSwgJnJldHZhbCk7Cj4gPj4+PiArCWlmICghcmV0ICYmIHZhbCA9 PSByZXR2YWwpCj4gPj4+PiArCQlyZXR1cm4gMDsKPiA+Pj4+ICAKPiA+Pj4+ICAJc3RhdGUgPSBk cm1fYXRvbWljX3N0YXRlX2FsbG9jKGNvbm5lY3Rvci0+ZGV2KTsKPiA+Pj4+ICAJaWYgKCFzdGF0 ZSkKPiA+Pj4gVGhlIHJlYXNvbiBJIGRpZG4ndCBkbyB0aGlzIGlzIHRoYXQgYSBwcm9wIGNoYW5n ZSBtaWdodCBzdGlsbCByZXN1bHQgaW4gbm8KPiA+Pj4gaHcgc3RhdGUgY2hhbmdlIChlLmcuIGlm IHlvdSBnbyBhdXRvbWl0aWMtPmV4cGxpY2l0IHNldHRpbmcgbWF0Y2hpbmcKPiA+Pj4gYXV0b21h dGljIG9uZSkuIEhlbmNlIEkgdGhpbmsgd2UgbmVlZCB0byBzb2x2ZSB0aGlzIGluIGxvd2VyIGxl dmVscwo+ID4+PiBhbnl3YXksIGkuZS4gaW4gd2hlbiBjb21wdXRpbmcgdGhlIGNvbmZpZy4gQnV0 IGl0IHNob3VsZG4ndCBjYXVzZSB0cm91YmxlCj4gPj4+IHlldC4KPiA+PiBJcyB0aGF0IGEgYWNr IG9yIG5hY2s/Cj4gPiBJIHRoaW5rIHdlIHNob3VsZG4ndCBuZWVkIHRoaXMgcmVhbGx5IGZvciBp OTE1LCBhbmQgaXQgbWlnaHQgY292ZXIgdXAKPiA+IGJ1Z3MuIEkgcHJlZmVyIHdlIGp1c3QgZG8g dGhlIGV2YWRlIG1vZGVzZXQgbG9naWMgeW91J3ZlIGltcGxlbWVudGVkIG9uY2UKPiA+IHdlIHN3 aXRjaCBvdmVyIHRvIGF0b21pYyBwcm9wcy4gU2luY2UgYXRtIHdlIG9ubHkgaGF2ZSBhdG9taWMg cHJvcHMgd2hpY2gKPiA+IGdldCB1cGRhdGVkIGluIHBhZ2VmbGlwcyB3ZSBzaG91bGRuJ3QgaGF2 ZSBzZXJpb3VzIHByb2JsZW1zIGhlcmUgeWV0IChmb3IKPiA+IHNldHRpbmcgdGhlIHJvdGF0aW9u IHByb3AgdG8gMMKwIGFnYWluIHdoZW4gZmJkZXYgc3RhcnRzIHVwKS4KPiA+Cj4gPiBPciBkbyBJ IG1pc3Mgc29tZXRoaW5nIHN0aWxsIGhlcmU/Cj4gWWVzLCBpZiB0aGUgaGFyZHdhcmUgbW9kZSBp cyBpbmNvbXBhdGlibGUgd2l0aCBpdHMgY2FsY3VsYXRlZCBzdyBtb2RlLAo+IGFuZCB3ZSBzZXQg YSBkaWZmZXJlbnQgbW9kZSBmcm9tIGZiZGV2IHlvdSBnZXQgMiBtb2Rlc2V0cyBpbnN0ZWFkIG9m IDEuCgpIb3cgZG9lcyB0aGF0IGhhcHBlbj8gRm9yIHNldHRpbmcgdGhlIHJvdGF0aW9uIHByb3Bl cnR5IHdlIHNob3VsZCBqdXN0CmR1cGxpY2F0ZSB0aGUgY3VycmVudCBjcnRjIHN0YXRlLiBTaW5j ZSB0aGVyZSdzIG5vIG1vZGUgY2hhbmdpbmcgKHRoZXkKc2hvdWxkIG1hdGNoIHBlcmZlY3RseSBu byBtYXR0ZXIgaG93IGJvdGNoZWQgdGhlIHJlY29uc3RydWN0aW9uIGlzKSB0aGVyZQpzaG91bGRu J3QgYmUgYW55IG5lZWQgdG8gcmVjb21wdXRlIHRoZSBjb25maWcgY29tcGxldGVseSBhbmQgZGlz Y292ZXIgdGhhdAp0aGVyZSdzIGEgbWlzbWF0Y2guIFdoaWNoIG1lYW5zIHdlJ2xsIGp1c3QgZG8g dGhlIHBsYW5lIHVwZGF0ZSAod2hpY2gKbWlnaHQgZG8gYSBmZXcgc2lsbHkgbW1pb3MgYnV0IHNo b3VsZG4ndCBibG9jaykgYW5kIHRoYXQncyBpdC4KCkF0IGxlYXN0IHRoYXQncyB3aGF0IEknZCBl eHBlY3QgLSB3aGVyZSBkb2VzIHRoaXMgZmFsbCBhcGFydD8KLURhbmllbAotLSAKRGFuaWVsIFZl dHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3 bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK