From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Daniel Vetter <daniel.vetter@intel.com>,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>,
DRI Development <dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH 06/14] drm/i915: Use drm_for_each_fb in i915_debugfs.c
Date: Fri, 10 Jul 2015 10:53:01 +0300 [thread overview]
Message-ID: <20150710075301.GM5176@intel.com> (raw)
In-Reply-To: <1436478277-10861-7-git-send-email-daniel.vetter@ffwll.ch>
On Thu, Jul 09, 2015 at 11:44:29PM +0200, Daniel Vetter wrote:
> Just so I have a user for this macro.
>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c
> index 053adbb97037..60eebf5f6da8 100644
> --- a/drivers/gpu/drm/i915/i915_debugfs.c
> +++ b/drivers/gpu/drm/i915/i915_debugfs.c
> @@ -1855,6 +1855,7 @@ static int i915_gem_framebuffer_info(struct seq_file *m, void *data)
> struct drm_device *dev = node->minor->dev;
> struct intel_fbdev *ifbdev = NULL;
> struct intel_framebuffer *fb;
> + struct drm_framebuffer *drm_fb;
>
> #ifdef CONFIG_DRM_I915_FBDEV
> struct drm_i915_private *dev_priv = dev->dev_private;
> @@ -1874,7 +1875,8 @@ static int i915_gem_framebuffer_info(struct seq_file *m, void *data)
> #endif
>
> mutex_lock(&dev->mode_config.fb_lock);
> - list_for_each_entry(fb, &dev->mode_config.fb_list, base.head) {
> + drm_for_each_plane(drm_fb, dev) {
^^^^^
That's no fb.
> + fb = to_intel_framebuffer(drm_fb);
> if (ifbdev && &fb->base == ifbdev->helper.fb)
> continue;
>
> --
> 2.1.4
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel OTC
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-07-10 7:53 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 21:44 [PATCH 00/14] drm_connector locking rules, v2 Daniel Vetter
2015-07-09 21:44 ` [PATCH 01/14] drm: Simplify drm_for_each_legacy_plane arguments Daniel Vetter
2015-07-09 21:44 ` [PATCH 02/14] drm: Add modeset object iterators Daniel Vetter
2015-07-09 21:44 ` [PATCH 03/14] drm/probe-helper: Grab mode_config.mutex in poll_init/enable Daniel Vetter
2015-07-09 21:44 ` [PATCH 04/14] drm/fbdev-helper: Grab mode_config.mutex in drm_fb_helper_single_add_all_connectors Daniel Vetter
2015-07-09 21:44 ` [PATCH 05/14] drm: Check locking in drm_for_each_connector Daniel Vetter
2015-07-28 22:40 ` Laurent Pinchart
2015-07-09 21:44 ` [PATCH 06/14] drm/i915: Use drm_for_each_fb in i915_debugfs.c Daniel Vetter
2015-07-10 7:53 ` Ville Syrjälä [this message]
2015-07-10 17:02 ` [PATCH] " Daniel Vetter
2015-07-09 21:44 ` [PATCH 07/14] drm: Check locking in drm_for_each_fb Daniel Vetter
2015-07-09 21:44 ` [PATCH 08/14] drm/i915: Take all modeset locks for DP MST hotplug Daniel Vetter
2015-07-09 21:44 ` [PATCH 09/14] drm/radeon: " Daniel Vetter
2015-07-09 21:44 ` [PATCH 10/14] drm: Amend connector list locking rules Daniel Vetter
2015-07-09 21:44 ` [PATCH 11/14] drm: Roll out drm_for_each_connector more Daniel Vetter
2015-07-09 21:44 ` [PATCH 12/14] drm: Roll out drm_for_each_{plane,crtc,encoder} Daniel Vetter
2015-07-09 21:44 ` [PATCH 13/14] drm: Stop filtering according to mode_group in getresources Daniel Vetter
2015-07-09 21:44 ` [PATCH 14/14] drm: gc now dead mode_group code Daniel Vetter
2015-07-22 13:05 ` Maarten Lankhorst
2015-07-22 14:46 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150710075301.GM5176@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox