From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Dmitry V. Levin" <ldv@altlinux.org>
Subject: Re: [PATCH v3 4/5] drm: Add decoding of i915 ioctls
Date: Fri, 10 Jul 2015 15:57:33 +0300
Message-ID: <20150710125733.GA16935@altlinux.org>
References: <1435755168-16207-1-git-send-email-patrik.jakobsson@linux.intel.com>
 <1435755168-16207-5-git-send-email-patrik.jakobsson@linux.intel.com>
 <20150703003609.GB29080@altlinux.org>
 <20150706103552.GB2459@patrik-dev-mach>
 <20150706164024.6fbf994c@guiness.lab.lse.epita.fr>
 <20150708001136.GA8326@altlinux.org>
 <20150710123638.GC7945@patrik-dev-mach>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1507336023=="
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from pegasus3.altlinux.org (pegasus3.altlinux.org [194.107.17.103])
 by gabe.freedesktop.org (Postfix) with ESMTP id 225E96E3B2
 for <intel-gfx@lists.freedesktop.org>; Fri, 10 Jul 2015 05:57:36 -0700 (PDT)
In-Reply-To: <20150710123638.GC7945@patrik-dev-mach>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Patrik Jakobsson <patrik.jakobsson@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, strace-devel@lists.sourceforge.net
List-Id: intel-gfx@lists.freedesktop.org


--===============1507336023==
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="5vNYLRcllDrimb99"
Content-Disposition: inline


--5vNYLRcllDrimb99
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Jul 10, 2015 at 02:36:38PM +0200, Patrik Jakobsson wrote:
> On Wed, Jul 08, 2015 at 03:11:36AM +0300, Dmitry V. Levin wrote:
> > On Mon, Jul 06, 2015 at 04:40:24PM +0200, Gabriel Laskar wrote:
[...]
> > > Anyway, SYS_FUNC(ioctl) is a bit complicated, and the handling of the
> > > fallbacks on failure should be more generic.
> >=20
> > What would be useful is a way for "on entering" parsers to return
> > "done with decoding" information to their callers.
> >=20
> > This could be implemented by or'ing return value in the current semanti=
cs
> > with a flag with "done with decoding" meaning, e.g. RVAL_DONE.
> >=20
> > If an ioctl parser returned RVAL_DONE, this would tell SYS_FUNC(ioctl)
> > that the decoding is finished but fallback decoding is needed, while
> > RVAL_DONE+1 would mean that the decoding is finished and no fallback
> > decoding is needed.
>=20
> I like that idea but isn't the current return semantics already good enou=
gh
> for that? The problem right now is that we ignore the return value from
> ioctl_decode() "on entering".

After commit v4.10-104-g204c2bc we no longer ignore the return value from
ioctl_decode() "on entering".


--=20
ldv

--5vNYLRcllDrimb99
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iEYEARECAAYFAlWfwT0ACgkQfKvmrJ41Nh5G7gCfcYvnI5JNBq+uKum9r60q9Opv
pOgAn0A58ccKd8++eJb52Z3JybAlEeuO
=kjZu
-----END PGP SIGNATURE-----

--5vNYLRcllDrimb99--

--===============1507336023==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4
IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK

--===============1507336023==--