From: Damien Lespiau <damien.lespiau@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: Adjust BXT HDMI port clock limits
Date: Fri, 10 Jul 2015 14:27:48 +0100 [thread overview]
Message-ID: <20150710132748.GE4901@strange.ger.corp.intel.com> (raw)
In-Reply-To: <20150710132127.GN5176@intel.com>
On Fri, Jul 10, 2015 at 04:21:27PM +0300, Ville Syrjälä wrote:
> On Fri, Jul 10, 2015 at 02:18:57PM +0100, Damien Lespiau wrote:
> > On Fri, Jul 10, 2015 at 04:09:42PM +0300, Imre Deak wrote:
> > > On ma, 2015-07-06 at 14:44 +0300, ville.syrjala@linux.intel.com wrote:
> > > > From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > > >
> > > > Since
> > > > commit e62925567c7926e78bc8ca976cde5c28ea265a49
> > > > Author: Vandana Kannan <vandana.kannan@intel.com>
> > > > Date: Wed Jul 1 17:02:57 2015 +0530
> > > >
> > > > drm/i915/bxt: BUNs related to port PLL
> > > >
> > > > BXT DPLL can now generate frequencies in the 216-223 MHz range.
> > > > Adjust the HDMI port clock checks to account for the reduced range
> > > > of invalid frequencies.
> > > >
> > > > Cc: Vandana Kannan <vandana.kannan@intel.com>
> > > > Cc: Imre Deak <imre.deak@intel.com>
> > > > Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> > >
> > > Ville wrote a tool for CHV that calculates the valid frequencies based
> > > on the algorithm in the kernel. With the help of that I verified that
> > > this matches the list of target frequencies bxt_find_best_dpll() will
> > > accept, so:
> >
> > Could we have that tool in i-g-t?
>
> We could lift all the .find_dpll routines from the kernel into i-g-t.
> The only real concern is that we'll forget to update the i-g-t copies
> when changing the kernel. But I guess it would still be easier to just
> update them slightly when noticing that rather than having to lift them
> from the kernel all over again.
Right, while not ideal, I think having something in i-g-t, even if it
diverges slightly (but then we can remind the patch author to update the
i-g-t tool during review) is still better than not having that code
around at all.
--
Damien
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-07-10 13:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 11:44 [PATCH] drm/i915: Adjust BXT HDMI port clock limits ville.syrjala
2015-07-08 9:37 ` Kannan, Vandana
2015-07-10 13:11 ` Imre Deak
2015-07-10 13:09 ` Imre Deak
2015-07-10 13:18 ` Damien Lespiau
2015-07-10 13:21 ` Ville Syrjälä
2015-07-10 13:27 ` Damien Lespiau [this message]
2015-07-13 9:05 ` Daniel Vetter
2015-07-13 17:32 ` Bish, Jim
2015-07-14 7:53 ` Daniel Vetter
2015-07-13 9:10 ` Daniel Vetter
2015-07-10 20:22 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150710132748.GE4901@strange.ger.corp.intel.com \
--to=damien.lespiau@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox