From: Daniel Vetter <daniel@ffwll.ch>
To: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Cc: jani.nikula@intel.com, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915: storm detection documentation update
Date: Mon, 13 Jul 2015 11:22:42 +0200 [thread overview]
Message-ID: <20150713092242.GX3736@phenom.ffwll.local> (raw)
In-Reply-To: <1436511643-1586-1-git-send-email-sivakumar.thulasimani@intel.com>
On Fri, Jul 10, 2015 at 12:30:43PM +0530, Sivakumar Thulasimani wrote:
> From: "Thulasimani,Sivakumar" <sivakumar.thulasimani@intel.com>
>
> Update the hotplug documentation to explain that hotplug storm
> is not expected for Display port panels and hence is not handled
> in current code.
>
> v2: update the statements as recommended by Daniel
>
> Signed-off-by: Sivakumar Thulasimani <sivakumar.thulasimani@intel.com>
Queued for -next, thanks for the patch.
-Daniel
> ---
> drivers/gpu/drm/i915/intel_hotplug.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/intel_hotplug.c b/drivers/gpu/drm/i915/intel_hotplug.c
> index bac91a1..3c9171f 100644
> --- a/drivers/gpu/drm/i915/intel_hotplug.c
> +++ b/drivers/gpu/drm/i915/intel_hotplug.c
> @@ -66,6 +66,14 @@
> * while before being re-enabled. The intention is to mitigate issues raising
> * from broken hardware triggering massive amounts of interrupts and grinding
> * the system to a halt.
> + *
> + * Current implementation expects that hotplug interrupt storm will not be
> + * seen when display port sink is connected, hence on platforms whose DP
> + * callback is handled by i915_digport_work_func reenabling of hpd is not
> + * performed (it was never expected to be disabled in the first place ;) )
> + * this is specific to DP sinks handled by this routine and any other display
> + * such as HDMI or DVI enabled on the same port will have proper logic since
> + * it will use i915_hotplug_work_func where this logic is handled.
> */
>
> enum port intel_hpd_pin_to_port(enum hpd_pin pin)
> --
> 1.7.9.5
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-07-13 9:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 7:00 [PATCH] drm/i915: storm detection documentation update Sivakumar Thulasimani
2015-07-11 11:32 ` shuang.he
2015-07-13 9:22 ` Daniel Vetter [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-07-07 10:40 Sivakumar Thulasimani
2015-07-07 11:31 ` Daniel Vetter
2015-07-08 13:24 ` Sivakumar Thulasimani
2015-07-08 15:20 ` Daniel Vetter
2015-07-09 12:52 ` Sivakumar Thulasimani
2015-07-09 16:19 ` Daniel Vetter
2015-07-11 1:17 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150713092242.GX3736@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=sivakumar.thulasimani@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox