From: Daniel Vetter <daniel@ffwll.ch>
To: Chris Wilson <chris@chris-wilson.co.uk>,
Imre Deak <imre.deak@intel.com>,
intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/2] drm/i915: remove unused has_dma_mapping flag
Date: Mon, 13 Jul 2015 16:46:10 +0200 [thread overview]
Message-ID: <20150713144610.GO3736@phenom.ffwll.local> (raw)
In-Reply-To: <20150708174323.GK32370@nuc-i3427.alporthouse.com>
On Wed, Jul 08, 2015 at 06:43:23PM +0100, Chris Wilson wrote:
> On Wed, Jul 08, 2015 at 07:18:59PM +0300, Imre Deak wrote:
> > After the previous patch this flag will check always clear, as it's
> > never set for shmem backed and userptr objects, so we can remove it.
> >
> > Signed-off-by: Imre Deak <imre.deak@intel.com>
>
> Mentioned a trivial obj->get_page bugfix for
> __i915_gem_userptr_set_pages(), and then went on an archaelogical dig to
> understand why I didn't think of this earlier. Apparently, it just never
> occurred to me that I could remove this flag introduced for
> i915_gem_prime when we did the get_pages/put_pages support for it.
>
> Both patches (incl. the minor fix above for 1),
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Applied to -fixes (too lazy for a backmerge), thanks.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2015-07-13 14:43 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-06 14:50 [PATCH] drm/i915: avoid leaking DMA mappings Imre Deak
2015-07-06 14:57 ` Chris Wilson
2015-07-06 15:11 ` Imre Deak
2015-07-06 15:28 ` Chris Wilson
2015-07-06 15:31 ` Imre Deak
2015-07-06 15:29 ` Daniel Vetter
2015-07-06 15:30 ` Imre Deak
2015-07-06 15:33 ` Chris Wilson
2015-07-06 15:56 ` Imre Deak
2015-07-06 16:04 ` Chris Wilson
2015-07-06 16:23 ` Imre Deak
2015-07-06 15:11 ` Tvrtko Ursulin
2015-07-06 15:21 ` Imre Deak
2015-07-07 19:09 ` shuang.he
2015-07-08 16:18 ` [PATCH v2 1/2] " Imre Deak
2015-07-08 17:19 ` Chris Wilson
2015-07-09 9:59 ` [PATCH v3 " Imre Deak
2015-07-09 10:04 ` Chris Wilson
2015-07-11 20:54 ` Chris Wilson
2015-07-13 12:15 ` Imre Deak
2015-07-08 16:18 ` [PATCH 2/2] drm/i915: remove unused has_dma_mapping flag Imre Deak
2015-07-08 17:43 ` Chris Wilson
2015-07-13 14:46 ` Daniel Vetter [this message]
2015-07-09 0:07 ` shuang.he
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150713144610.GO3736@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=chris@chris-wilson.co.uk \
--cc=imre.deak@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox